dma: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver
PATCH 2/2 dma: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver
Quoted 10 lines · Hyun Kwon
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
Review
Quoted 5 lines
(quoted diff) +5
-0+static int xilinx_dpdma_config(struct dma_chan *dchan, + struct dma_slave_config *config) +{ + if (config->direction != DMA_MEM_TO_DEV) + return -EINVAL;?? Why are the config values not used, how else do you configure the channel?
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
There's not much configuration to be done. Channels are pretty much
identical
Quoted 1 line
with fixed configurations.
hmmm, you do support
DMA_SLAVEright?Yes, and it's single direction,
DMA_MEM_TO_DEV.
Okay how do you find the DMA data width and the burst to apply when you DMA to device? Are these not programmable?
I think you need to go back and check that part. Moreover a client may send you parameters and program the Device FIFO, you not honoring those will result in bad data received on Device, am sure you don't want that