ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
Subsystems (2)
PATCH 1/1 ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
From: Marcus Cooper <[email protected]>
Add the new DAI block for I2S2 which is used for HDMI audio.
--- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm/boot/dts/sunxi-h3-h5.dtsi +13 -0
@@ -568,6 +568,19 @@ status = "disabled"; }; + i2s2: i2s at 1c22800 { + #sound-dai-cells = <0>; + compatible = "allwinner,sun8i-h3-i2s"; + reg = <0x01c22800 0x400>; + interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_I2S2>, <&ccu CLK_I2S2>; + clock-names = "apb", "mod"; + dmas = <&dma 27>; + resets = <&ccu RST_BUS_I2S2>; + dma-names = "tx"; + status = "disabled"; + }; + codec: codec at 1c22c00 { #sound-dai-cells = <0>; compatible = "allwinner,sun8i-h3-codec";
Signature · 1 line
2.16.1
Maxime Ripard
AppliedPATCH 1/1 ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
Quoted 5 lines · codekipper at gmail.com
From: Marcus Cooper <[email protected]>
Add the new DAI block for I2S2 which is used for HDMI audio.
Signed-off-by Marcus Cooper <[email protected]>
queued for 4.17, thanks!
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180129/77cb52ff/attachment.sig>
PATCH 1/1 ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
Hi Maxime,
(previously I respond only to linux-sunxi mailing list)
Quoted 9 lines · codekipper at gmail.com
Quoted 5 lines
From: Marcus Cooper <[email protected]>
Add the new DAI block for I2S2 which is used for HDMI audio.
Signed-off-by Marcus Cooper <[email protected]>queued for 4.17, thanks!
Maxime
Please note that HDMI I2S has usable 4 I2S lanes, since HDMI supports 8 channel audio. As Marcus said, other blocks probably support them too, they are just not wired out on pins.
Should we change compatible for HDMI?
Best regards,
Jernej
PATCH 1/1 ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
Quoted 9 lines · Jernej ?krabec
Hi Maxime,
(previously I respond only to linux-sunxi mailing list)
Quoted 5 lines · codekipper at gmail.com
Quoted 4 lines
From: Marcus Cooper <[email protected]>
Add the new DAI block for I2S2 which is used for HDMI audio.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Marcus Cooper <[email protected]>queued for 4.17, thanks!
MaximePlease note that HDMI I2S has usable 4 I2S lanes, since HDMI supports 8 channel audio. As Marcus said, other blocks probably support them too, they are just not wired out on pins.
I've dropped those patches for now.
Quoted 1 line
Should we change compatible for HDMI?
I guess, another way of doing things if they are strictly identical but for the number of lanes they support would be to add a DT property for that number of lanes.
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180131/36d6c694/attachment-0001.sig>
PATCH 1/1 ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
Quoted 19 lines · maxime ripard
Quoted 9 lines · Jernej ?krabec
Hi Maxime,
(previously I respond only to linux-sunxi mailing list)
Quoted 5 lines · codekipper at gmail.com
Quoted 4 lines
From: Marcus Cooper <[email protected]>
Add the new DAI block for I2S2 which is used for HDMI audio.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Marcus Cooper <[email protected]>queued for 4.17, thanks!
MaximePlease note that HDMI I2S has usable 4 I2S lanes, since HDMI supports 8 channel audio. As Marcus said, other blocks probably support them too, they are just not wired out on pins.
Quoted 8 lines
I've dropped those patches for now.
Quoted 1 line
Should we change compatible for HDMI?
I guess, another way of doing things if they are strictly identical but for the number of lanes they support would be to add a DT property for that number of lanes.
That's fine...I'll look into adding a dt property and how we would map channels to lanes.
Do you know of any examples?,
BR,
CK
Quoted 6 lines
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
PATCH 1/1 ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
Quoted 25 lines · Code Kipper
Quoted 23 lines · maxime ripard
Quoted 9 lines · Jernej ?krabec
Hi Maxime,
(previously I respond only to linux-sunxi mailing list)
Quoted 5 lines · codekipper at gmail.com
Quoted 4 lines
From: Marcus Cooper <[email protected]>
Add the new DAI block for I2S2 which is used for HDMI audio.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Marcus Cooper <[email protected]>queued for 4.17, thanks!
MaximePlease note that HDMI I2S has usable 4 I2S lanes, since HDMI supports 8 channel audio. As Marcus said, other blocks probably support them too, they are just not wired out on pins.
I've dropped those patches for now.
Quoted 1 line
Should we change compatible for HDMI?
Quoted 7 lines
Quoted 4 lines
I guess, another way of doing things if they are strictly identical but for the number of lanes they support would be to add a DT property for that number of lanes.
That's fine...I'll look into adding a dt property and how we would map channels to lanes.
Do you know of any examples?,
Grepping for of_property_read_u32 should give you plenty of examples :)
maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180131/c2a55199/attachment-0001.sig>