Skip to contentSkip to conversation

ixgbe: prevent ptp_rx_hang from running when in FILTER_ALL mode

PATCH New Jacob Keller 2 participants 2 messages Jan 29, 2018 – Feb 2, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe: prevent ptp_rx_hang from running when in FILTER_ALL mode

On hardware which supports timestamping all packets, the timestamps are recorded in the packet buffer, and the driver no longer uses or reads the registers. This makes the logic for checking and clearing Rx timestmap hangs meaningless.

If we run the ixgbe_ptp_rx_hang() function in this case, then the driver will continuously spam the log output with "Clearing Rx timestamp hang". These messages are spurious, and confusing to end users.

The original code in commit a9763f3cb54c ("ixgbe: Update PTP to support X550EM_x devices", 2015-12-03) did have a flag PTP_RX_TIMESTAMP_IN_REGISTER which was intended to be used to avoid the Rx timestamp hang check, however it did not actually check the flag before calling the function.

Do so now in order to stop the checks and prevent the spurious log messages.

Fixes a9763f3cb54c ("ixgbe: Update PTP to support X550EM_x devices", 2015-12-03)

---
Apparently this fix was not squashed into Mark's upstreaming effort for the PTP updates for X550. Here it is now.

 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +2 -1
index 0da5aa2c8aba..b032091022a8 100644
@@ -7703,7 +7703,8 @@ static void ixgbe_service_task(struct work_struct *work)
 
 	if (test_bit(__IXGBE_PTP_RUNNING, &adapter->state)) {
 		ixgbe_ptp_overflow_check(adapter);
-		ixgbe_ptp_rx_hang(adapter);
+		if (adapter->flags & IXGBE_FLAG_RX_HWTSTAMP_IN_REGISTER)
+			ixgbe_ptp_rx_hang(adapter);
 		ixgbe_ptp_tx_hang(adapter);
 	}
 
Signature · 1 line
2.15.1.478.ga1e07cd25f8b
#1 lore raw

PATCH 1/1 ixgbe: prevent ptp_rx_hang from running when in FILTER_ALL mode

Quoted 27 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Jacob Keller
Sent: Monday, January 29, 2018 3:58 PM
To: Intel Wired LAN <[email protected]>
Subject: [Intel-wired-lan] [PATCH] ixgbe: prevent ptp_rx_hang from running when in FILTER_ALL mode

On hardware which supports timestamping all packets, the timestamps are recorded in the packet buffer, and the driver no longer uses or reads the registers. This makes the logic for checking and clearing Rx timestmap hangs meaningless.

If we run the ixgbe_ptp_rx_hang() function in this case, then the driver will continuously spam the log output with "Clearing Rx timestamp hang". These messages are spurious, and confusing to end users.

The original code in commit a9763f3cb54c ("ixgbe: Update PTP to support X550EM_x devices", 2015-12-03) did have a flag PTP_RX_TIMESTAMP_IN_REGISTER which was intended to be used to avoid the Rx timestamp hang check, however it did not actually check the flag before calling the function.

Do so now in order to stop the checks and prevent the spurious log messages.

Fixes a9763f3cb54c ("ixgbe: Update PTP to support X550EM_x devices",
Quoted 8 lines

2015-12-03)

---
Apparently this fix was not squashed into Mark's upstreaming effort for the PTP updates for X550. Here it is now.

 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)