Kconfig: usb: Sort USB_FUNCTION_* entries
PATCH 1/4 Kconfig: usb: Sort USB_FUNCTION_* entries
Lets provide alphabetical order for USB_FUNCTION_* entries of USB_GADGET_DOWNLOAD
---
drivers/usb/gadget/Kconfig | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/usb/gadget/Kconfig +7 -7
@@ -127,13 +127,6 @@ config USB_GADGET_DOWNLOAD if USB_GADGET_DOWNLOAD -config USB_FUNCTION_SDP - bool "Enable USB SDP (Serial Download Protocol)" - help - Enable Serial Download Protocol (SDP) device support in U-Boot. This - allows to download images into memory and execute (jump to) them - using the same protocol as implemented by the i.MX family's boot ROM. - config USB_FUNCTION_ROCKUSB bool "Enable USB rockusb gadget" help
@@ -142,6 +135,13 @@ config USB_FUNCTION_ROCKUSB the rockusb gadget.for more detail about Rockusb protocol, please see doc/README.rockusb +config USB_FUNCTION_SDP + bool "Enable USB SDP (Serial Download Protocol)" + help + Enable Serial Download Protocol (SDP) device support in U-Boot. This + allows to download images into memory and execute (jump to) them + using the same protocol as implemented by the i.MX family's boot ROM. + endif # USB_GADGET_DOWNLOAD config USB_ETHER
Signature · 1 line
2.11.0
PATCH 1/4 Kconfig: usb: Sort USB_FUNCTION_* entries
2018-01-30 3:21 GMT+09:00 Lukasz Majewski <[email protected]>:
Quoted 8 lines
Lets provide alphabetical order for USB_FUNCTION_* entries of
USB_GADGET_DOWNLOADSigned-off-by Lukasz Majewski <[email protected]>---
drivers/usb/gadget/Kconfig | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
Nit:
I want to see the subject prefix "Kconfig:"
only for changes in scripts/kconfig/.
This case, "usb:" will be preferred.
For 2/4 and 3/4, too.
Quoted 39 lines
drivers/usb/gadget/Kconfig +7
-8@@ -127,13 +127,6 @@ config USB_GADGET_DOWNLOAD if USB_GADGET_DOWNLOAD -config USB_FUNCTION_SDP - bool "Enable USB SDP (Serial Download Protocol)" - help - Enable Serial Download Protocol (SDP) device support in U-Boot. This - allows to download images into memory and execute (jump to) them - using the same protocol as implemented by the i.MX family's boot ROM. - config USB_FUNCTION_ROCKUSB bool "Enable USB rockusb gadget" help@@ -142,6 +135,13 @@ config USB_FUNCTION_ROCKUSB the rockusb gadget.for more detail about Rockusb protocol, please see doc/README.rockusb +config USB_FUNCTION_SDP + bool "Enable USB SDP (Serial Download Protocol)" + help + Enable Serial Download Protocol (SDP) device support in U-Boot. This + allows to download images into memory and execute (jump to) them + using the same protocol as implemented by the i.MX family's boot ROM. + endif # USB_GADGET_DOWNLOAD config USB_ETHER --2.11.0
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Signature · 2 lines
Best Regards Masahiro Yamada
PATCH 1/4 Kconfig: usb: Sort USB_FUNCTION_* entries
Hi Masahiro,
Quoted 11 lines
2018-01-30 3:21 GMT+09:00 Lukasz Majewski <[email protected]>:
Quoted 8 lines
Lets provide alphabetical order for USB_FUNCTION_* entries of
USB_GADGET_DOWNLOADSigned-off-by Lukasz Majewski <[email protected]>---
drivers/usb/gadget/Kconfig | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
Quoted 8 lines
Nit:
I want to see the subject prefix "
Kconfig:"
only for changes inscripts/kconfig/.This case, "usb:" will be preferred.
For 2/4 and 3/4, too.
I will change the topic when preparing v2.
Thanks.
Quoted 38 lines
Quoted 38 lines
drivers/usb/gadget/Kconfig +0
-4@@ -127,13 +127,6 @@ config USB_GADGET_DOWNLOAD if USB_GADGET_DOWNLOAD -config USB_FUNCTION_SDP - bool "Enable USB SDP (Serial Download Protocol)" - help - Enable Serial Download Protocol (SDP) device support inU-Boot. This
- allows to download images into memory and execute (jump
to) them
- using the same protocol as implemented by the i.MX
family's boot ROM. -
configUSB_FUNCTION_ROCKUSB
bool "Enable USB rockusb gadget"
helpdrivers/usb/gadget/Kconfig +0
-0@@ -142,6 +135,13 @@ config USB_FUNCTION_ROCKUSB the rockusb gadget.for more detail about Rockusbprotocol, please see doc/README.rockusb
drivers/usb/gadget/Kconfig +4
-0+config USB_FUNCTION_SDP + bool "Enable USB SDP (Serial Download Protocol)" + help + Enable Serial Download Protocol (SDP) device support inU-Boot. This
+ allows to download images into memory and execute (jump
to) them
+ using the same protocol as implemented by the i.MX
family's boot ROM. +
endif #USB_GADGET_DOWNLOAD
Quoted 11 lines
Quoted 8 lines
config
USB_ETHER
--
2.11.0_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180130/5c2f4372/attachment.sig>
PATCH 1/4 Kconfig: usb: Sort USB_FUNCTION_* entries
In reply to Lukasz MajewskiQuoted 4 lines · Lukasz Majewski
Lets provide alphabetical order for USB_FUNCTION_* entries of
USB_GADGET_DOWNLOADSigned-off-by Lukasz Majewski <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180202/9263d1f2/attachment.sig>