Skip to contentSkip to conversation

gcc-crosssdk: use oe.utils.str_filter_out

PATCH In review Ross Burton 2 participants 3 messages Jan 30, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gcc-crosssdk: use oe.utils.str_filter_out

oe_filter_out has been removed from oe-core so use the replacement function.

---
 recipes-devtools/gcc/gcc-crosssdk_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-devtools/gcc/gcc-crosssdk_%.bbappend +1 -1
index b3b843a..d52a16b 100644
@@ -1,4 +1,4 @@
-EXTRA_OECONF_mingw32 := "${@oe_filter_out('--with-linker-hash-style=${LINKER_HASH_STYLE}', '${EXTRA_OECONF}', d)}"
+EXTRA_OECONF_mingw32 := "${@oe.utils.str_filter_out('--with-linker-hash-style=${LINKER_HASH_STYLE}', '${EXTRA_OECONF}', d)}"
 PACKAGECONFIG_CONFARGS ?= ""
 EXTRA_OECONF_remove_mingw32 = "--enable-initfini-array"
 EXTRA_OECONF_append_mingw32 = " --disable-initfini-array"
Signature · 1 line
2.11.0
#1 lore raw
Quoted 15 lines · Ross Burton

oe_filter_out has been removed from oe-core so use the replacement function.

---
 recipes-devtools/gcc/gcc-crosssdk_%.bbappend | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
recipes- renamed from recipes-devtools/gcc/gcc-crosssdk_%.bbappend +0 -0

devtools/gcc/gcc-crosssdk_%.bbappend
index b3b843a..d52a16b 100644

recipes-devtools/gcc/gcc-crosssdk_%.bbappend +0 -1
@@ -1,4 +1,4 @@
-EXTRA_OECONF_mingw32 := "${@oe_filter_out('--with-linker-hash-
Quoted 3 lines

style=${LINKER_HASH_STYLE}', '${EXTRA_OECONF}', d)}" +EXTRA_OECONF_mingw32 := "${@oe.utils.str_filter_out('--with-linker- hash-style=${LINKER_HASH_STYLE}', '${EXTRA_OECONF}', d)}"

Why aren't we using
EXTRA_OECONF_remove_mingw32 = "--with-linker-hash-style=${LINKER_HASH_STYLE}" out of interest?

I thought (hoped) the filter-out stuff was dead now?

Cheers,

Richard

#2 lore raw
Quoted 7 lines · Richard Purdie

Why aren't we using
EXTRA_OECONF_remove_mingw32 = "--with-linker-hash-style=${ LINKER_HASH_STYLE}"
out of interest?

I thought (hoped) the filter-out stuff was dead now?

I'll admit I just fixed the error without looking exactly at what was being done. :)

Ross