Skip to contentSkip to conversation

x86: kconfig: Remove meaningless 'select n'

PATCH New Ulf Magnusson 2 participants 3 messages Jan 30, 2018

lore
Share & tools
lore

Ulf Magnusson

author
#0 lore raw

PATCH 1/1 x86: kconfig: Remove meaningless 'select n'

'select n' selects a constant symbol, which is meaningless and has no effect. Maybe this was meant to be a 'default n', though bool and tristate symbols already implicitly default to n.

Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
which does more strict checking here:

kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse ' select n': expected nonconstant symbol

Signed-off-by Ulf Magnusson <[email protected]>
---
 board/google/Kconfig | 1 -
 1 file changed, 1 deletion(-)
board/google/Kconfig +0 -1
index e56c026ef6..766db1b449 100644
@@ -31,7 +31,6 @@ config TARGET_CHROMEBOOK_LINK64
 
 config TARGET_CHROMEBOX_PANTHER
 	bool "Chromebox panther (not available)"
-	select n
 	help
 	  Note: At present this must be used with coreboot. See README.x86
 	  for instructions.
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 x86: kconfig: Remove meaningless 'select n'

Quoted 7 lines · Ulf Magnusson

'select n' selects a constant symbol, which is meaningless and has no effect. Maybe this was meant to be a 'default n', though bool and tristate symbols already implicitly default to n.

Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
which does more strict checking here:

Quoted 7 lines

kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse ' select n': expected nonconstant symbol

Signed-off-by Ulf Magnusson <[email protected]>
---
 board/google/Kconfig | 1 -
 1 file changed, 1 deletion(-)
Reviewed-by Bin Meng <[email protected]>
#2 lore raw

PATCH 1/1 x86: kconfig: Remove meaningless 'select n'

Quoted 10 lines · Bin Meng
Quoted 9 lines · Ulf Magnusson

'select n' selects a constant symbol, which is meaningless and has no effect. Maybe this was meant to be a 'default n', though bool and tristate symbols already implicitly default to n.

Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
which does more strict checking here:

kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse ' select n': expected nonconstant symbol

Quoted 7 lines
Quoted 5 lines
Signed-off-by Ulf Magnusson <[email protected]>
---
 board/google/Kconfig | 1 -
 1 file changed, 1 deletion(-)
Reviewed-by Bin Meng <[email protected]>

applied to u-boot-x86, thanks!