Skip to contentSkip to conversation

Remove empty help texts from Kconfig files

PATCH In review Ulf Magnusson 2 participants 13 messages Jan 30, 2018 – Jan 31, 2018

Subsystems (13)
Networking Network drivers Arm (32-bit) Arm sub-architectures +9 more subsystems
lore
Share & tools
lore

Ulf Magnusson

author
#0 lore raw

v2 cover Remove empty help texts from Kconfig files

Empty help texts are probably either a typo, a Kconfig misunderstanding, or some kind of half-committing to adding a help text (in which case a TODO comment would be clearer, if the help text really can't be added right away). Best to flag them, IMO.

Changes since v1:

Forgot to send the cover letter to linux-kbuild.

Ulf Magnusson (10):
net/sched: kconfig: Remove empty help texts
video: fbdev: kconfig: Remove empty help text
mmc: kconfig: Remove empty help text
Staging: rtl8192u: kconfig: Remove empty help text
Staging: rtl8192e: kconfig: Remove empty help text lib/Kconfig.debug: Remove empty help text
MIPS: BCM63XX: kconfig: Remove empty help text
MIPS: kconfig: Remove empty help text
arm: vt8500: kconfig: Remove empty help text
nios2: kconfig: Remove empty help text

 arch/arm/mach-vt8500/Kconfig              | 1 -
 arch/mips/Kconfig                         | 1 -
 arch/mips/bcm63xx/boards/Kconfig          | 1 -
 arch/nios2/Kconfig                        | 1 -
 drivers/mmc/host/Kconfig                  | 1 -
 drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
 drivers/staging/rtl8192u/Kconfig          | 1 -
 drivers/video/fbdev/Kconfig               | 1 -
 lib/Kconfig.debug                         | 1 -
 net/sched/Kconfig                         | 3 ---
 10 files changed, 12 deletions(-)
Signature · 1 line
2.14.1
author
#1 lore raw

PATCH v2 1/10 net/sched: kconfig: Remove empty help texts

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by Ulf Magnusson <[email protected]>
---
 net/sched/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
net/sched/Kconfig +0 -3
index c03d86a7775e..f24a6ae6819a 100644
@@ -857,17 +857,14 @@ config NET_ACT_TUNNEL_KEY
 config NET_IFE_SKBMARK
         tristate "Support to encoding decoding skb mark on IFE action"
         depends on NET_ACT_IFE
-        ---help---
 
 config NET_IFE_SKBPRIO
         tristate "Support to encoding decoding skb prio on IFE action"
         depends on NET_ACT_IFE
-        ---help---
 
 config NET_IFE_SKBTCINDEX
         tristate "Support to encoding decoding skb tcindex on IFE action"
         depends on NET_ACT_IFE
-        ---help---
 
 config NET_CLS_IND
 	bool "Incoming device classification"
Signature · 1 line
2.14.1
author
#2 lore raw

PATCH v2 2/10 video: fbdev: kconfig: Remove empty help text

In reply to Ulf Magnusson

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by Ulf Magnusson <[email protected]>
---
 drivers/video/fbdev/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/video/fbdev/Kconfig +0 -1
index 6962b4583fd7..11e699f1062b 100644
@@ -1156,7 +1156,6 @@ config FB_I810_I2C
 	bool "Enable DDC Support"
 	depends on FB_I810 && FB_I810_GTF
 	select FB_DDC
-	help
 
 config FB_LE80578
 	tristate "Intel LE80578 (Vermilion) support"
Signature · 1 line
2.14.1
author
#3 lore raw

PATCH v2 3/10 mmc: kconfig: Remove empty help text

In reply to Ulf Magnusson

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by Ulf Magnusson <[email protected]>
---
 drivers/mmc/host/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/mmc/host/Kconfig +0 -1
index 67bd3344dd03..24dee8eb5270 100644
@@ -874,7 +874,6 @@ config MMC_CQHCI
 config MMC_TOSHIBA_PCI
 	tristate "Toshiba Type A SD/MMC Card Interface Driver"
 	depends on PCI
-	help
 
 config MMC_BCM2835
 	tristate "Broadcom BCM2835 SDHOST MMC Controller support"
Signature · 1 line
2.14.1
author
#4 lore raw

PATCH v2 4/10 Staging: rtl8192u: kconfig: Remove empty help text

In reply to Ulf Magnusson

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by Ulf Magnusson <[email protected]>
---
 drivers/staging/rtl8192u/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8192u/Kconfig +0 -1
index 3ee9d0d00fb6..97df6507a485 100644
@@ -5,4 +5,3 @@ config RTL8192U
 	select WIRELESS_EXT
 	select WEXT_PRIV
 	select CRYPTO
-	---help---
Signature · 6 lines
2.14.1

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
author
#5 lore raw

PATCH v2 5/10 Staging: rtl8192e: kconfig: Remove empty help text

In reply to Ulf Magnusson

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by Ulf Magnusson <[email protected]>
---
 drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/Kconfig +0 -1
index 282e293da18f..7ac42a590e21 100644
@@ -6,4 +6,3 @@ config RTL8192E
 	select WEXT_PRIV
 	select CRYPTO
 	select FW_LOADER
-	---help---
Signature · 6 lines
2.14.1

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
author
#6 lore raw

PATCH v2 6/10 lib/Kconfig.debug: Remove empty help text

In reply to Ulf Magnusson

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by Ulf Magnusson <[email protected]>
---
 lib/Kconfig.debug | 1 -
 1 file changed, 1 deletion(-)
lib/Kconfig.debug +0 -1
index b66c264d4194..6088408ef26c 100644
@@ -351,7 +351,6 @@ config SECTION_MISMATCH_WARN_ONLY
 #
 config ARCH_WANT_FRAME_POINTERS
 	bool
-	help
 
 config FRAME_POINTER
 	bool "Compile the kernel with frame pointers"
Signature · 1 line
2.14.1
author
#7 lore raw

PATCH v2 7/10 MIPS: BCM63XX: kconfig: Remove empty help text

In reply to Ulf Magnusson

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by Ulf Magnusson <[email protected]>
---
 arch/mips/bcm63xx/boards/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/mips/bcm63xx/boards/Kconfig +0 -1
index 6ff0a7481081..f60d96610ace 100644
@@ -7,6 +7,5 @@ choice
 config BOARD_BCM963XX
        bool "Generic Broadcom 963xx boards"
 	select SSB
-       help
 
 endchoice
Signature · 1 line
2.14.1
author
#8 lore raw

PATCH v2 8/10 MIPS: kconfig: Remove empty help text

In reply to Ulf Magnusson

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by Ulf Magnusson <[email protected]>
---
 arch/mips/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/mips/Kconfig +0 -1
index ab98569994f0..57cd591e7b28 100644
@@ -2326,7 +2326,6 @@ config MIPS_VPE_LOADER_TOM
 config MIPS_VPE_APSP_API
 	bool "Enable support for AP/SP API (RTLX)"
 	depends on MIPS_VPE_LOADER
-	help
 
 config MIPS_VPE_APSP_API_CMP
 	bool
Signature · 1 line
2.14.1
author
#9 lore raw

PATCH v2 9/10 arm: vt8500: kconfig: Remove empty help text

In reply to Ulf Magnusson

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by Ulf Magnusson <[email protected]>
---
 arch/arm/mach-vt8500/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/arm/mach-vt8500/Kconfig +0 -1
index 1156a585dafc..8841199058ea 100644
@@ -13,7 +13,6 @@ config ARCH_WM8505
  	depends on ARCH_MULTI_V5
  	select ARCH_VT8500
  	select CPU_ARM926T
- 	help
 
 config ARCH_WM8750
 	bool "WonderMedia WM8750"
Signature · 1 line
2.14.1
author
#10 lore raw

PATCH v2 10/10 nios2: kconfig: Remove empty help text

In reply to Ulf Magnusson

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by Ulf Magnusson <[email protected]>
---
 arch/nios2/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/nios2/Kconfig +0 -1
index 60fae03dac79..3d4ec88f1db1 100644
@@ -152,7 +152,6 @@ menu "Advanced setup"
 
 config ADVANCED_OPTIONS
 	bool "Prompt for advanced kernel configuration options"
-	help
 
 comment "Default settings for advanced configuration options are used"
 	depends on !ADVANCED_OPTIONS
Signature · 1 line
2.14.1
Acked-by on the v2 series
#11 lore raw
In reply to Ulf Magnusson
Quoted 8 lines · Ulf Magnusson

Empty help texts are probably either a typo, a Kconfig misunderstanding, or some kind of half-committing to adding a help text (in which case a TODO comment would be clearer, if the help text really can't be added right away). Best to flag them, IMO.

Changes since v1:

Forgot to send the cover letter to linux-kbuild.

Acked-by Randy Dunlap <[email protected]>

Thanks.

Quoted 24 lines

Ulf Magnusson (10):
net/sched: kconfig: Remove empty help texts
video: fbdev: kconfig: Remove empty help text
mmc: kconfig: Remove empty help text
Staging: rtl8192u: kconfig: Remove empty help text
Staging: rtl8192e: kconfig: Remove empty help text lib/Kconfig.debug: Remove empty help text
MIPS: BCM63XX: kconfig: Remove empty help text
MIPS: kconfig: Remove empty help text
arm: vt8500: kconfig: Remove empty help text
nios2: kconfig: Remove empty help text

 arch/arm/mach-vt8500/Kconfig              | 1 -
 arch/mips/Kconfig                         | 1 -
 arch/mips/bcm63xx/boards/Kconfig          | 1 -
 arch/nios2/Kconfig                        | 1 -
 drivers/mmc/host/Kconfig                  | 1 -
 drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
 drivers/staging/rtl8192u/Kconfig          | 1 -
 drivers/video/fbdev/Kconfig               | 1 -
 lib/Kconfig.debug                         | 1 -
 net/sched/Kconfig                         | 3 ---
 10 files changed, 12 deletions(-)
Signature · 1 line
~Randy
author
#12 lore raw
Quoted 40 lines · Randy Dunlap
Quoted 8 lines · Ulf Magnusson

Empty help texts are probably either a typo, a Kconfig misunderstanding, or some kind of half-committing to adding a help text (in which case a TODO comment would be clearer, if the help text really can't be added right away). Best to flag them, IMO.

Changes since v1:

Forgot to send the cover letter to linux-kbuild.

Acked-by Randy Dunlap <[email protected]>

Thanks.

Quoted 12 lines

Ulf Magnusson (10):
net/sched: kconfig: Remove empty help texts
video: fbdev: kconfig: Remove empty help text
mmc: kconfig: Remove empty help text
Staging: rtl8192u: kconfig: Remove empty help text
Staging: rtl8192e: kconfig: Remove empty help text lib/Kconfig.debug: Remove empty help text
MIPS: BCM63XX: kconfig: Remove empty help text
MIPS: kconfig: Remove empty help text
arm: vt8500: kconfig: Remove empty help text
nios2: kconfig: Remove empty help text

Quoted 12 lines
 arch/arm/mach-vt8500/Kconfig              | 1 -
 arch/mips/Kconfig                         | 1 -
 arch/mips/bcm63xx/boards/Kconfig          | 1 -
 arch/nios2/Kconfig                        | 1 -
 drivers/mmc/host/Kconfig                  | 1 -
 drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
 drivers/staging/rtl8192u/Kconfig          | 1 -
 drivers/video/fbdev/Kconfig               | 1 -
 lib/Kconfig.debug                         | 1 -
 net/sched/Kconfig                         | 3 ---
 10 files changed, 12 deletions(-)
Quoted 2 lines

--
~Randy

This patchset has been superseded by
https://lkml.org/lkml/2018/1/31/137, which rolls the removal of the blank help texts and adding the new warning into a single patchset.

Cheers,
Ulf