Skip to contentSkip to conversation

ltp-testsuite: Add upstream patch to fix build numa detection

PATCH New Petr Vorel 2 participants 2 messages Jan 30, 2018

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH v2 1/1 ltp-testsuite: Add upstream patch to fix build numa detection

This removes fix added in commit 3c937807a3 ("ltp-testsuite: disable numa tests")

---
Changes v1-v2:
* Add LTP_TESTSUITE_AUTORECONF = YES to really regenerate configure.

---
 ...x-numa-v2-detection-for-cross-compilation.patch | 37 ++++++++++++++++++++++
 package/ltp-testsuite/ltp-testsuite.mk             |  6 ++--
 2 files changed, 41 insertions(+), 2 deletions(-)
 create mode 100644 package/ltp-testsuite/0002-numa-Fix-numa-v2-detection-for-cross-compilation.patch
package/ltp-testsuite/0002-numa-Fix-numa-v2-detection-for-cross-compilation.patch new file +37 -0
new file mode 100644
index 0000000000..6ad1db046e
@@ -0,0 +1,37 @@
+From 01c134f30be755a43af12a4ae2c31177d04be790 Mon Sep 17 00:00:00 2001
+From: Petr Vorel <[email protected]>
+Date: Mon, 29 Jan 2018 10:31:40 +0100
+Subject: [PATCH] numa: Fix numa v2 detection for cross compilation
+
+Changed to AC_COMPILE_IFELSE as AC_RUN_IFELSE cannot be run while
+cross compiling.
+
+Bug found by Buildroot project.
+
+Signed-off-by: Petr Vorel <[email protected]>
+Reported-by: Baruch Siach <[email protected]>
+---
+ m4/ltp-numa.m4 | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/m4/ltp-numa.m4 b/m4/ltp-numa.m4
+index fc3383e97..633f54c18 100644
+--- a/m4/ltp-numa.m4
++++ b/m4/ltp-numa.m4
+@@ -28,11 +28,11 @@ AC_DEFUN([LTP_CHECK_SYSCALL_NUMA], [
+ 	AC_CHECK_HEADERS([numa.h numaif.h], [], [have_numa_headers=no])
+ 
+ 	if test "x$have_numa_headers" != "xno"; then
+-		AC_RUN_IFELSE([AC_LANG_PROGRAM([
++		AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
+ #include <numa.h>
+ 		], [
+ #if LIBNUMA_API_VERSION < 2
+-exit(1);
++# error Required numa headers >= 2
+ #endif
+ 		])], [have_numa_headers_v2=yes])
+ 	fi
+-- 
+2.16.0
+
package/ltp-testsuite/ltp-testsuite.mk +4 -2
index 28dc24749e..5e0b35d12a 100644
@@ -56,8 +56,10 @@ LTP_TESTSUITE_CONF_ENV += \
 	CFLAGS="$(LTP_TESTSUITE_CFLAGS)" \
 	CPPFLAGS="$(LTP_TESTSUITE_CPPFLAGS)" \
 	LIBS="$(LTP_TESTSUITE_LIBS)" \
-	SYSROOT="$(STAGING_DIR)" \
-	have_numa_headers=no
+	SYSROOT="$(STAGING_DIR)"
+
+# Required by patch 0002-numa-Fix-numa-v2-detection-for-cross-compilation.patch
+LTP_TESTSUITE_AUTORECONF = YES
 
 # Requires uClibc fts and bessel support, normally not enabled
 ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
Signature · 1 line
2.16.1
#1 lore raw

PATCH v2 1/1 ltp-testsuite: Add upstream patch to fix build numa detection

Hello,

Quoted 11 lines · Petr Vorel

This removes fix added in commit 3c937807a3 ("ltp-testsuite: disable numa tests")

---
Changes v1-v2:
* Add LTP_TESTSUITE_AUTORECONF = YES to really regenerate configure.

---
 ...x-numa-v2-detection-for-cross-compilation.patch | 37 ++++++++++++++++++++++
 package/ltp-testsuite/ltp-testsuite.mk             |  6 ++--
 2 files changed, 41 insertions(+), 2 deletions(-)
 create mode 100644 package/ltp-testsuite/0002-numa-Fix-numa-v2-detection-for-cross-compilation.patch

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com