Skip to contentSkip to conversation

aoetools: fix aoe-stat script that was using /bin/bash in its shebang

PATCH New Sergio Prado 2 participants 2 messages Jan 26, 2018 – Jan 30, 2018

lore
Share & tools
lore

Sergio Prado

author
#0 lore raw

PATCH 1/1 aoetools: fix aoe-stat script that was using /bin/bash in its shebang

This will make the script more portable, making it possible to run on systems that do not have bash.

The script was tested with ash from BusyBox and checked for portability issues and bashisms with shellcheck and checkbashisms tools.

The patch was already applied upstream [1] and should be removed in the next version bump.

[1] https://github.com/OpenAoE/aoetools/commit/4ef42740538cefd3c1554aa4df5bcb1388ac927b

Signed-off-by Sergio Prado <[email protected]>
---
 ...l-script-interpreter-from-bin-bash-to-bin.patch | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/aoetools/0001-Change-shell-script-interpreter-from-bin-bash-to-bin.patch
package/aoetools/0001-Change-shell-script-interpreter-from-bin-bash-to-bin.patch new file +26 -0
new file mode 100644
index 000000000000..00b24c8943ec
@@ -0,0 +1,26 @@
+From 4ef42740538cefd3c1554aa4df5bcb1388ac927b Mon Sep 17 00:00:00 2001
+From: Sergio Prado <[email protected]>
+Date: Tue, 16 Jan 2018 22:28:32 -0200
+Subject: [PATCH] Change shell script interpreter from /bin/bash to /bin/sh
+
+This will make the script more portable, making it possible to run on
+systems that do not have bash.
+
+Signed-off-by: Sergio Prado <[email protected]>
+---
+ aoe-stat.in | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/aoe-stat.in b/aoe-stat.in
+index 50e6ac674169..0c1d6f5ebe1e 100755
+--- a/aoe-stat.in
++++ b/aoe-stat.in
+@@ -1,4 +1,4 @@
+-#! /bin/bash
++#! /bin/sh
+ # aoe-stat - collate and present information about AoE storage
+ # Copyright 2012, CORAID, Inc., and licensed under GPL v.2.
+ 
+-- 
+1.9.1
+
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH 1/1 aoetools: fix aoe-stat script that was using /bin/bash in its shebang

Hello,

Quoted 9 lines · Sergio Prado

This will make the script more portable, making it possible to run on systems that do not have bash.

The script was tested with ash from BusyBox and checked for portability issues and bashisms with shellcheck and checkbashisms tools.

The patch was already applied upstream [1] and should be removed in the next version bump.

Quoted 7 lines

[1] https://github.com/OpenAoE/aoetools/commit/4ef42740538cefd3c1554aa4df5bcb1388ac927b

Signed-off-by Sergio Prado <[email protected]>
---
 ...l-script-interpreter-from-bin-bash-to-bin.patch | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/aoetools/0001-Change-shell-script-interpreter-from-bin-bash-to-bin.patch

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com