Skip to contentSkip to conversation

rc_pingpong: Fix getopt processing of -t

PATCH Applied Jason Gunthorpe 3 participants 3 messages Jan 31, 2018 1 message not in the archive InfiniBand

lore
Share & tools
lore

Jason Gunthorpe

author
#0 lore raw

PATCH 1/1 rc_pingpong: Fix getopt processing of -t

The -t option never had an argument, a : was erroneously added when the -c option was added

Fixes 099c5aa50bc8 ("libibverb/examples: Add command line option to enable buffer validation")
Signed-off-by Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 libibverbs/examples/rc_pingpong.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
libibverbs/examples/rc_pingpong.c +1 -1
index b5153bceb8254b..cf5c045741b7be 100644
@@ -730,7 +730,7 @@ int main(int argc, char *argv[])
 			{}
 		};
 
-		c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:ot:c",
+		c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:otc",
 				long_options, NULL);
 
 		if (c == -1)
Signature · 6 lines
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20180131000415.GA29879-uk2M96/[email protected]

Applied
#2 lore raw
Quoted 9 lines · Jason Gunthorpe

The -t option never had an argument, a : was erroneously added when the -c option was added

Fixes 099c5aa50bc8 ("libibverb/examples: Add command line option to enable buffer validation")
Signed-off-by Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 libibverbs/examples/rc_pingpong.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied.

Reviewed-by
#3 lore raw
In reply to a message not in the archive
Quoted 2 lines · Jason Gunthorpe

The -t option never had an argument, a : was erroneously added when the -c option was added

Thanks,
Now i've learned how to add arguments so can implement Ram's idea :)

Sorry for that.

Reviewed-by Yuval Shaia <[email protected]>
Quoted 23 lines
Fixes 099c5aa50bc8 ("libibverb/examples: Add command line option to enable buffer validation")
Signed-off-by Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 libibverbs/examples/rc_pingpong.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
libibverbs/examples/rc_pingpong.c +1 -1
index b5153bceb8254b..cf5c045741b7be 100644
@@ -730,7 +730,7 @@ int main(int argc, char *argv[])
 			{}
 		};
 
-		c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:ot:c",
+		c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:otc",
 				long_options, NULL);
 
 		if (c == -1)
Signature · 1 line
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html