Skip to contentSkip to conversation

Add missing bt nodes

PATCH In review Joel Stanley 1 participant 6 messages Jan 31, 2018 – Feb 5, 2018

Subsystems (2)
lore
Share & tools
lore

Joel Stanley

author maintainer
#0 lore raw

v2 cover Add missing bt nodes

Joel Stanley (2):
ARM: dts: aspeed: Add IPMI BT node
ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines

 arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts    | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts     | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts       | 4 ++++
 arch/arm/boot/dts/aspeed-g4.dtsi                 | 7 +++++++
 arch/arm/boot/dts/aspeed-g5.dtsi                 | 7 +++++++
 6 files changed, 30 insertions(+)
Signature · 1 line
2.15.1
author maintainer
#1 lore raw

PATCH v2 1/2 ARM: dts: aspeed: Add IPMI BT node

The IPMI BT device part of the LPC interface and is used for communication with the host processor.

---
v2:
Fix bt reg node. It should be an offset from the lpc_host address, not the actual address of the iBT

 arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++
 arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++
 2 files changed, 14 insertions(+)
arch/arm/boot/dts/aspeed-g4.dtsi +7 -0
index e6f4047142a8..7e0da0b8cd12 100644
@@ -246,6 +246,13 @@
 						reg = <0x20 0x24 0x48 0x8>;
 					};
 
+					ibt: ibt@140 {
+						compatible = "aspeed,ast2400-ibt-bmc";
+						reg = <0xc0 0x18>;
+						interrupts = <8>;
+						status = "disabled";
+					};
+
 					mbox: mbox@180 {
 						compatible = "aspeed,ast2400-mbox";
 						reg = <0x180 0x5c>;
arch/arm/boot/dts/aspeed-g5.dtsi +7 -0
index b7b42c7c89e1..f1b2fa204873 100644
@@ -299,6 +299,13 @@
 						reg = <0x20 0x24 0x48 0x8>;
 					};
 
+					ibt: ibt@140 {
+						compatible = "aspeed,ast2500-ibt-bmc";
+						reg = <0xc0 0x18>;
+						interrupts = <8>;
+						status = "disabled";
+					};
+
 					mbox: mbox@180 {
 						compatible = "aspeed,ast2500-mbox";
 						reg = <0x180 0x5c>;
Signature · 1 line
2.15.1
author maintainer
#2 lore raw

Re: [PATCH v2 1/2] ARM: dts: aspeed: Add IPMI BT node

Quoted 36 lines · Joel Stanley

The IPMI BT device part of the LPC interface and is used for communication with the host processor.

---
v2:
Fix bt reg node. It should be an offset from the lpc_host address, not the actual address of the iBT

 arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++
 arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++
 2 files changed, 14 insertions(+)
arch/arm/boot/dts/aspeed-g4.dtsi +7 -0
index e6f4047142a8..7e0da0b8cd12 100644
@@ -246,6 +246,13 @@
                                                reg = <0x20 0x24 0x48 0x8>;
                                        };
 
+                                       ibt: ibt@140 {
+                                               compatible = "aspeed,ast2400-ibt-bmc";
+                                               reg = <0xc0 0x18>;
+                                               interrupts = <8>;
+                                               status = "disabled";
+                                       };
+
                                        mbox: mbox@180 {
                                                compatible = "aspeed,ast2400-mbox";
                                                reg = <0x180 0x5c>;
arch/arm/boot/dts/aspeed-g5.dtsi +0 -0
index b7b42c7c89e1..f1b2fa204873 100644

arch/arm/boot/dts/aspeed-g5.dtsi line 302

Quoted 4 lines
arch/arm/boot/dts/aspeed-g5.dtsi +1 -0
@@ -299,6 +299,13 @@
                                                reg = <0x20 0x24 0x48 0x8>;
                                        };
 
+                                       ibt: ibt@140 {

I forgot to update the node name.

Quoted 12 lines
arch/arm/boot/dts/aspeed-g5.dtsi +6 -1
+                                               compatible = "aspeed,ast2500-ibt-bmc";
+                                               reg = <0xc0 0x18>;
+                                               interrupts = <8>;
+                                               status = "disabled";
+                                       };
+
                                        mbox: mbox@180 {
                                                compatible = "aspeed,ast2500-mbox";
                                                reg = <0x180 0x5c>;
--

2.15.1

author maintainer Acked-by Andrew Jeffery
#3 lore raw

Re: [PATCH v2 1/2] ARM: dts: aspeed: Add IPMI BT node

Quoted 40 lines · Joel Stanley
Quoted 39 lines · Joel Stanley

The IPMI BT device part of the LPC interface and is used for communication with the host processor.

---
v2:
Fix bt reg node. It should be an offset from the lpc_host address, not the actual address of the iBT

 arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++
 arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++
 2 files changed, 14 insertions(+)
arch/arm/boot/dts/aspeed-g4.dtsi +7 -0
index e6f4047142a8..7e0da0b8cd12 100644
@@ -246,6 +246,13 @@
                                                reg = <0x20 0x24 0x48 0x8>;
                                        };
 
+                                       ibt: ibt@140 {
+                                               compatible = "aspeed,ast2400-ibt-bmc";
+                                               reg = <0xc0 0x18>;
+                                               interrupts = <8>;
+                                               status = "disabled";
+                                       };
+
                                        mbox: mbox@180 {
                                                compatible = "aspeed,ast2400-mbox";
                                                reg = <0x180 0x5c>;
arch/arm/boot/dts/aspeed-g5.dtsi +0 -0
index b7b42c7c89e1..f1b2fa204873 100644
@@ -299,6 +299,13 @@
                                                reg = <0x20 0x24 0x48 0x8>;
                                        };
 
Quoted 3 lines

arch/arm/boot/dts/aspeed-g5.dtsi line 302

Quoted 1 line
arch/arm/boot/dts/aspeed-g5.dtsi +1 -0
+                                       ibt: ibt@140 {

I forgot to update the node name.

Andrew did an over the shoulder review of this patch. He said that with the node name fixed:

author maintainer
#4 lore raw

PATCH v2 2/2 ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines

In reply to Joel Stanley

These BMC systems require this device to communicate with the host.

---
 arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts    | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts     | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts       | 4 ++++
 4 files changed, 16 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +4 -0
index c03c4274f910..e64df1c3b01a 100644
@@ -114,3 +114,7 @@
 &vuart {
 	status = "okay";
 };
+
+&ibt {
+	status = "okay";
+};
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +4 -0
index 09dab179e154..4039381f9361 100644
@@ -270,3 +270,7 @@
 		aspeed,fan-tach-ch = /bits/ 8 <0x0e>;
 	};
 };
+
+&ibt {
+	status = "okay";
+};
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +4 -0
index b24ea9967fc8..5f8dbffa6b22 100644
@@ -632,3 +632,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_wdtrst1_default>;
 };
+
+&ibt {
+	status = "okay";
+};
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +4 -0
index e7669d126df1..7f5a29566801 100644
@@ -435,3 +435,7 @@
 		aspeed,fan-tach-ch = /bits/ 8 <0x03>;
 	};
 };
+
+&ibt {
+	status = "okay";
+};
Signature · 1 line
2.15.1
author maintainer Acked-by Andrew Jeffery on v2 2/2
#5 lore raw

Re: [PATCH v2 2/2] ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines

Quoted 3 lines · Joel Stanley

These BMC systems require this device to communicate with the host.

Andrew did an over the shoulder review of this patch:

Quoted 58 lines
---
 arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts    | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts     | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts       | 4 ++++
 4 files changed, 16 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +4 -0
index c03c4274f910..e64df1c3b01a 100644
@@ -114,3 +114,7 @@
 &vuart {
        status = "okay";
 };
+
+&ibt {
+       status = "okay";
+};
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +4 -0
index 09dab179e154..4039381f9361 100644
@@ -270,3 +270,7 @@
                aspeed,fan-tach-ch = /bits/ 8 <0x0e>;
        };
 };
+
+&ibt {
+       status = "okay";
+};
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +4 -0
index b24ea9967fc8..5f8dbffa6b22 100644
@@ -632,3 +632,7 @@
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_wdtrst1_default>;
 };
+
+&ibt {
+       status = "okay";
+};
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +4 -1
index e7669d126df1..7f5a29566801 100644
@@ -435,3 +435,7 @@
                aspeed,fan-tach-ch = /bits/ 8 <0x03>;
        };
 };
+
+&ibt {
+       status = "okay";
+};
--

2.15.1