Skip to contentSkip to conversation

runltp: Append ${LTPROOT}/bin to PATH variable

PATCH New Hoang Van Tuyen 2 participants 4 messages Jan 26, 2018 – Jan 31, 2018

lore
Share & tools
lore

Hoang Van Tuyen

author
#0 lore raw

PATCH 1/1 runltp: Append ${LTPROOT}/bin to PATH variable

Some executable files were installed to ${LTPROOT}/bin. So, We should append ${LTPROOT}/bin to PATH variable.

Signed-off-by Hoang Van Tuyen <[email protected]>
---
  runltp        | 2 +-
  runltplite.sh | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
runltp +1 -1
index 302c4a7..51357fa 100755
@@ -78,7 +78,7 @@ setup()
      }
      export LTPROOT=${PWD}
      export TMPBASE="/tmp"
-    export PATH="${PATH}:${LTPROOT}/testcases/bin"
+    export PATH="${PATH}:${LTPROOT}/testcases/bin:${LTPROOT}/bin"
 
      export LTP_DEV_FS_TYPE="ext2"
runltplite.sh +1 -1
index 17be009..de90534 100755
@@ -49,7 +49,7 @@ setup()
      export LTPROOT=${PWD}
      export TMPBASE="/tmp"
      export TMP="${TMPBASE}/ltp-$$"
-    export PATH="${PATH}:${LTPROOT}/testcases/bin"
+    export PATH="${PATH}:${LTPROOT}/testcases/bin:${LTPROOT}/bin"
 
      export LTP_DEV=""
      export LTP_DEV_FS_TYPE="ext2"
Signature · 16 lines
2.1.4

-- 
================================================================
Hoang Van Tuyen (Mr.)
TOSHIBA SOFTWARE DEVELOPMENT (VIETNAM) CO., LTD.
16th Floor, VIT Building, 519 Kim Ma Str., Ba Dinh Dist., Hanoi, Vietnam
Tel: 84-4-22208801 (Company) - Ext.251
Fax: 84-4-22208802 (Company)
Email: [email protected]
================================================================


-- 
This mail was scanned by BitDefender
For more information please visit http://www.bitdefender.com
#1 lore raw

PATCH 1/1 runltp: Append ${LTPROOT}/bin to PATH variable

Hi!

Quoted 2 lines

Some executable files were installed to ${LTPROOT}/bin. So, We should append ${LTPROOT}/bin to PATH variable.

Here we should also describe that it fixes the ext4 testcases, other than that this looks good.

You can either add it yourself and resend the patch or I can do that before I apply the patch.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#2 lore raw

PATCH 1/1 runltp: Append ${LTPROOT}/bin to PATH variable

Hi!,

Quoted 2 lines

You can either add it yourself and resend the patch or I can do that before I apply the patch.

Can you add the describe for me?

Thanks and best regards,

Tuyen

Quoted 9 lines · Cyril Hrubis

Hi!

Quoted 2 lines

Some executable files were installed to ${LTPROOT}/bin. So, We should append ${LTPROOT}/bin to PATH variable.

Here we should also describe that it fixes the ext4 testcases, other than that this looks good.

You can either add it yourself and resend the patch or I can do that before I apply the patch.

Signature · 13 lines
================================================================
Hoang Van Tuyen (Mr.)
TOSHIBA SOFTWARE DEVELOPMENT (VIETNAM) CO., LTD.
16th Floor, VIT Building, 519 Kim Ma Str., Ba Dinh Dist., Hanoi, Vietnam
Tel: 84-4-22208801 (Company) - Ext.251
Fax: 84-4-22208802 (Company)
Email: [email protected]
================================================================


-- 
This mail was scanned by BitDefender
For more information please visit http://www.bitdefender.com
Applied
#3 lore raw

PATCH 1/1 runltp: Append ${LTPROOT}/bin to PATH variable

In reply to Hoang Van Tuyen

Hi!
The patch didn't apply, so since it was one-liner I've recreated it locally and also changed the commit message to be more specific.

Applied, thanks.

Signature · 2 lines
Cyril Hrubis
[email protected]