Skip to contentSkip to conversation

xfs: remove experimental tag for reverse mapping

PATCH In review Darrick J. Wong 3 participants 3 messages Jan 31, 2018 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: remove experimental tag for reverse mapping

From: Darrick J. Wong <[email protected]>

Reverse mapping has had a while to soak, so remove the experimental tag. Now that we've landed space metadata cross-referencing in scrub, the feature actually has a purpose.

Reject rmap filesystems with an rt device until the code to support it is actually implemented.

---
 fs/xfs/xfs_super.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
fs/xfs/xfs_super.c +1 -3
index f3e0001..f436eec 100644
@@ -1684,12 +1684,10 @@ xfs_fs_fill_super(
 	if (xfs_sb_version_hasrmapbt(&mp->m_sb)) {
 		if (mp->m_sb.sb_rblocks) {
 			xfs_alert(mp,
-	"EXPERIMENTAL reverse mapping btree not compatible with realtime device!");
+	"reverse mapping btree not compatible with realtime device!");
 			error = -EINVAL;
 			goto out_filestream_unmount;
 		}
-		xfs_alert(mp,
-	"EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!");
 	}
 
 	error = xfs_mountfs(mp);
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Reverse mapping has had a while to soak, so remove the experimental tag. Now that we've landed space metadata cross-referencing in scrub, the feature actually has a purpose.

Reject rmap filesystems with an rt device until the code to support it is actually implemented.

Quoted 26 lines
---
 fs/xfs/xfs_super.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
fs/xfs/xfs_super.c +1 -4
index f3e0001..f436eec 100644
@@ -1684,12 +1684,10 @@ xfs_fs_fill_super(
 	if (xfs_sb_version_hasrmapbt(&mp->m_sb)) {
 		if (mp->m_sb.sb_rblocks) {
 			xfs_alert(mp,
-	"EXPERIMENTAL reverse mapping btree not compatible with realtime device!");
+	"reverse mapping btree not compatible with realtime device!");
 			error = -EINVAL;
 			goto out_filestream_unmount;
 		}
-		xfs_alert(mp,
-	"EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!");
 	}
 
 	error = xfs_mountfs(mp);
--

To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Reviewed-by on v1 1/1
#2 lore raw
In reply to Darrick J. Wong
Quoted 10 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Reverse mapping has had a while to soak, so remove the experimental tag. Now that we've landed space metadata cross-referencing in scrub, the feature actually has a purpose.

Reject rmap filesystems with an rt device until the code to support it is actually implemented.

I've been using it for as long as I've been using reflink, and rmap has posed less problems than reflink. So I think this is the right time to remove the experimental flag.

Signature · 2 lines
Dave Chinner
[email protected]