ARM: dts: imx25-pinfunc: Use consistent naming for eSDHC

The eSDHC does not work properly if the SION bit is not set for the bidirectional CMD signal, whatever the eSDHC instance and the selected pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do this for MX25_PAD_*__ESDHCn_CMD in imx25-pinfunc.h in order to enforce this behavior for all boards.

This had already been done for eSDHC1, but not for eSDHC2. Also, define MX25_PAD_FEC_MDC__ESDHC2_CMD so that all the possible cases are covered from now on.

Cc Uwe Kleine-K?nig <[email protected]>

Signed-off-by Beno?t Th?baudeau <[email protected]>

Reviewed-by Fabio Estevam <[email protected]>

The eSDHC does not work properly if the SION bit is not set for the bidirectional CMD signal, whatever the eSDHC instance and the selected pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do this for MX25_PAD_*__ESDHCn_CMD in imx25-pinfunc.h in order to enforce this behavior for all boards.

This had already been done for eSDHC1, but not for eSDHC2. Also, define MX25_PAD_FEC_MDC__ESDHC2_CMD so that all the possible cases are covered from now on.

Cc Uwe Kleine-K?nig <[email protected]>

Signed-off-by Beno?t Th?baudeau <[email protected]>

Reviewed-by Fabio Estevam <[email protected]>

---
Changes v2 -> v3:
- Quickly mention SION in each comment, besides the reference to the verbose comment (suggested by Uwe).
Changes v1 -> v2:
- Update eSDHC instance and port naming following the addition of "ARM:
dts: imx25-pinfunc: Use consistent naming for eSDHC".
- Reference the more verbose comment for MX25_PAD_SD1_CMD__ESDHC1_CMD instead of copying the same less detailed comment everywhere (suggested by Uwe).

---
 arch/arm/boot/dts/imx25-pinfunc.h | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

This file had several naming inconsistencies for eSDHC:
- the instances were named sometimes SDn, sometimes SDHCn, whereas they are named ESDHCn in the reference manual, e.g.:

     MX25_PAD_SD1_CMD__SD1_CMD
     MX25_PAD_D15__SDHC1_DAT7
 - the data ports were named sometimes DATAn, sometimes DATn like in the
   reference manual, e.g.:
     MX25_PAD_SD1_DATA0__SD1_DATA0
     MX25_PAD_D15__SDHC1_DAT7
 - in one case, the clock port was named DAT_CLK instead of CLK:
     MX25_PAD_CSI_D7__SDHC2_DAT_CLK

This change:
- introduces new definitions using the naming from the reference manual,
- keeps definitions using the legacy naming in order not to break compatibility for out-of-tree users (they can be removed later),
- updates the in-tree files that were using the legacy naming.

Cc Uwe Kleine-K?nig <[email protected]>

Signed-off-by Beno?t Th?baudeau <[email protected]>

Acked-by Uwe Kleine-K?nig <[email protected]>

This file had several naming inconsistencies for eSDHC:
- the instances were named sometimes SDn, sometimes SDHCn, whereas they are named ESDHCn in the reference manual, e.g.:

     MX25_PAD_SD1_CMD__SD1_CMD
     MX25_PAD_D15__SDHC1_DAT7
 - the data ports were named sometimes DATAn, sometimes DATn like in the
   reference manual, e.g.:
     MX25_PAD_SD1_DATA0__SD1_DATA0
     MX25_PAD_D15__SDHC1_DAT7
 - in one case, the clock port was named DAT_CLK instead of CLK:
     MX25_PAD_CSI_D7__SDHC2_DAT_CLK

This change:
- introduces new definitions using the naming from the reference manual,
- keeps definitions using the legacy naming in order not to break compatibility for out-of-tree users (they can be removed later),
- updates the in-tree files that were using the legacy naming.

Cc Uwe Kleine-K?nig <[email protected]>

Signed-off-by Beno?t Th?baudeau <[email protected]>

Acked-by Uwe Kleine-K?nig <[email protected]>

---
Changes v2 -> v3:
- None.
Changes v1 -> v2:
- New patch (suggested by Uwe).

---
 .../boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts  | 12 ++--
 arch/arm/boot/dts/imx25-pdk.dts                    | 12 ++--
 arch/arm/boot/dts/imx25-pinfunc.h                  | 72 ++++++++++++++--------
 3 files changed, 60 insertions(+), 36 deletions(-)

This file had several naming inconsistencies for eSDHC:
- the instances were named sometimes SDn, sometimes SDHCn, whereas they are named ESDHCn in the reference manual, e.g.:

     MX25_PAD_SD1_CMD__SD1_CMD
     MX25_PAD_D15__SDHC1_DAT7
 - the data ports were named sometimes DATAn, sometimes DATn like in the
   reference manual, e.g.:
     MX25_PAD_SD1_DATA0__SD1_DATA0
     MX25_PAD_D15__SDHC1_DAT7
 - in one case, the clock port was named DAT_CLK instead of CLK:
     MX25_PAD_CSI_D7__SDHC2_DAT_CLK

This change:
- introduces new definitions using the naming from the reference manual,
- keeps definitions using the legacy naming in order not to break compatibility for out-of-tree users (they can be removed later),
- updates the in-tree files that were using the legacy naming.

Cc Uwe Kleine-K?nig <[email protected]>

Signed-off-by Beno?t Th?baudeau <[email protected]>

Acked-by Uwe Kleine-K?nig <[email protected]>