Skip to contentSkip to conversation

mkfs: don't create realtime filesystems with reflink enabled

PATCH In review Darrick J. Wong 2 participants 2 messages Feb 1, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mkfs: don't create realtime filesystems with reflink enabled

From: Darrick J. Wong <[email protected]>

We don't support reflink on the realtime device, so don't let people create such things.

---
 mkfs/xfs_mkfs.c |    7 +++++++
 1 file changed, 7 insertions(+)
mkfs/xfs_mkfs.c +7 -0
index f527476..07774ed 100644
@@ -2025,6 +2025,13 @@ _("cowextsize not supported without reflink support\n"));
 		usage();
 	}
 
+	if (cli->sb_feat.reflink && cli->xi->rtname) {
+		fprintf(stderr,
+_("reflink not supported with realtime devices\n"));
+		usage();
+		cli->sb_feat.reflink = false;
+	}
+
 	if (cli->sb_feat.rmapbt && cli->xi->rtname) {
 		fprintf(stderr,
 _("rmapbt not supported with realtime devices\n"));
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

We don't support reflink on the realtime device, so don't let people create such things.

yup ...

(how long 'til we come up with the conflicts matrix for all this stuff? ;)

Quoted 27 lines
---
 mkfs/xfs_mkfs.c |    7 +++++++
 1 file changed, 7 insertions(+)
mkfs/xfs_mkfs.c +7 -1
index f527476..07774ed 100644
@@ -2025,6 +2025,13 @@ _("cowextsize not supported without reflink support\n"));
 		usage();
 	}
 
+	if (cli->sb_feat.reflink && cli->xi->rtname) {
+		fprintf(stderr,
+_("reflink not supported with realtime devices\n"));
+		usage();
+		cli->sb_feat.reflink = false;
+	}
+
 	if (cli->sb_feat.rmapbt && cli->xi->rtname) {
 		fprintf(stderr,
 _("rmapbt not supported with realtime devices\n"));
--

To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html