drm/i915: Less verbose engine startup
Subsystems (2)
Tvrtko Ursulin
maintainerPATCH 1/1 drm/i915: Less verbose engine startup
From: Tvrtko Ursulin <[email protected]>
To decrease log spam on GPU reset in case of execlists we move the engine init messages from the init vfunc to intel_engines_init.
This way on startup we still get information on all available engines in debug logs, and we replace the reset/resume side of things with a single line which outputs simply a number of initialized engines (so that there is less doubt on whether the actual code has been executed).
--- drivers/gpu/drm/i915/i915_gem.c | 4 ++++ drivers/gpu/drm/i915/intel_engine_cs.c | 2 ++ drivers/gpu/drm/i915/intel_lrc.c | 1 - 3 files changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem.c +4 -0
@@ -5055,14 +5055,18 @@ static int __i915_gem_restart_engines(void *data)struct drm_i915_private *i915 = data;struct intel_engine_cs *engine;enum intel_engine_id id; +unsigned int count =0 ;int err;for_each_engine (engine, i915, id) { err = engine->init_hw (engine);if (err)return err; + count++; } +DRM_DEBUG_DRIVER ("Initialized %u engines\n" , count); +return 0 ; }
drivers/gpu/drm/i915/intel_engine_cs.c +2 -0
@@ -348,6 +348,8 @@ int intel_engines_init(struct drm_i915_private *dev_priv) goto cleanup;GEM_BUG_ON (!engine->submit_request); + +DRM_DEBUG_DRIVER ("%s initialized\n" , engine->name); }return 0 ;
drivers/gpu/drm/i915/intel_lrc.c +0 -1
@@ -1479,7 +1479,6 @@ static int gen8_init_common_ring(struct intel_engine_cs *engine)intel_engine_init_hangcheck (engine);enable_execlists (engine); -DRM_DEBUG_DRIVER ("Execlists enabled for %s\n" , engine->name);GEM_BUG_ON (engine->id >=ARRAY_SIZE (gtiir));
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Less verbose engine startup
== Series Details ==
== Series Details ==
Series: drm/i915: Less verbose engine startup
URL : https://patchwork.freedesktop.org/series/37476/
State : success
== Summary ==
Series 37476v1 drm/i915: Less verbose engine startup
https://patchwork.freedesktop.org/api/1.0/series/37476/revisions/1/mbox/
Test debugfs_test:
Subgroup read_all_entries:
dmesg-fail -> PASS (fi-elk-e7500) fdo#103989 +10
Test gem_ringfill:
Subgroup basic-default-hang:
incomplete -> DMESG-WARN (fi-pnv-d510) fdo#101600
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-snb-2520m) fdo#103713fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:417s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:425s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:371s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:483s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:281s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:482s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:489s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:463s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:451s fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:569s fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:412s fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:279s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:510s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:388s fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:398s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:408s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:458s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:411s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:457s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:493s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:451s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:503s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:585s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:426s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:511s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:527s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:479s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:481s fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:419s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:428s fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:512s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:392s
Blacklisted hosts:
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:466s
3c4e44925b6039250a27f1e0fbd385af0928d3f4 drm-tip: 2018y-02m-01d-10h-29m-46s UTC integration manifest cdb8539bd40d drm/i915: Less verbose engine startup
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7851/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2018-02-01 11:08:08)
Quoted 4 lines
From: Tvrtko Ursulin <[email protected]>
To decrease log spam on GPU reset in case of execlists we move the engine init messages from the init vfunc to
intel_engines_init.
This still has exactly the same issue, the 10,000 irrelevant debug messages during selftests. Just not 50,000 anymore. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Less verbose engine startup
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Less verbose engine startup
URL : https://patchwork.freedesktop.org/series/37476/
State : success
== Summary ==
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-crc-atomic:
pass -> FAIL (shard-apl) fdo#102670
Test perf:
Subgroup buffer-fill:
fail -> PASS (shard-apl) fdo#103755
Subgroup oa-exponents:
fail -> PASS (shard-apl) fdo#102254
Test kms_cursor_crc:
Subgroup cursor-128x128-suspend:
pass -> SKIP (shard-snb) fdo#103880
Test kms_sysfs_edid_timing:
pass -> WARN (shard-apl) fdo#100047
Test gem_exec_schedule:
Subgroup preempt-other-vebox:
pass -> FAIL (shard-apl) fdo#102848
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-pri-indfb-draw-render:
pass -> FAIL (shard-snb) fdo#101623
Test kms_flip:
Subgroup 2x-flip-vs-expired-vblank-interruptible:
pass -> FAIL (shard-hsw) fdo#102887
Test gem_eio:
Subgroup in-flight-contexts:
pass -> DMESG-WARN (shard-snb) fdo#104058fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#103755 https://bugs.freedesktop.org/show_bug.cgi?id=103755
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254
fdo#103880 https://bugs.freedesktop.org/show_bug.cgi?id=103880
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#102848 https://bugs.freedesktop.org/show_bug.cgi?id=102848
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#104058 https://bugs.freedesktop.org/show_bug.cgi?id=104058
shard-apl total:2838 pass:1748 dwarn:1 dfail:0 fail:24 skip:1064 time:12715s shard-hsw total:2838 pass:1734 dwarn:1 dfail:0 fail:12 skip:1090 time:11990s shard-snb total:2838 pass:1327 dwarn:2 dfail:0 fail:11 skip:1498 time:6580s
Blacklisted hosts:
shard-kbl total:2817 pass:1856 dwarn:1 dfail:0 fail:22 skip:937 time:9472s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7851/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx