Skip to contentSkip to conversation

Patch "reiserfs: remove unneeded i_version bump" has been added to the 4.14-stable tree

PATCH [email protected] 2 participants 3 messages Feb 1, 2018 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

reiserfs: remove unneeded i_version bump

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
reiserfs-remove-unneeded-i_version-bump.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Feb 1 13:45:42 CET 2018

From: Jeff Layton <[email protected]>
Date: Mon, 30 Oct 2017 11:20:15 -0400
Subject: reiserfs: remove unneeded i_version bump

From: Jeff Layton <[email protected]>

[ Upstream commit 9f97df50c52c2887432debb6238f4e43567386a5 ]

The i_version field in reiserfs is not initialized and is only ever updated here. Nothing ever views it, so just remove it.

---
 fs/reiserfs/super.c |    1 -
 1 file changed, 1 deletion(-)
fs/reiserfs/super.c +0 -1
@@ -2591,7 +2591,6 @@ out:
 		return err;
 	if (inode->i_size < off + len - towrite)
 		i_size_write(inode, off + len - towrite);
-	inode->i_version++;
 	inode->i_mtime = inode->i_ctime = current_time(inode);
 	mark_inode_dirty(inode);
 	return len - towrite;

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/lockd-fix-list_add-double-add-caused-by-legacy-signal-interface.patch queue-4.14/reiserfs-remove-unneeded-i_version-bump.patch

#1 lore raw
Quoted 48 lines · On Thu, 2018-02-01 at 14:13 +0100, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

reiserfs: remove unneeded i_version bump

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
reiserfs-remove-unneeded-i_version-bump.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From foo@baz Thu Feb 1 13:45:42 CET 2018
From: Jeff Layton <[email protected]>
Date: Mon, 30 Oct 2017 11:20:15 -0400
Subject: reiserfs: remove unneeded i_version bump

From: Jeff Layton <[email protected]>

[ Upstream commit 9f97df50c52c2887432debb6238f4e43567386a5 ]

The i_version field in reiserfs is not initialized and is only ever updated here. Nothing ever views it, so just remove it.

---
 fs/reiserfs/super.c |    1 -
 1 file changed, 1 deletion(-)
fs/reiserfs/super.c +0 -1
@@ -2591,7 +2591,6 @@ out:
 		return err;
 	if (inode->i_size < off + len - towrite)
 		i_size_write(inode, off + len - towrite);
-	inode->i_version++;
 	inode->i_mtime = inode->i_ctime = current_time(inode);
 	mark_inode_dirty(inode);
 	return len - towrite;
Quoted 4 lines

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/lockd-fix-list_add-double-add-caused-by-legacy-signal-interface.patch queue-4.14/reiserfs-remove-unneeded-i_version-bump.patch

Is this needed to ease merging of another patch? I've no real objection to including this as it should be harmless but it doesn't really fix a bug per-se. I'm not sure we really need that in stable kernels.

Signature · 1 line
Jeff Layton <[email protected]>
author maintainer
#2 lore raw
Quoted 49 lines · Jeff Layton
Quoted 48 lines · On Thu, 2018-02-01 at 14:13 +0100, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

reiserfs: remove unneeded i_version bump

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
reiserfs-remove-unneeded-i_version-bump.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From foo@baz Thu Feb 1 13:45:42 CET 2018
From: Jeff Layton <[email protected]>
Date: Mon, 30 Oct 2017 11:20:15 -0400
Subject: reiserfs: remove unneeded i_version bump

From: Jeff Layton <[email protected]>

[ Upstream commit 9f97df50c52c2887432debb6238f4e43567386a5 ]

The i_version field in reiserfs is not initialized and is only ever updated here. Nothing ever views it, so just remove it.

---
 fs/reiserfs/super.c |    1 -
 1 file changed, 1 deletion(-)
fs/reiserfs/super.c +0 -1
@@ -2591,7 +2591,6 @@ out:
 		return err;
 	if (inode->i_size < off + len - towrite)
 		i_size_write(inode, off + len - towrite);
-	inode->i_version++;
 	inode->i_mtime = inode->i_ctime = current_time(inode);
 	mark_inode_dirty(inode);
 	return len - towrite;
Quoted 8 lines
Quoted 4 lines

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/lockd-fix-list_add-double-add-caused-by-legacy-signal-interface.patch queue-4.14/reiserfs-remove-unneeded-i_version-bump.patch

Is this needed to ease merging of another patch? I've no real objection to including this as it should be harmless but it doesn't really fix a bug per-se. I'm not sure we really need that in stable kernels.

Yeah, that looks odd. At first glance I thought it was fixing an issue, but it seems that it's just a "remove dead code" patch.

Sasha, should I drop this?

thanks,

greg k-h