tests/test-filter-redirector: move close()
PATCH 1/1 tests/test-filter-redirector: move close()
Since we have separate handler on POLLHUP, which drops data after closing the connection we need to fix this test, because it sends data and instantly close the socket creating race condition. In some cases on other end of socket client closes it faster than reads data. To prevent it I suggest to close socket after recieving.
--- tests/test-filter-redirector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/test-filter-redirector.c +1 -1
@@ -186,7 +186,6 @@ static void test_redirector_rx(void) ret =iov_send (send_sock, iov,2 ,0 ,sizeof (size) +sizeof (send_buf)); g_assert_cmpint(ret, ==, sizeof(send_buf) + sizeof(size)); -close (send_sock); ret =qemu_recv (backend_sock[0 ], &len,sizeof (len),0 ); g_assert_cmpint(ret, ==, sizeof(len));
@@ -197,6 +196,7 @@ static void test_redirector_rx(void) ret =qemu_recv (backend_sock[0 ], recv_buf, len,0 ); g_assert_cmpstr(recv_buf, ==, send_buf); +close (send_sock);g_free (recv_buf);unlink (sock_path0);unlink (sock_path1);
Signature · 1 line
2.14.3
Paolo Bonzini
AppliedQuoted 25 lines · Klim Kireev
Since we have separate handler on POLLHUP, which drops data after closing the connection we need to fix this test, because it sends data and instantly close the socket creating race condition. In some cases on other end of socket client closes it faster than reads data. To prevent it I suggest to close socket after recieving.
Signed-off-by Klim Kireev <[email protected]>--- tests/test-filter-redirector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/test-filter-redirector.c +0
-1@@ -186,7 +186,6 @@ static void test_redirector_rx(void) ret =iov_send (send_sock, iov,2 ,0 ,sizeof (size) +sizeof (send_buf)); g_assert_cmpint(ret, ==, sizeof(send_buf) + sizeof(size)); -close (send_sock); ret =qemu_recv (backend_sock[0 ], &len,sizeof (len),0 ); g_assert_cmpint(ret, ==, sizeof(len));
tests/test-filter-redirector.c static void test_redirector_rx(void) · line 202
Quoted 7 lines
tests/test-filter-redirector.c +1
-0@@ -197,6 +196,7 @@ static void test_redirector_rx(void) ret =qemu_recv (backend_sock[0 ], recv_buf, len,0 ); g_assert_cmpstr(recv_buf, ==, send_buf); +close (send_sock);g_free (recv_buf);unlink (sock_path0);unlink (sock_path1);
Queued, thanks.
Paolo