Skip to contentSkip to conversation

board_f: Show only .text location in display_text_info()

PATCH New Alexey Brodkin 2 participants 2 messages Feb 1, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board_f: Show only .text location in display_text_info()

For some reason we used to print not only location of .text section [before relocation] but also .bss start and end.

Moreover how that was printed was obviously misleading:
--------------------------------->8--------------------------- U-Boot code: 20001000 -> 30008C00 BSS: -> 3000C58E --------------------------------->8---------------------------

I would interpret it like this:
U-Boot's code is situated in memory starting from 0x20001000 till 0x30008000.. and BTW there's .bss section starting from 0x3000C58E.

Which is wrong. But anyways why bother about .bss here so let's drop .bss part in that pure debug output.

Note even though this change has logically nothing in common with [1] they both touch the same function display_text_info() which makes [1] a prerequisite for this one. Otherwise trivial modifications will be required in both if they happen to be reordered.

[1] http://patchwork.ozlabs.org/patch/868299/

---
 common/board_f.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
common/board_f.c +1 -9
index de3907cd11fc..cfb4cfc52133 100644
@@ -124,15 +124,7 @@ static int init_baud_rate(void)
 static int display_text_info(void)
 {
 #if !defined(CONFIG_SANDBOX) && !defined(CONFIG_EFI_APP)
-	ulong bss_start, bss_end, text_base;
-
-	bss_start = (ulong)&__bss_start;
-	bss_end = (ulong)&__bss_end;
-
-	text_base = CONFIG_SYS_TEXT_BASE;
-
-	debug("U-Boot code: %08lX -> %08lX  BSS: -> %08lX\n",
-		text_base, bss_start, bss_end);
+	debug("U-Boot code: %08x\n", CONFIG_SYS_TEXT_BASE);
 #endif
 
 	return 0;
Signature · 1 line
2.14.3
#1 lore raw

PATCH 1/1 board_f: Show only .text location in display_text_info()

Hi Alexey,

Quoted 21 lines · Alexey Brodkin

For some reason we used to print not only location of .text section [before relocation] but also .bss start and end.

Moreover how that was printed was obviously misleading:
--------------------------------->8--------------------------- U-Boot code: 20001000 -> 30008C00 BSS: -> 3000C58E --------------------------------->8---------------------------

I would interpret it like this:
U-Boot's code is situated in memory starting from 0x20001000 till 0x30008000.. and BTW there's .bss section starting from 0x3000C58E.

Which is wrong. But anyways why bother about .bss here so let's drop .bss part in that pure debug output.

Note even though this change has logically nothing in common with [1] they both touch the same function display_text_info() which makes [1] a prerequisite for this one. Otherwise trivial modifications will be required in both if they happen to be reordered.

Quoted 8 lines

[1] http://patchwork.ozlabs.org/patch/868299/

---
 common/board_f.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

I think it is sometimes useful to print BSS. I have had problems with it overlapping (e.g.) the DT. Can you just fix the output?

Regards,
Simon