Skip to contentSkip to conversation

IB/core: Avoid a potential OOPs for an unused optional parameter

PATCH In review Dennis Dalessandro 2 participants 2 messages Feb 1, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IB/core: Avoid a potential OOPs for an unused optional parameter

From: Michael J. Ruhl <[email protected]>

The ev_file is an optional parameter for CQ creation. If the parameter is not passed, the ev_file pointer will be NULL. Using that pointer to set the cq_context will result in an OOPs.

Verify that ev_file is not NULL before using.

Cc <[email protected]> # 4.14.x
Fixes 9ee79fce3642 ("IB/core: Add completion queue (cq) object actions")
---
 drivers/infiniband/core/uverbs_std_types.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/infiniband/core/uverbs_std_types.c +1 -1
index b571176..cab0ac3 100644
@@ -316,7 +316,7 @@ static int uverbs_create_cq_handler(struct ib_device *ib_dev,
 	cq->uobject       = &obj->uobject;
 	cq->comp_handler  = ib_uverbs_comp_handler;
 	cq->event_handler = ib_uverbs_cq_event_handler;
-	cq->cq_context    = &ev_file->ev_queue;
+	cq->cq_context    = ev_file ? &ev_file->ev_queue : NULL;
 	obj->uobject.object = cq;
 	obj->uobject.user_handle = user_handle;
 	atomic_set(&cq->usecnt, 0);
#1 lore raw
Quoted 8 lines · Dennis Dalessandro

From: Michael J. Ruhl <[email protected]>

The ev_file is an optional parameter for CQ creation. If the parameter is not passed, the ev_file pointer will be NULL. Using that pointer to set the cq_context will result in an OOPs.

Verify that ev_file is not NULL before using.

Quoted 8 lines
Cc <[email protected]> # 4.14.x
Fixes 9ee79fce3642 ("IB/core: Add completion queue (cq) object actions")
 drivers/infiniband/core/uverbs_std_types.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Yep! I was testing this recently and didn't hit this bug, it only becomes a crash if something tries to use the cq..

Jason