staging: media: atomisp: remove pointless string copy
Subsystems (4)
PATCH 1/1 staging: media: atomisp: remove pointless string copy
gcc-8 points out that a string is copied to itself here:
In file included from drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_include/platform_support.h:25,
from drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_include/memory_access/memory_access.h:48, from drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/debug/src/ia_css_debug.c:16:
In function 'strncpy',
inlined from 'ia_css_debug_pipe_graph_dump_stage' at drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_include/string_support.h:158:2:include/linux/string.h:253:9: error: '__builtin_strncpy' source argument is the same as destination [-Werror=restrict]
return __builtin_strncpy(p, q, size);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~This removes the bogus code, leaving the behavior otherwise unchanged.
--- .../atomisp/pci/atomisp2/css2400/runtime/debug/src/ia_css_debug.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/debug/src/ia_css_debug.c +1 -7
@@ -2858,13 +2858,7 @@ ia_css_debug_pipe_graph_dump_stage(if (l && enable_info[l-1 ] ==',' ) enable_info[--l] ='\0' ; -if (l <=ENABLE_LINE_MAX_LENGTH ) { -/* It fits on one line, copy string and init */ -/* other helper strings with empty string */ -strcpy_s (enable_info, -sizeof (enable_info), - ei); - }else { +if (l >ENABLE_LINE_MAX_LENGTH ) {/* Too big for one line, find last comma */ p =ENABLE_LINE_MAX_LENGTH ;while (ei[p] !=',' )
Signature · 1 line
2.9.0