cfg80211: fix cfg80211_beacon_dup
Subsystems (4)
PATCH 1/1 cfg80211: fix cfg80211_beacon_dup
gcc-8 warns about some obviously incorrect code:
net/mac80211/cfg.c: In function 'cfg80211_beacon_dup':net/mac80211/cfg.c:2896:3: error: 'memcpy' source argument is the same as destination [-Werror=restrict]
Quoted 1 line
From the context, I conclude that we want to copy from beacon into
new_beacon, as we do in the rest of the function.
Fixes 73da7d5bab79 ("mac80211: add channel switch command and beacon callbacks")
Signed-off-by Arnd Bergmann <[email protected]>
--- net/mac80211/cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/mac80211/cfg.c +1 -1
@@ -2892,7 +2892,7 @@ cfg80211_beacon_dup(struct cfg80211_beacon_data *beacon) }if (beacon->probe_resp_len) { new_beacon->probe_resp_len = beacon->probe_resp_len; - beacon->probe_resp = pos; + new_beacon->probe_resp = pos;memcpy (pos, beacon->probe_resp, beacon->probe_resp_len); pos += beacon->probe_resp_len; }
Signature · 1 line
2.9.0