Skip to contentSkip to conversation

gfs2: select CONFIG_LIBCRC32C

PATCH In review Arnd Bergmann 2 participants 2 messages Feb 2, 2018 GFS2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gfs2: select CONFIG_LIBCRC32C

The new crc32c logic in gfs2_log_header_v2 causes a link error without libcrc32c:

ERROR: "crc32c" [fs/gfs2/gfs2.ko] undefined!

While the original patch selected CONFIG_CRYPTO_CRC32C to deal with this issue, it turned out to be the wrong symbol.

Fixes c1696fb85d33 ("GFS2: Introduce new gfs2_log_header_v2")
---
 fs/gfs2/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/gfs2/Kconfig +1 -2
index c0225d4b5435..3ed2b088dcfd 100644
@@ -3,8 +3,7 @@ config GFS2_FS
 	depends on (64BIT || LBDAF)
 	select FS_POSIX_ACL
 	select CRC32
-	select CRYPTO
-	select CRYPTO_CRC32C
+	select LIBCRC32C
 	select QUOTACTL
 	select FS_IOMAP
 	help
Signature · 1 line
2.9.0
#1 lore raw

Hi Arnd,

2018-02-02 16:43 GMT+01:00 Arnd Bergmann <[email protected]>:

Quoted 29 lines

The new crc32c logic in gfs2_log_header_v2 causes a link error without libcrc32c:

ERROR: "crc32c" [fs/gfs2/gfs2.ko] undefined!

While the original patch selected CONFIG_CRYPTO_CRC32C to deal with this issue, it turned out to be the wrong symbol.

Fixes c1696fb85d33 ("GFS2: Introduce new gfs2_log_header_v2")
---
 fs/gfs2/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/gfs2/Kconfig +1 -3
index c0225d4b5435..3ed2b088dcfd 100644
@@ -3,8 +3,7 @@ config GFS2_FS
        depends on (64BIT || LBDAF)
        select FS_POSIX_ACL
        select CRC32
-       select CRYPTO
-       select CRYPTO_CRC32C
+       select LIBCRC32C
        select QUOTACTL
        select FS_IOMAP
        help
--
Quoted 2 lines

2.9.0

thanks for the fix, it's identical to what Bob has just asked Linus to merge (https://lkml.org/lkml/2018/2/2/361).

Andreas