Skip to contentSkip to conversation

python-remi: fix trailing whitespace and line size

PATCH Superseded Gwenhael Goavec-Merou 2 participants 3 messages Feb 4, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 python-remi: fix trailing whitespace and line size

From: Gwenhael Goavec-Merou <[email protected]>

Fixes line size in Config.in, trailing whitespace after # and empty line

Fixes:
- https://gitlab.com/buildroot.org/buildroot/-/jobs/50971692

---
 package/python-remi/Config.in      | 9 +++++----
 package/python-remi/python-remi.mk | 3 +--
 2 files changed, 6 insertions(+), 6 deletions(-)
package/python-remi/Config.in +5 -4
index 68d0a92b11..2f4216b324 100644
@@ -1,9 +1,10 @@
 config BR2_PACKAGE_PYTHON_REMI
 	bool "python-remi"
 	help
-	  Remi is a GUI library for Python applications which transpiles an
-	  application's interface into HTML to be rendered in a web browser.
-	  This removes platform-specific dependencies and lets you easily
-	  develop cross-platform applications in Python!
+	  Remi is a GUI library for Python applications which
+	  transpiles an application's interface into HTML to be
+	  rendered in a web browser. This removes platform-specific
+	  dependencies and lets you easily develop cross-platform
+	  applications in Python!
 
 	  https://github.com/dddomodossola/remi/tree/master
package/python-remi/python-remi.mk +1 -2
index 6514118192..3356430ddb 100644
@@ -1,5 +1,5 @@
 ################################################################################
-# 
+#
 # python-remi
 #
 ################################################################################
@@ -11,4 +11,3 @@ PYTHON_REMI_LICENSE_FILES = LICENSE
 PYTHON_REMI_SETUP_TYPE = setuptools
 
 $(eval $(python-package))
-
Signature · 1 line
2.13.6
#1 lore raw

PATCH 1/1 python-remi: fix trailing whitespace and line size

Gwenhael, All,

On 2018-02-04 18:24 +0100, Gwenhael Goavec-Merou spake thusly:

Quoted 20 lines

From: Gwenhael Goavec-Merou <[email protected]>

Fixes line size in Config.in, trailing whitespace after # and empty line

Fixes:
- https://gitlab.com/buildroot.org/buildroot/-/jobs/50971692

---
 package/python-remi/Config.in      | 9 +++++----
 package/python-remi/python-remi.mk | 3 +--
 2 files changed, 6 insertions(+), 6 deletions(-)
package/python-remi/Config.in +0 -0
index 68d0a92b11..2f4216b324 100644
@@ -1,9 +1,10 @@
 config BR2_PACKAGE_PYTHON_REMI
 	bool "python-remi"

package/python-remi/Config.in line 8

Quoted 10 lines
package/python-remi/Config.in +5 -4
 	help
-	  Remi is a GUI library for Python applications which transpiles an
-	  application's interface into HTML to be rendered in a web browser.
-	  This removes platform-specific dependencies and lets you easily
-	  develop cross-platform applications in Python!
+	  Remi is a GUI library for Python applications which
+	  transpiles an application's interface into HTML to be
+	  rendered in a web browser. This removes platform-specific
+	  dependencies and lets you easily develop cross-platform
+	  applications in Python!

You actually over-wrapped the help text. It can fit on 4 lines, which even looks nicer:

Remi is a GUI library for Python applications which transpiles an application's interface into HTML to be rendered in a web browser. This removes platform-specific dependencies and lets you easily develop cross-platform applications in Python!

Otherwise:

Thanks! :-)

Regards,
Yann E. MORIN.

Quoted 24 lines
package/python-remi/Config.in +0 -0
 	  https://github.com/dddomodossola/remi/tree/master
package/python-remi/python-remi.mk +1 -2
index 6514118192..3356430ddb 100644
@@ -1,5 +1,5 @@
 ################################################################################
-# 
+#
 # python-remi
 #
 ################################################################################
@@ -11,4 +11,3 @@ PYTHON_REMI_LICENSE_FILES = LICENSE
 PYTHON_REMI_SETUP_TYPE = setuptools
 
 $(eval $(python-package))
-
Signature · 6 lines
2.13.6

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 python-remi: fix trailing whitespace and line size

Thanks.
I think I will re-read rules for packages submission :)

Gwen

Quoted 89 lines · On Sun, 4 Feb 2018 18:38:42 +0100 "Yann E. MORIN" <[email protected]>…

Gwenhael, All,

On 2018-02-04 18:24 +0100, Gwenhael Goavec-Merou spake thusly:

Quoted 28 lines

From: Gwenhael Goavec-Merou <[email protected]>

Fixes line size in Config.in, trailing whitespace after # and empty line

Fixes:
- https://gitlab.com/buildroot.org/buildroot/-/jobs/50971692

Signed-off-by: Gwenhael Goavec-Merou
<[email protected]> ---

 package/python-remi/Config.in      | 9 +++++----
 package/python-remi/python-remi.mk | 3 +--
 2 files changed, 6 insertions(+), 6 deletions(-)
(quoted diff) +0 -0

b/package/python-remi/Config.in index 68d0a92b11..2f4216b324 100644

package/python-remi/Config.in +0 -1
@@ -1,9 +1,10 @@
 config BR2_PACKAGE_PYTHON_REMI
 	bool "python-remi"
 	help
-	  Remi is a GUI library for Python applications which

transpiles an

package/python-remi/Config.in +0 -1
-	  application's interface into HTML to be rendered in a

web browser.

package/python-remi/Config.in +0 -1
-	  This removes platform-specific dependencies and lets you

easily

package/python-remi/Config.in line 8

Quoted 6 lines
package/python-remi/Config.in +5 -1
-	  develop cross-platform applications in Python!
+	  Remi is a GUI library for Python applications which
+	  transpiles an application's interface into HTML to be
+	  rendered in a web browser. This removes platform-specific
+	  dependencies and lets you easily develop cross-platform
+	  applications in Python!  

You actually over-wrapped the help text. It can fit on 4 lines, which even looks nicer:

Remi is a GUI library for Python applications which transpiles an application's interface into HTML to be rendered in a web browser. This removes platform-specific dependencies and lets you easily develop cross-platform applications in Python!

Otherwise:

Thanks! :-)

Regards,
Yann E. MORIN.

Quoted 24 lines
package/python-remi/Config.in +0 -0
 	  https://github.com/dddomodossola/remi/tree/master
(quoted diff) +0 -0

b/package/python-remi/python-remi.mk index 6514118192..3356430ddb 100644 --- a/package/python-remi/python-remi.mk
+++ b/package/python-remi/python-remi.mk

package/python-remi/python-remi.mk +1 -2
@@ -1,5 +1,5 @@
 ################################################################################
-# 
+#
 # python-remi
 #
 ################################################################################
@@ -11,4 +11,3 @@ PYTHON_REMI_LICENSE_FILES = LICENSE
 PYTHON_REMI_SETUP_TYPE = setuptools
 
 $(eval $(python-package))
-
Signature · 6 lines
2.13.6

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot  
Signature · 8 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
conspiracy: | | +33 662 376 056 | Software  Designer | \ /
CAMPAIGN     |  ___               | | +33 223 225 172
`------------.-------:  X  AGAINST      |  \e/  There is no  | |
http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
conspiracy.  |
'------------------------------^-------^------------------^--------------------'