Skip to contentSkip to conversation

Kconfig: Use imply for network commands in distro default

PATCH New Michal Simek 2 participants 3 messages Jan 31, 2018 – Feb 6, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Kconfig: Use imply for network commands in distro default

There is no reason to unconditially select network commands as distro defaults. Systems without ethernet but with sd, sata, usb should also be able to use distro defaults. Use imply instead of select.

---

 Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Kconfig +4 -4
index 9b8a8077993a..55bb00936cf7 100644
@@ -69,14 +69,14 @@ config DISTRO_DEFAULTS
 	imply USE_BOOTCOMMAND
 	select CMD_BOOTZ if ARM && !ARM64
 	select CMD_BOOTI if ARM64
-	select CMD_DHCP
-	select CMD_PXE
+	imply CMD_DHCP
+	imply CMD_PXE
 	select CMD_EXT2
 	select CMD_EXT4
 	select CMD_FAT
 	select CMD_FS_GENERIC
-	select CMD_MII
-	select CMD_PING
+	imply CMD_MII
+	imply CMD_PING
 	select CMD_PART
 	select HUSH_PARSER
 	help
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 Kconfig: Use imply for network commands in distro default

Quoted 23 lines · Michal Simek

There is no reason to unconditially select network commands as distro defaults. Systems without ethernet but with sd, sata, usb should also be able to use distro defaults. Use imply instead of select.

---

 Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Kconfig +2 -2
index 9b8a8077993a..55bb00936cf7 100644
@@ -69,14 +69,14 @@ config DISTRO_DEFAULTS
 	imply USE_BOOTCOMMAND
 	select CMD_BOOTZ if ARM && !ARM64
 	select CMD_BOOTI if ARM64
-	select CMD_DHCP
-	select CMD_PXE
+	imply CMD_DHCP
+	imply CMD_PXE
 	select CMD_EXT2

Kconfig config DISTRO_DEFAULTS · line 82

Quoted 10 lines
Kconfig +2 -2
 	select CMD_EXT4
 	select CMD_FAT
 	select CMD_FS_GENERIC
-	select CMD_MII
-	select CMD_PING
+	imply CMD_MII
+	imply CMD_PING
 	select CMD_PART
 	select HUSH_PARSER
 	help

Should we perhaps use select CMD_DHCP if NET, etc? There's a certain level of non-opt-outedness that's supposed to be here, so long as the underlying functionality is there. And a follow-up might be that a bunch more CMDs need to be nested under / depend on NET to start with. But that's just a thought. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180205/5e3ffa07/attachment.sig>
#2 lore raw

PATCH 1/1 Kconfig: Use imply for network commands in distro default

Quoted 33 lines · Tom Rini
Quoted 31 lines · Michal Simek

There is no reason to unconditially select network commands as distro defaults. Systems without ethernet but with sd, sata, usb should also be able to use distro defaults. Use imply instead of select.

---

 Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Kconfig +4 -4
index 9b8a8077993a..55bb00936cf7 100644
@@ -69,14 +69,14 @@ config DISTRO_DEFAULTS
 	imply USE_BOOTCOMMAND
 	select CMD_BOOTZ if ARM && !ARM64
 	select CMD_BOOTI if ARM64
-	select CMD_DHCP
-	select CMD_PXE
+	imply CMD_DHCP
+	imply CMD_PXE
 	select CMD_EXT2
 	select CMD_EXT4
 	select CMD_FAT
 	select CMD_FS_GENERIC
-	select CMD_MII
-	select CMD_PING
+	imply CMD_MII
+	imply CMD_PING
 	select CMD_PART
Quoted 8 lines

Kconfig config DISTRO_DEFAULTS · line 82

Quoted 2 lines
Kconfig +0 -0
 	select HUSH_PARSER
 	help

Should we perhaps use select CMD_DHCP if NET, etc? There's a certain level of non-opt-outedness that's supposed to be here, so long as the underlying functionality is there. And a follow-up might be that a bunch more CMDs need to be nested under / depend on NET to start with. But that's just a thought. Thanks!

Not a problem. I will take a look at cmd_net and phylib which should depends on net and will send v2.

Thanks,
Michal