extcon: int3496: process id-pin first so that we start with the right status
Subsystems (2)
PATCH v2 1/1 extcon: int3496: process id-pin first so that we start with the right status
Some other drivers may be waiting for our extcon to show-up (exiting their probe methods with -EPROBE_DEFER until we show up).
These drivers will typically get the cable state directly after getting the extcon, this commit changes the int3496 code to process the id-pin before registering the extcon, so that other drivers see the correct state right away.
--- drivers/extcon/extcon-intel-int3496.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/extcon/extcon-intel-int3496.c +4 -3
@@ -131,6 +131,10 @@ static int int3496_probe(struct platform_device *pdev)if (IS_ERR (data->gpio_usb_mux))dev_info (dev,"can't request USB MUX GPIO\n" ); +/* process id-pin first so that we start with the right status */ +queue_delayed_work (system_wq, &data->work,0 ); +flush_delayed_work (&data->work); +/* register extcon device */ data->edev =devm_extcon_dev_allocate (dev, int3496_cable);if (IS_ERR (data->edev))
@@ -153,9 +157,6 @@ static int int3496_probe(struct platform_device *pdev)return ret; } -/* queue initial processing of id-pin */ -queue_delayed_work (system_wq, &data->work,0 ); -platform_set_drvdata (pdev, data);return 0 ;
Signature · 1 line
2.14.3
Quoted 8 lines · Hans de Goede
Some other drivers may be waiting for our extcon to show-up (exiting their probe methods with -EPROBE_DEFER until we show up).
These drivers will typically get the cable state directly after getting the extcon, this commit changes the int3496 code to process the id-pin before registering the extcon, so that other drivers see the correct state right away.
Quoted 6 lines
Fixes 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI ... driver")Signed-off-by Hans de Goede <[email protected]>--- drivers/extcon/extcon-intel-int3496.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
Applied it. Thanks.
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Chanwoo Choi
maintainerQuoted 9 lines · Chanwoo Choi
Quoted 8 lines · Hans de Goede
Some other drivers may be waiting for our extcon to show-up (exiting their probe methods with -EPROBE_DEFER until we show up).
These drivers will typically get the cable state directly after getting the extcon, this commit changes the int3496 code to process the id-pin before registering the extcon, so that other drivers see the correct state right away.
Quoted 9 lines
Quoted 6 lines
Fixes 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI ... driver")Signed-off-by Hans de Goede <[email protected]>--- drivers/extcon/extcon-intel-int3496.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)Applied it. Thanks.
This patch had the bug reported by Hans.
Please ignore what I applied patch.
I don't apply it and I'll wait v3 patch.
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics