net/ipv6: Handle reject routes with onlink flag
Subsystems (3)
PATCH 1/1 net/ipv6: Handle reject routes with onlink flag
Verification of nexthops with onlink flag need to handle unreachable routes. The lookup is only intended to validate the gateway address is not a local address and if the gateway resolves the egress device must match the given device. Hence, hitting any default reject route is ok.
Fixes fc1e64e1092f ("net/ipv6: Add support for onlink flag")
Signed-off-by David Ahern <[email protected]>
--- net/ipv6/route.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/ipv6/route.c +2 -1
@@ -2488,7 +2488,8 @@ static int ip6_route_check_nh_onlink(struct net *net, err =0 ; grt =ip6_nh_lookup_table (net, cfg, gw_addr, tbid,0 );if (grt) { -if (grt->rt6i_flags & flags || dev != grt->dst.dev) { +if (!grt->dst.error && + (grt->rt6i_flags & flags || dev != grt->dst.dev)) {NL_SET_ERR_MSG (extack,"Nexthop has invalid gateway" ); err = -EINVAL ; }
Signature · 1 line
2.11.0
From: David Ahern <[email protected]>
Date: Tue, 6 Feb 2018 12:14:12 -0800
Quoted 8 lines
Verification of nexthops with onlink flag need to handle unreachable routes. The lookup is only intended to validate the gateway address is not a local address and if the gateway resolves the egress device must match the given device. Hence, hitting any default reject route is ok.
Fixes fc1e64e1092f ("net/ipv6: Add support for onlink flag")Signed-off-by David Ahern <[email protected]>
Applied.