Skip to contentSkip to conversation

support/dependencies: add check for c++ multilib

PATCH New Gaël PORTAY 3 participants 4 messages Feb 5, 2018 – Feb 7, 2018

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 support/dependencies: add check for c++ multilib

Some packages build C++ 32bits host-tools and need the g++-multilib to be installed on the build machine. As example, qt5webengine builds a C++ host-tool when target is 32bits.

Add the check for g++-multilib to the dependencies script; and update the Dockerfile to install g++-multilib package.

---

There are two solutions to solve this issue:

The first one consists in checking for g++-multilib when the config option BR2_HOSTARCH_NEEDS_IA32_COMPILER is set; even if it is not required. The implementation is simple (see patch below).

The second solution consists in creating a new config option for packages that needs g++-multilib to be installed. As example:
BR2_HOSTARCH_NEEDS_IA32_CXX_COMPILER is a good candidate. [For a matter of consistency, I would also rename BR2_HOSTARCH_NEEDS_COMPILER into BR2_HOSTARCH_NEEDS_IA32_C_COMPILER (adding C_); but I do not want to do that to not break existing configurations that are no in-tree].

Which solution do you prefer?

Change since v1:
- Use proper c++ value for option -x (cpp does not exist).
- Use g++ compiler instead of gcc.

 support/dependencies/dependencies.sh | 8 ++++++++
 support/docker/Dockerfile            | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
support/dependencies/dependencies.sh +8 -0
index a195c62c8c..1804e85508 100755
@@ -249,6 +249,14 @@ if grep -q ^BR2_HOSTARCH_NEEDS_IA32_COMPILER=y $BR2_CONFIG ; then
 		echo "For other distributions, refer to their documentation."
 		exit 1
 	fi
+
+	if ! echo "int main(void) {}" | g++ -m32 -x c++ - -o /dev/null 2>/dev/null; then
+		echo
+		echo "Your Buildroot configuration needs a compiler capable of building 32 bits binaries."
+		echo "If you're running a Debian/Ubuntu distribution, install the g++-multilib package."
+		echo "For other distributions, refer to their documentation."
+		exit 1
+	fi
 fi
 
 # Check that the Perl installation is complete enough for Buildroot.
support/docker/Dockerfile +1 -1
index 474e073c61..ce3fdd9cc2 100644
@@ -22,7 +22,7 @@ COPY apt-sources.list /etc/apt/sources.list
 RUN dpkg --add-architecture i386 && \
     apt-get update -y && \
     apt-get install -y --no-install-recommends \
-        build-essential cmake libc6:i386 gcc-multilib \
+        build-essential cmake libc6:i386 g++-multilib \
         bc ca-certificates file locales rsync \
         cvs bzr git mercurial subversion wget \
         cpio unzip \
Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 1/1 support/dependencies: add check for c++ multilib

Hello,

Quoted 9 lines · Ga?l PORTAY

Some packages build C++ 32bits host-tools and need the g++-multilib to be installed on the build machine. As example, qt5webengine builds a C++ host-tool when target is 32bits.

Add the check for g++-multilib to the dependencies script; and update the Dockerfile to install g++-multilib package.

---

Applied to master, thanks. Both Arnout and I thought that it was not really worth having a separate option for this, as it would hardly be tested. So the approach you have submitted looked good enough to us.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 support/dependencies: add check for c++ multilib

In reply to Gaël PORTAY

Ga?l, All,

On 2018-02-05 16:57 -0500, Ga?l PORTAY spake thusly:

Quoted 8 lines

Some packages build C++ 32bits host-tools and need the g++-multilib to be installed on the build machine. As example, qt5webengine builds a C++ host-tool when target is 32bits.

Add the check for g++-multilib to the dependencies script; and update the Dockerfile to install g++-multilib package.

So, this patch was applied, but there is some second-thoughts about it, especially since not al our autobuilders have g++-multilib for now...

But my concern so far is just about the Dockerfile, see below...

support/docker/Dockerfile COPY apt-sources.list /etc/apt/sources.list · line 28

Quoted 13 lines
support/docker/Dockerfile +1 -1
index 474e073c61..ce3fdd9cc2 100644
@@ -22,7 +22,7 @@ COPY apt-sources.list /etc/apt/sources.list
 RUN dpkg --add-architecture i386 && \
     apt-get update -y && \
     apt-get install -y --no-install-recommends \
-        build-essential cmake libc6:i386 gcc-multilib \
+        build-essential cmake libc6:i386 g++-multilib \
         bc ca-certificates file locales rsync \
         cvs bzr git mercurial subversion wget \
         cpio unzip \

So, we should not confuse the Dockerfile for what it is not: it is not meant for user consumption; we never advertised it. Instead, it is only for use by our gitlab-ci based runtime tests. As such, it should only include what is needed in that context.

At least for now.

Maybe we will want to make it ready for public consumption later, but it is not for now.

As such, I don't think we should have updated the dockerfile in the same patch. Afterall, it is not a mandatory dependency; it is needed (as far as I can understand) only for qt5webengine.

There are ther optional dependencies that are not in the dockerfile. For example, we do not have a jave compiler, which is needed by a few packages in Buildroot, but which are for now not tested by the gitlab-ci jobs.

So, I would suggest we retract this change in the Dockerfile...

Thoughts from others? Arnout, Thomas, Peter?

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH v2 1/1 support/dependencies: add check for c++ multilib

Yann,

Quoted 36 lines · Yann E. MORIN

Ga?l, All,

On 2018-02-05 16:57 -0500, Ga?l PORTAY spake thusly:

Quoted 8 lines

Some packages build C++ 32bits host-tools and need the g++-multilib to be installed on the build machine. As example, qt5webengine builds a C++ host-tool when target is 32bits.

Add the check for g++-multilib to the dependencies script; and update the Dockerfile to install g++-multilib package.

So, this patch was applied, but there is some second-thoughts about it, especially since not al our autobuilders have g++-multilib for now...

But my concern so far is just about the Dockerfile, see below...

support/docker/Dockerfile COPY apt-sources.list /etc/apt/sources.list · line 28

Quoted 13 lines
support/docker/Dockerfile +1 -1
index 474e073c61..ce3fdd9cc2 100644
@@ -22,7 +22,7 @@ COPY apt-sources.list /etc/apt/sources.list
 RUN dpkg --add-architecture i386 && \
     apt-get update -y && \
     apt-get install -y --no-install-recommends \
-        build-essential cmake libc6:i386 gcc-multilib \
+        build-essential cmake libc6:i386 g++-multilib \
         bc ca-certificates file locales rsync \
         cvs bzr git mercurial subversion wget \
         cpio unzip \

So, we should not confuse the Dockerfile for what it is not: it is not meant for user consumption; we never advertised it. Instead, it is only for use by our gitlab-ci based runtime tests. As such, it should only include what is needed in that context.

Quoted 2 lines

At least for now.

I understand.

Quoted 3 lines

Maybe we will want to make it ready for public consumption later, but it is not for now.

I am using the Dockerfile for the last 6 months, and it is working great (I am using a script of my own that bind mounts my PWD in the docker and opens a shell where I am able to run make).

Quoted 4 lines

As such, I don't think we should have updated the dockerfile in the same patch. Afterall, it is not a mandatory dependency; it is needed (as far as I can understand) only for qt5webengine.

You are right; I was not aware that it was not an official way to build buildroot images.

Quoted 6 lines

There are ther optional dependencies that are not in the dockerfile. For example, we do not have a jave compiler, which is needed by a few packages in Buildroot, but which are for now not tested by the gitlab-ci jobs.

So, I would suggest we retract this change in the Dockerfile...

I really like to keep it because it is required by qt5webengine and and I am compiling it :) (I know that I can also write by own Dockerfile on top of the prebuild docker image buildroot/base).

My guess is that it is fair to keep the g++-multilib meta package installed in the Docker image as it installs only three additionnal packages (g++-6-multilib, lib32stdc++-6-dev and libx32stdc++-6-dev) for a total of 17.1 MB.

	# apt install g++-multilib
	The following additional packages will be installed:
	  g++-6-multilib lib32stdc++-6-dev libx32stdc++-6-dev
	Suggested packages:
	  lib32stdc++6-6-dbg libx32stdc++6-6-dbg
	The following NEW packages will be installed:
	  g++-6-multilib g++-multilib lib32stdc++-6-dev libx32stdc++-6-dev
	0 upgraded, 4 newly installed, 0 to remove and 1 not upgraded.
	Need to get 1,183 kB of archives.
	After this operation, 17.1 MB of additional disk space will be used.
	Do you want to continue? [Y/n] ^C

As opposed to java compiler that installs 15 additional packages for a total of 107 MB.

	# apt install javacc
	Reading package lists... Done
	Building dependency tree
	Reading state information... Done
	The following additional packages will be installed:
	  ca-certificates-java default-jre-headless fontconfig-config fonts-dejavu-core java-common libavahi-client3 libavahi-common-data libavahi-common3 libcups2 libfontconfig1 libfreetype6 liblcms2-2 libpcsclite1 libxrender1 openjdk-8-jre-headless
	Suggested packages:
	  default-jre javacc-doc cups-common liblcms2-utils pcscd libnss-mdns fonts-dejavu-extra fonts-ipafont-gothic fonts-ipafont-mincho fonts-wqy-microhei fonts-wqy-zenhei fonts-indic
	The following NEW packages will be installed:
	  ca-certificates-java default-jre-headless fontconfig-config fonts-dejavu-core java-common javacc libavahi-client3 libavahi-common-data libavahi-common3 libcups2 libfontconfig1 libfreetype6 liblcms2-2 libpcsclite1 libxrender1 openjdk-8-jre-headless
	0 upgraded, 16 newly installed, 0 to remove and 1 not upgraded.
	Need to get 30.3 MB of archives.
	After this operation, 107 MB of additional disk space will be used.
	Do you want to continue? [Y/n] ^C
Quoted 2 lines

Thoughts from others? Arnout, Thomas, Peter?

BTW, I think we can reconsidering using prebuild Docker images for developpers.

Quoted 11 lines

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Regards,
Gael