Skip to contentSkip to conversation

x86/PCI: VMD: Fix malformed Kconfig default

PATCH Applied Ulf Magnusson 3 participants 6 messages Feb 6, 2018 – Feb 23, 2018 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v2 20/20 x86/PCI: VMD: Fix malformed Kconfig default

'default N' should be 'default n', though they happen to have the same effect here, due to undefined symbols (N in this case) evaluating to n in a tristate sense.

Remove the default instead of changing it. bool and tristate symbols implicitly default to n.

Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.

---
Changes in v2:
Make it clear that Kconfig is involved.

 drivers/pci/host/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/host/Kconfig +0 -1
index a4ed7484d127..dc8a2a175f19 100644
@@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
 config VMD
 	depends on PCI_MSI && X86_64 && SRCU
 	tristate "Intel Volume Management Device Driver"
-	default N
 	---help---
 	  Adds support for the Intel Volume Management Device (VMD). VMD is a
 	  secondary PCI host bridge that allows PCI Express root ports,
Signature · 1 line
2.14.1
Acked-by on v2 20/20
#2 lore raw
Quoted 6 lines · Ulf Magnusson

'default N' should be 'default n', though they happen to have the same effect here, due to undefined symbols (N in this case) evaluating to n in a tristate sense.

Remove the default instead of changing it. bool and tristate symbols implicitly default to n.

s/bool/Bool/

Quoted 5 lines

Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.

Since only this patch was posted to linux-pci, I assume it will be merged via some other tree.

Quoted 22 lines

---
Changes in v2:
Make it clear that Kconfig is involved.

 drivers/pci/host/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/host/Kconfig +0 -1
index a4ed7484d127..dc8a2a175f19 100644
@@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
 config VMD
 	depends on PCI_MSI && X86_64 && SRCU
 	tristate "Intel Volume Management Device Driver"
-	default N
 	---help---
 	  Adds support for the Intel Volume Management Device (VMD). VMD is a
 	  secondary PCI host bridge that allows PCI Express root ports,
Signature · 1 line
2.14.1
#3 lore raw
Quoted 9 lines · Bjorn Helgaas
Quoted 6 lines · Ulf Magnusson

'default N' should be 'default n', though they happen to have the same effect here, due to undefined symbols (N in this case) evaluating to n in a tristate sense.

Remove the default instead of changing it. bool and tristate symbols implicitly default to n.

s/bool/Bool/

Not a great excuse, but I was thinking syntactically -- 'bool' and 'tristate' symbols... :)

Quoted 11 lines
Quoted 6 lines

Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.

Since only this patch was posted to linux-pci, I assume it will be merged via some other tree.

I didn't have a particular tree in mind for this patchset. I imagined people would pick up patches into the trees where they make the most sense, and only created the patchset to keep track of the patches more easily. Might have created some confusion in retrospect.

I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the individual patches by the way.

Cheers,
Ulf

#4 lore raw
Quoted 26 lines · Ulf Magnusson
Quoted 9 lines · Bjorn Helgaas
Quoted 6 lines · Ulf Magnusson

'default N' should be 'default n', though they happen to have the same effect here, due to undefined symbols (N in this case) evaluating to n in a tristate sense.

Remove the default instead of changing it. bool and tristate symbols implicitly default to n.

s/bool/Bool/

Not a great excuse, but I was thinking syntactically -- 'bool' and 'tristate' symbols... :)

Quoted 11 lines
Quoted 6 lines

Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.

Since only this patch was posted to linux-pci, I assume it will be merged via some other tree.

Quoted 7 lines

I didn't have a particular tree in mind for this patchset. I imagined people would pick up patches into the trees where they make the most sense, and only created the patchset to keep track of the patches more easily. Might have created some confusion in retrospect.

I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the individual patches by the way.

OK, then either Lorenzo or I will pick it up.

It's in drivers/pci/host/, so ideally Lorenzo will take it since he looks after everything else in there.

Bjorn

#5 lore raw
Quoted 32 lines · Bjorn Helgaas
Quoted 31 lines · Ulf Magnusson
Quoted 9 lines · Bjorn Helgaas
Quoted 6 lines · Ulf Magnusson

'default N' should be 'default n', though they happen to have the same effect here, due to undefined symbols (N in this case) evaluating to n in a tristate sense.

Remove the default instead of changing it. bool and tristate symbols implicitly default to n.

s/bool/Bool/

Not a great excuse, but I was thinking syntactically -- 'bool' and 'tristate' symbols... :)

Quoted 11 lines
Quoted 6 lines

Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.

Since only this patch was posted to linux-pci, I assume it will be merged via some other tree.

I didn't have a particular tree in mind for this patchset. I imagined people would pick up patches into the trees where they make the most sense, and only created the patchset to keep track of the patches more easily. Might have created some confusion in retrospect.

Quoted 7 lines
Quoted 2 lines

I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the individual patches by the way.

OK, then either Lorenzo or I will pick it up.

It's in drivers/pci/host/, so ideally Lorenzo will take it since he looks after everything else in there.

Sure I will take it, thanks.

Lorenzo

#6 lore raw
In reply to Ulf Magnusson
Quoted 10 lines · Ulf Magnusson

'default N' should be 'default n', though they happen to have the same effect here, due to undefined symbols (N in this case) evaluating to n in a tristate sense.

Remove the default instead of changing it. bool and tristate symbols implicitly default to n.

Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.

I have remove this link - it can become stale so I do not think it is worth adding it to the log.

I have also reworded the $SUBJECT.

Applied to pci/host/misc for v4.17, let me know if that's fine for you.

Thanks,
Lorenzo

Quoted 23 lines

---
Changes in v2:
Make it clear that Kconfig is involved.

 drivers/pci/host/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/host/Kconfig +0 -1
index a4ed7484d127..dc8a2a175f19 100644
@@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
 config VMD
 	depends on PCI_MSI && X86_64 && SRCU
 	tristate "Intel Volume Management Device Driver"
-	default N
 	---help---
 	  Adds support for the Intel Volume Management Device (VMD). VMD is a
 	  secondary PCI host bridge that allows PCI Express root ports,
Signature · 1 line
2.14.1