Skip to contentSkip to conversation

drm/amd/powerplay: Remove extra pair of parentheses

PATCH Applied Matthias Kaehlcke 3 participants 3 messages Feb 7, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/powerplay: Remove extra pair of parentheses

The double parentheses are not needed. Removing them fixes the following warning when building with clang:

drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c:419:29:
error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality]
if ((data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2)) {

---
 drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c +1 -1
index 79e5c05571bc..f5b3de29b632 100644
@@ -416,7 +416,7 @@ static int tonga_populate_cac_tables(struct pp_hwmgr *hwmgr,
 			convert_to_vid(vddc_lookup_table->entries[index].us_cac_high);
 	}
 
-	if ((data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2)) {
+	if (data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2) {
 		/* We are populating vddgfx CAC data to BapmVddgfx table in split mode */
 		for (count = 0; count < vddgfx_level_count; count++) {
 			index = phm_get_voltage_index(vddgfx_lookup_table,
Signature · 6 lines
2.16.0.rc1.238.g530d649a79-goog

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Matthias Kaehlcke

The double parentheses are not needed. Removing them fixes the following warning when building with clang:

drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c:419:29:
error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality]
if ((data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2)) {

Quoted 20 lines
---
 drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c +1 -2
index 79e5c05571bc..f5b3de29b632 100644
@@ -416,7 +416,7 @@ static int tonga_populate_cac_tables(struct pp_hwmgr *hwmgr,
                        convert_to_vid(vddc_lookup_table->entries[index].us_cac_high);
        }
 
-       if ((data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2)) {
+       if (data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2) {
                /* We are populating vddgfx CAC data to BapmVddgfx table in split mode */
                for (count = 0; count < vddgfx_level_count; count++) {
                        index = phm_get_voltage_index(vddgfx_lookup_table,
--

2.16.0.rc1.238.g530d649a79-goog

Applied
#2 lore raw
Quoted 4 lines · Guenter Roeck
Quoted 3 lines · Matthias Kaehlcke

The double parentheses are not needed. Removing them fixes the following warning when building with clang:

Quoted 8 lines
Quoted 6 lines

drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c:419:29:
error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality]
if ((data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2)) {

Applied. Thanks!

Alex

Quoted 25 lines
Quoted 19 lines
---
 drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c +1 -2
index 79e5c05571bc..f5b3de29b632 100644
@@ -416,7 +416,7 @@ static int tonga_populate_cac_tables(struct pp_hwmgr *hwmgr,
                        convert_to_vid(vddc_lookup_table->entries[index].us_cac_high);
        }
 
-       if ((data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2)) {
+       if (data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2) {
                /* We are populating vddgfx CAC data to BapmVddgfx table in split mode */
                for (count = 0; count < vddgfx_level_count; count++) {
                        index = phm_get_voltage_index(vddgfx_lookup_table,
--
Quoted 2 lines

2.16.0.rc1.238.g530d649a79-goog

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx