powerpc/via-pmu: Fix section mismatch warning
PATCH 1/1 powerpc/via-pmu: Fix section mismatch warning
Remove the __init annotation from pmu_init() to avoid the following warning.
WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init() The variable via_pmu_driver references
the function __init pmu_init()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
--- drivers/macintosh/via-pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/macintosh/via-pmu.c +1 -1
@@ -378,7 +378,7 @@ static int pmu_probe(void)return vias ==NULL ? -ENODEV :0 ; } -static int __init pmu_init (void ) +static int pmu_init (void ) {if (vias ==NULL )return -ENODEV ;
Signature · 1 line
2.11.0
Quoted 21 lines · Mathieu Malaterre
Remove the
__initannotation frompmu_init()to avoid the following warning.WARNING:
vmlinux.o(.data+0x4739c): Section mismatch in reference from the variablevia_pmu_driverto the function .init.text:pmu_init() The variablevia_pmu_driverreferences
the function__initpmu_init()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoleSigned-off-by Mathieu Malaterre <[email protected]>--- drivers/macintosh/via-pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/macintosh/via-pmu.c +0
-0
drivers/macintosh/via-pmu.c static int pmu_probe(void) · line 384
Quoted 8 lines
drivers/macintosh/via-pmu.c +1
-1@@ -378,7 +378,7 @@ static int pmu_probe(void)return vias ==NULL ? -ENODEV :0 ; } -static int __init pmu_init (void ) +static int pmu_init (void ) {if (vias ==NULL )return -ENODEV ;
pmu_init() is really an init function only called by another init function (adb_init()).
So I think it could be good to let the __init marker.
Did you try:
drivers/macintosh/via-pmu.c +0 -0
@@ -198,7 +198,7 @@ static const struct file_operations
pmu_battery_proc_fops;
static const struct file_operations pmu_options_proc_fops;
#ifdef CONFIG_ADB
-struct adb_driver via_pmu_driver = {
+const struct adb_driver via_pmu_driver = {
"PMU",
pmu_probe,
pmu_init,Thanks,
Laurent
Quoted 49 lines · Laurent Vivier
Quoted 21 lines · Mathieu Malaterre
Remove the
__initannotation frompmu_init()to avoid the following warning.WARNING:
vmlinux.o(.data+0x4739c): Section mismatch in reference from the variablevia_pmu_driverto the function .init.text:pmu_init() The variablevia_pmu_driverreferences
the function__initpmu_init()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoleSigned-off-by Mathieu Malaterre <[email protected]>--- drivers/macintosh/via-pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/macintosh/via-pmu.c +0
-0drivers/macintosh/via-pmu.c static int pmu_probe(void) · line 384
Quoted 8 lines
drivers/macintosh/via-pmu.c +1
-1@@ -378,7 +378,7 @@ static int pmu_probe(void)return vias ==NULL ? -ENODEV :0 ; } -static int __init pmu_init (void ) +static int pmu_init (void ) {if (vias ==NULL )return -ENODEV ;
pmu_init()is really an init function only called by another init function (adb_init()).So I think it could be good to let the
__initmarker.Did you try:
drivers/macintosh/via-pmu.c +1
-1@@ -198,7 +198,7 @@ static const struct file_operations pmu_battery_proc_fops;static const struct file_operations pmu_options_proc_fops;#ifdef CONFIG_ADB -struct adb_driver via_pmu_driver = { +const struct adb_driver via_pmu_driver = {"PMU" , pmu_probe,
Quoted 3 lines
pmu_init,
Indeed much better !
Thanks
PATCH v2 1/1 powerpc/via-pmu: Fix section mismatch warning
In reply to Mathieu MalaterreMake the struct via_pmu_driver const to avoid following warning:
WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init() The variable via_pmu_driver references
the function __init pmu_init()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
---
v2: pmu_init() is really an init function, leave __init marker
drivers/macintosh/via-pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/macintosh/via-pmu.c +1 -1
@@ -198,7 +198,7 @@ static const struct file_operations pmu_battery_proc_fops;static const struct file_operations pmu_options_proc_fops;#ifdef CONFIG_ADB -struct adb_driver via_pmu_driver = { +const struct adb_driver via_pmu_driver = {"PMU" , pmu_probe, pmu_init,
Signature · 1 line
2.11.0
Quoted 23 lines · Mathieu Malaterre
Make the struct
via_pmu_driverconst to avoid following warning:WARNING:
vmlinux.o(.data+0x4739c): Section mismatch in reference from the variablevia_pmu_driverto the function .init.text:pmu_init() The variablevia_pmu_driverreferences
the function__initpmu_init()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoleSigned-off-by Mathieu Malaterre <[email protected]>Suggested-by Laurent Vivier <[email protected]>---
v2:pmu_init()is really an init function, leave__initmarkerdrivers/macintosh/via-pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/macintosh/via-pmu.c +0
-0
drivers/macintosh/via-pmu.c static const struct file_operations pmu_battery_proc_fops; · line 204
Quoted 8 lines
drivers/macintosh/via-pmu.c +1
-1@@ -198,7 +198,7 @@ static const struct file_operations pmu_battery_proc_fops;static const struct file_operations pmu_options_proc_fops;#ifdef CONFIG_ADB -struct adb_driver via_pmu_driver = { +const struct adb_driver via_pmu_driver = {"PMU" , pmu_probe, pmu_init,
Michael Ellerman
AppliedQuoted 9 lines · Mathieu Malaterre
Make the struct
via_pmu_driverconst to avoid following warning:WARNING:
vmlinux.o(.data+0x4739c): Section mismatch in reference from the variablevia_pmu_driverto the function .init.text:pmu_init() The variablevia_pmu_driverreferences
the function__initpmu_init()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_console
Quoted 3 lines
Signed-off-by Mathieu Malaterre <[email protected]>Suggested-by Laurent Vivier <[email protected]>Reviewed-by Laurent Vivier <[email protected]>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/58935176ad17976b7a7f6ea25c0ceb
cheers