binder: replace "%p" with "%pK"
Todd Kjos
maintainerPATCH 1/1 binder: replace "%p" with "%pK"
The format specifier "%p" can leak kernel addresses. Use "%pK" instead. There were 4 remaining cases in binder.c.
Signed-off-by Todd Kjos <[email protected]>
Cc stable <[email protected]>
--- drivers/android/binder.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/android/binder.c +4 -4
@@ -2141,7 +2141,7 @@ static void binder_transaction_buffer_release(struct binder_proc *proc,int debug_id = buffer->debug_id;binder_debug (BINDER_DEBUG_TRANSACTION , -"%d buffer release %d, size %zd-%zd, failed at %p\n" , +"%d buffer release %d, size %zd-%zd, failed at %pK\n" , proc->pid, buffer->debug_id, buffer->data_size, buffer->offsets_size, failed_at);
@@ -3653,7 +3653,7 @@ static int binder_thread_write(struct binder_proc *proc, } }binder_debug (BINDER_DEBUG_DEAD_BINDER , -"%d:%d BC_DEAD_BINDER_DONE %016llx found %p\n" , +"%d:%d BC_DEAD_BINDER_DONE %016llx found %pK\n" , proc->pid, thread->pid, (u64 )cookie, death);if (death ==NULL ) {
@@ -4968,7 +4968,7 @@ static void print_binder_transaction_ilocked(struct seq_file *m,spin_lock (&t->lock); to_proc = t->to_proc; seq_printf(m, - "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d", + "%s %d: %pK from %d:%d to %d:%d code %x flags %x pri %ld r%d", prefix, t->debug_id, t, t->from ? t->from->proc->pid : 0, t->from ? t->from->pid : 0,
@@ -4992,7 +4992,7 @@ static void print_binder_transaction_ilocked(struct seq_file *m, }if (buffer->target_node)seq_printf (m," node %d" , buffer->target_node->debug_id); -seq_printf (m," size %zd:%zd data %p\n" , +seq_printf (m," size %zd:%zd data %pK\n" , buffer->data_size, buffer->offsets_size, buffer->data); }
Signature · 1 line
2.16.0.rc1.238.g530d649a79-goog
Greg KH
maintainerQuoted 2 lines · Todd Kjos
The format specifier "%p" can leak kernel addresses. Use "%pK" instead. There were 4 remaining cases in
binder.c.
Luckily this isn't an issue in mainline as we don't print %p values out anymore as of 4.15. That being said, this is a good fix and I'll queue it up after 4.16-rc1 is out, thanks.
greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel