Skip to contentSkip to conversation

package/openssh: also install ssh-copy-id script

PATCH New julien.boibessot at free.fr 3 participants 5 messages Feb 7, 2018 – Feb 8, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/openssh: also install ssh-copy-id script

From: Julien BOIBESSOT <[email protected]>

This script is useful to copy SSH keys between client and server [1] and installed on most distributions (for example on debian: [2]).

[1] https://www.ssh.com/ssh/copy-id
[2] https://packages.debian.org/fr/jessie/armhf/openssh-client/filelist

package/openssh/openssh.mk +6 -0
index 6b7ac22..b0075e9 100644
@@ -73,4 +73,10 @@ define OPENSSH_INSTALL_INIT_SYSV
 		$(TARGET_DIR)/etc/init.d/S50sshd
 endef
 
+define OPENSSH_INSTALL_SSH_COPY_ID
+	$(INSTALL) -D -m 755 $(@D)/contrib/ssh-copy-id $(TARGET_DIR)/usr/bin
+endef
+
+OPENSSH_POST_INSTALL_TARGET_HOOKS += OPENSSH_INSTALL_SSH_COPY_ID
+
 $(eval $(autotools-package))
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 package/openssh: also install ssh-copy-id script

Julien, All,

On 2018-02-07 19:35 +0100, julien.boibessot at free.fr spake thusly:

Quoted 15 lines

From: Julien BOIBESSOT <[email protected]>

This script is useful to copy SSH keys between client and server [1] and installed on most distributions (for example on debian: [2]).

[1] https://www.ssh.com/ssh/copy-id
[2] https://packages.debian.org/fr/jessie/armhf/openssh-client/filelist

package/openssh/openssh.mk +0 -0
index 6b7ac22..b0075e9 100644

package/openssh/openssh.mk define OPENSSH_INSTALL_INIT_SYSV · line 77

Quoted 5 lines
package/openssh/openssh.mk +2 -0
@@ -73,4 +73,10 @@ define OPENSSH_INSTALL_INIT_SYSV
 		$(TARGET_DIR)/etc/init.d/S50sshd
 endef
 
+define OPENSSH_INSTALL_SSH_COPY_ID
+	$(INSTALL) -D -m 755 $(@D)/contrib/ssh-copy-id $(TARGET_DIR)/usr/bin

Usually, we write the full mode, i.e. 0755 (but the tree is mixed: 371 iterations of '0755', but only 116 for '0755').

Regards,
Yann E. MORIN.

Quoted 12 lines
package/openssh/openssh.mk +4 -0
+endef
+
+OPENSSH_POST_INSTALL_TARGET_HOOKS += OPENSSH_INSTALL_SSH_COPY_ID
+
 $(eval $(autotools-package))
Signature · 6 lines
2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/openssh: also install ssh-copy-id script

Hello Yann,

thanks for reviewing,

Quoted 21 lines · Yann E. MORIN

Julien, All,

On 2018-02-07 19:35 +0100, julien.boibessot at free.fr spake thusly:

Quoted 18 lines

From: Julien BOIBESSOT <[email protected]>

This script is useful to copy SSH keys between client and server [1] and installed on most distributions (for example on debian: [2]).

[1] https://www.ssh.com/ssh/copy-id
[2] https://packages.debian.org/fr/jessie/armhf/openssh-client/filelist

package/openssh/openssh.mk +0 -0
index 6b7ac22..b0075e9 100644
@@ -73,4 +73,10 @@ define OPENSSH_INSTALL_INIT_SYSV
 		$(TARGET_DIR)/etc/init.d/S50sshd
 endef
 
Quoted 4 lines

package/openssh/openssh.mk define OPENSSH_INSTALL_INIT_SYSV · line 77

Quoted 2 lines
package/openssh/openssh.mk +2 -0
+define OPENSSH_INSTALL_SSH_COPY_ID
+	$(INSTALL) -D -m 755 $(@D)/contrib/ssh-copy-id $(TARGET_DIR)/usr/bin

Usually, we write the full mode, i.e. 0755 (but the tree is mixed: 371 iterations of '0755', but only 116 for '0755').

Well, in fact, I just copy-pasted what was done line 44 of the same makefile.
O:-)

Regards,
Julien

#3 lore raw

PATCH 1/1 package/openssh: also install ssh-copy-id script

Julien, All,

On 2018-02-08 11:28 +0100, Julien Boibessot spake thusly:

Quoted 23 lines · Yann E. MORIN
Quoted 21 lines

Julien, All,

On 2018-02-07 19:35 +0100, julien.boibessot at free.fr spake thusly:

Quoted 18 lines

From: Julien BOIBESSOT <[email protected]>

This script is useful to copy SSH keys between client and server [1] and installed on most distributions (for example on debian: [2]).

[1] https://www.ssh.com/ssh/copy-id
[2] https://packages.debian.org/fr/jessie/armhf/openssh-client/filelist

package/openssh/openssh.mk +0 -0
index 6b7ac22..b0075e9 100644
@@ -73,4 +73,10 @@ define OPENSSH_INSTALL_INIT_SYSV
 		$(TARGET_DIR)/etc/init.d/S50sshd
 endef
 
Quoted 7 lines
Quoted 4 lines

package/openssh/openssh.mk define OPENSSH_INSTALL_INIT_SYSV · line 77

Quoted 2 lines
package/openssh/openssh.mk +2 -0
+define OPENSSH_INSTALL_SSH_COPY_ID
+	$(INSTALL) -D -m 755 $(@D)/contrib/ssh-copy-id $(TARGET_DIR)/usr/bin

Usually, we write the full mode, i.e. 0755 (but the tree is mixed: 371 iterations of '0755', but only 116 for '0755').

Well, in fact, I just copy-pasted what was done line 44 of the same makefile.

Then, intra-file consistency wins. ;-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 package/openssh: also install ssh-copy-id script

In reply to julien.boibessot at free.fr

Hello,

package/openssh/openssh.mk define OPENSSH_INSTALL_INIT_SYSV · line 77

Quoted 2 lines · julien.boibessot at free.fr
package/openssh/openssh.mk +2 -0
+define OPENSSH_INSTALL_SSH_COPY_ID
+	$(INSTALL) -D -m 755 $(@D)/contrib/ssh-copy-id $(TARGET_DIR)/usr/bin

$(INSTALL) -D requires a full destination path, i.e $(TARGET_DIR)/usr/bin/ssh-copy-id, to be guaranteed to work correctly when $(TARGET_DIR)/usr/bin doesn't exist. So I've fixed that and applied to next. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com