Kconfig: Select networking commands only when NET is enabled
PATCH v2 1/1 Kconfig: Select networking commands only when NET is enabled
There is no reason to unconditially select network commands as distro defaults without networking enable.
---
Changes in v2:
- Use if NET instead of imply (suggested by Tom)
- Change patch subject and description
Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Kconfig +4 -4
@@ -69,14 +69,14 @@ config DISTRO_DEFAULTS imply USE_BOOTCOMMAND select CMD_BOOTZ if ARM && !ARM64 select CMD_BOOTI if ARM64 - select CMD_DHCP - select CMD_PXE + select CMD_DHCP if NET + select CMD_PXE if NET select CMD_EXT2 select CMD_EXT4 select CMD_FAT select CMD_FS_GENERIC - select CMD_MII - select CMD_PING + select CMD_MII if NET + select CMD_PING if NET select CMD_PART select HUSH_PARSER help
Signature · 1 line
1.9.1
PATCH v2 1/1 Kconfig: Select networking commands only when NET is enabled
Hi Lokesh,
Quoted 27 lines · Michal Simek
There is no reason to unconditially select network commands as distro defaults without networking enable.
Signed-off-by Michal Simek <[email protected]>---
Changes in v2:
- Use if NET instead of imply (suggested by Tom)
- Change patch subject and descriptionKconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)Kconfig +2
-2@@ -69,14 +69,14 @@ config DISTRO_DEFAULTS imply USE_BOOTCOMMAND select CMD_BOOTZ if ARM && !ARM64 select CMD_BOOTI if ARM64 - select CMD_DHCP - select CMD_PXE + select CMD_DHCP if NET + select CMD_PXE if NET select CMD_EXT2
Kconfig config DISTRO_DEFAULTS · line 82
Quoted 10 lines
Kconfig +2
-2select CMD_EXT4 select CMD_FAT select CMD_FS_GENERIC - select CMD_MII - select CMD_PING + select CMD_MII if NET + select CMD_PING if NET select CMD_PART select HUSH_PARSER help
Based on
https://travis-ci.org/michalsimek/u-boot/jobs/338051973
Lokesh:
There is an issue with omap4_sdp4430_defconfig where CONFIG_NET is not enabled but PXE and DHCP configs are present.
This is quite weird and IMHO CONFIG_NET should be enabled for this target. This can be one resolution.
(quoted diff) +0 -0
b/configs/omap4_sdp4430_defconfig
index ac495710633c..59526fd1dc35 100644
configs/omap4_sdp4430_defconfig +5 -0
@@ -23,7 +23,10 @@ CONFIG_CMD_SPI=y # CONFIG_CMD_NET is not set # CONFIG_CMD_NFS is not set CONFIG_CMD_EXT4_WRITE=y +# CONFIG_EFI_PARTITION is not set +CONFIG_SPL_PARTITION_UUIDS=y CONFIG_ENV_IS_IN_MMC=y +CONFIG_NET=y CONFIG_MMC_OMAP_HS=y CONFIG_SYS_NS16550=y CONFIG_OMAP3_SPI=y
@@ -31,4 +34,6 @@ CONFIG_USB=y CONFIG_USB_MUSB_UDC=y CONFIG_USB_OMAP3=y CONFIG_FAT_WRITE=y +# CONFIG_REGEX is not set CONFIG_OF_LIBFDT=y +# CONFIG_EFI_LOADER is not set
Thanks,
Michal
Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180207/dd0a7410/attachment.sig>
PATCH v2 1/1 Kconfig: Select networking commands only when NET is enabled
Hi Michal,
Quoted 44 lines · Michal Simek
Hi Lokesh,
Quoted 27 lines · Michal Simek
There is no reason to unconditially select network commands as distro defaults without networking enable.
Signed-off-by Michal Simek <[email protected]>---
Changes in v2:
- Use if NET instead of imply (suggested by Tom)
- Change patch subject and descriptionKconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)Kconfig +2
-2@@ -69,14 +69,14 @@ config DISTRO_DEFAULTS imply USE_BOOTCOMMAND select CMD_BOOTZ if ARM && !ARM64 select CMD_BOOTI if ARM64 - select CMD_DHCP - select CMD_PXE + select CMD_DHCP if NET + select CMD_PXE if NET select CMD_EXT2Kconfig config DISTRO_DEFAULTS · line 82
Quoted 10 lines
Kconfig +2
-2select CMD_EXT4 select CMD_FAT select CMD_FS_GENERIC - select CMD_MII - select CMD_PING + select CMD_MII if NET + select CMD_PING if NET select CMD_PART select HUSH_PARSER helpBased on
https://travis-ci.org/michalsimek/u-boot/jobs/338051973
Quoted 5 lines
Lokesh:
There is an issue withomap4_sdp4430_defconfigwhereCONFIG_NETis not enabled but PXE and DHCP configs are present.
This is quite weird and IMHOCONFIG_NETshould be enabled for this target. This can be one resolution.
Yeah, resolution looks good to me. Tom, any comments?
Quoted 18 lines
configs/omap4_sdp4430_defconfig +3
-0@@ -23,7 +23,10 @@ CONFIG_CMD_SPI=y # CONFIG_CMD_NET is not set # CONFIG_CMD_NFS is not set CONFIG_CMD_EXT4_WRITE=y +# CONFIG_EFI_PARTITION is not set +CONFIG_SPL_PARTITION_UUIDS=y CONFIG_ENV_IS_IN_MMC=y +CONFIG_NET=y CONFIG_MMC_OMAP_HS=y CONFIG_SYS_NS16550=y CONFIG_OMAP3_SPI=y
configs/omap4_sdp4430_defconfig CONFIG_USB=y · line 39
Quoted 6 lines
configs/omap4_sdp4430_defconfig +2
-0@@ -31,4 +34,6 @@ CONFIG_USB=y CONFIG_USB_MUSB_UDC=y CONFIG_USB_OMAP3=y CONFIG_FAT_WRITE=y +# CONFIG_REGEX is not set CONFIG_OF_LIBFDT=y +# CONFIG_EFI_LOADER is not set
Thanks and regards,
Lokesh
Quoted 6 lines
Thanks,
Michal
PATCH v2 1/1 Kconfig: Select networking commands only when NET is enabled
Quoted 47 lines · Lokesh Vutla
Hi Michal,
Quoted 44 lines · Michal Simek
Hi Lokesh,
Quoted 27 lines · Michal Simek
There is no reason to unconditially select network commands as distro defaults without networking enable.
Signed-off-by Michal Simek <[email protected]>---
Changes in v2:
- Use if NET instead of imply (suggested by Tom)
- Change patch subject and descriptionKconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)Kconfig +2
-2@@ -69,14 +69,14 @@ config DISTRO_DEFAULTS imply USE_BOOTCOMMAND select CMD_BOOTZ if ARM && !ARM64 select CMD_BOOTI if ARM64 - select CMD_DHCP - select CMD_PXE + select CMD_DHCP if NET + select CMD_PXE if NET select CMD_EXT2Kconfig config DISTRO_DEFAULTS · line 82
Quoted 10 lines
Kconfig +2
-2select CMD_EXT4 select CMD_FAT select CMD_FS_GENERIC - select CMD_MII - select CMD_PING + select CMD_MII if NET + select CMD_PING if NET select CMD_PART select HUSH_PARSER helpBased on
https://travis-ci.org/michalsimek/u-boot/jobs/338051973
Quoted 7 lines
Quoted 5 lines
Lokesh:
There is an issue withomap4_sdp4430_defconfigwhereCONFIG_NETis not enabled but PXE and DHCP configs are present.
This is quite weird and IMHOCONFIG_NETshould be enabled for this target. This can be one resolution.Yeah, resolution looks good to me. Tom, any comments?
ok. I have sent a patch and feel free to comment there.
Thanks,
Michal
PATCH v2 1/1 Kconfig: Select networking commands only when NET is enabled
In reply to Michal SimekQuoted 4 lines · Michal Simek
There is no reason to unconditially select network commands as distro defaults without networking enable.
Signed-off-by Michal Simek <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom