ipt_CLUSTERIP: fix a refcount bug in clusterip_config_find_get()
Subsystems (3)
PATCH v2 1/1 ipt_CLUSTERIP: fix a refcount bug in clusterip_config_find_get()
In clusterip_config_find_get() we hold RCU read lock so it could run concurrently with clusterip_config_entry_put(), as a result, the refcnt could go back to 1 from 0, which leads to a double list_del()... Just replace refcount_inc() with refcount_inc_not_zero(), as for c->refcount.
--- net/ipv4/netfilter/ipt_CLUSTERIP.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
net/ipv4/netfilter/ipt_CLUSTERIP.c +6 -2
@@ -154,8 +154,12 @@ clusterip_config_find_get(struct net *net, __be32 clusterip, int entry)#endif if (unlikely (!refcount_inc_not_zero (&c->refcount))) c =NULL ; -else if (entry) -refcount_inc (&c->entries); +else if (entry) { +if (unlikely (!refcount_inc_not_zero (&c->entries))) { +clusterip_config_put (c); + c =NULL ; + } + } }rcu_read_unlock_bh ();
Signature · 1 line
2.13.0
Quoted 5 lines · Cong Wang
In
clusterip_config_find_get()we hold RCU read lock so it could run concurrently withclusterip_config_entry_put(), as a result, the refcnt could go back to 1 from 0, which leads to a doublelist_del()... Just replacerefcount_inc()withrefcount_inc_not_zero(), as forc->refcount.
Quoted 5 lines · Cong Wang
In
clusterip_config_find_get()we hold RCU read lock so it could run concurrently withclusterip_config_entry_put(), as a result, the refcnt could go back to 1 from 0, which leads to a doublelist_del()... Just replacerefcount_inc()withrefcount_inc_not_zero(), as forc->refcount.
Applied, thanks Cong.