ltp-testsuite: add numactl as optional dependency
PATCH 1/1 ltp-testsuite: add numactl as optional dependency
Make the detection of libnuma in the configure script consistent when the numactl package is enabled.
ltp-testsuite does not currently take explicit enable/disable for libnuma, so none are used. The next ltp-testsuite version will add these options.
--- package/ltp-testsuite/ltp-testsuite.mk | 7 +++++++ 1 file changed, 7 insertions(+)
package/ltp-testsuite/ltp-testsuite.mk +7 -0
@@ -40,6 +40,13 @@ else LTP_TESTSUITE_CONF_ENV += ac_cv_lib_cap_cap_compare=no endif +# No explicit enable/disable options +ifeq ($(BR2_PACKAGE_NUMACTL),y) +LTP_TESTSUITE_DEPENDENCIES += numactl +else +LTP_TESTSUITE_CONF_ENV += have_numa_headers=no +endif + # ltp-testsuite uses <fts.h>, which isn't compatible with largefile # support. LTP_TESTSUITE_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
Signature · 1 line
2.15.1
PATCH 1/1 ltp-testsuite: add numactl as optional dependency
Hi Baruch,
Quoted 21 lines
Make the detection of libnuma in the configure script consistent when the numactl package is enabled.
ltp-testsuite does not currently take explicit enable/disable for libnuma, so none are used. The next ltp-testsuite version will add these options.
Cc Petr Vorel <[email protected]>Signed-off-by Baruch Siach <[email protected]>--- package/ltp-testsuite/ltp-testsuite.mk | 7 +++++++ 1 file changed, 7 insertions(+)package/ltp-testsuite/ltp-testsuite.mk +0
-0@@ -40,6 +40,13 @@ else LTP_TESTSUITE_CONF_ENV += ac_cv_lib_cap_cap_compare=no endif
package/ltp-testsuite/ltp-testsuite.mk else · line 52
Quoted 10 lines
package/ltp-testsuite/ltp-testsuite.mk +7
-0+# No explicit enable/disable options +ifeq ($(BR2_PACKAGE_NUMACTL),y) +LTP_TESTSUITE_DEPENDENCIES += numactl +else +LTP_TESTSUITE_CONF_ENV += have_numa_headers=no +endif + # ltp-testsuite uses <fts.h>, which isn't compatible with largefile # support. LTP_TESTSUITE_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
Thanks for implementing it, LGTM.
I just think whether it wouldn't be better to create config option BR2_PACKAGE_LTP_TESTSUITE_LIBNUMA which would select numactl (this would also inform user about this dependency).
Kind regards,
Petr
PATCH 1/1 ltp-testsuite: add numactl as optional dependency
Quoted 22 lines · Petr Vorel
Hi Baruch,
Quoted 20 lines
Make the detection of libnuma in the configure script consistent when the numactl package is enabled.
ltp-testsuite does not currently take explicit enable/disable for libnuma, so none are used. The next ltp-testsuite version will add these options.
Cc Petr Vorel <[email protected]>Signed-off-by Baruch Siach <[email protected]>--- package/ltp-testsuite/ltp-testsuite.mk | 7 +++++++ 1 file changed, 7 insertions(+)package/ltp-testsuite/ltp-testsuite.mk +0
-0@@ -40,6 +40,13 @@ else LTP_TESTSUITE_CONF_ENV += ac_cv_lib_cap_cap_compare=no endif
Quoted 14 lines
package/ltp-testsuite/ltp-testsuite.mk else · line 52
Quoted 10 lines
package/ltp-testsuite/ltp-testsuite.mk +7
-0+# No explicit enable/disable options +ifeq ($(BR2_PACKAGE_NUMACTL),y) +LTP_TESTSUITE_DEPENDENCIES += numactl +else +LTP_TESTSUITE_CONF_ENV += have_numa_headers=no +endif + # ltp-testsuite uses <fts.h>, which isn't compatible with largefile # support. LTP_TESTSUITE_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))Thanks for implementing it, LGTM.
I just think whether it wouldn't be better to create config optionBR2_PACKAGE_LTP_TESTSUITE_LIBNUMAwhich would select numactl (this would also inform user about this dependency).
We generally don't do that unless there is a very good reason, to avoid
proliferation of Config.in options. In this case, I don't see a very good reason.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 ltp-testsuite: add numactl as optional dependency
Hi Arnout,
<snip>
Quoted 15 lines
Quoted 6 lines
Quoted 6 lines
package/ltp-testsuite/ltp-testsuite.mk +6
-0+# No explicit enable/disable options +ifeq ($(BR2_PACKAGE_NUMACTL),y) +LTP_TESTSUITE_DEPENDENCIES += numactl +else +LTP_TESTSUITE_CONF_ENV += have_numa_headers=no +endifQuoted 8 lines
Quoted 4 lines
+
# ltp-testsuite uses <fts.h>, which isn't compatible with largefile # support. LTP_TESTSUITE_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))Thanks for implementing it, LGTM.
I just think whether it wouldn't be better to create config optionBR2_PACKAGE_LTP_TESTSUITE_LIBNUMAwhich would select numactl (this would also inform user about this dependency).
Quoted 2 lines
We generally don't do that unless there is a very good reason, to avoid
proliferation of Config.in options. In this case, I don't see a very good reason.
OK, thanks for info.
Yesterday we added --without-numa config option to properly disable and there will probably be some more as people demand it. So I thought it would be good for people to be able to choose.
Kind regards,
Petr
Thomas Petazzoni
AppliedPATCH 1/1 ltp-testsuite: add numactl as optional dependency
In reply to Baruch SiachHello,
Quoted 7 lines · Baruch Siach
Make the detection of libnuma in the configure script consistent when the numactl package is enabled.
ltp-testsuite does not currently take explicit enable/disable for libnuma, so none are used. The next ltp-testsuite version will add these options.
Quoted 5 lines
Cc Petr Vorel <[email protected]>Signed-off-by Baruch Siach <[email protected]>--- package/ltp-testsuite/ltp-testsuite.mk | 7 +++++++ 1 file changed, 7 insertions(+)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com