Skip to contentSkip to conversation

doc: update ethdev APIs to return named opaque type

PATCH Superseded Ferruh Yigit 5 participants 6 messages Feb 9, 2018 – Feb 14, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: update ethdev APIs to return named opaque type

Ethdev APIs to add callback return the callback object as "void *", update return type to actual object type
"struct rte_eth_rxtx_callback *"

---
Cc: Konstantin Ananyev <[email protected]>
Cc: Stephen Hemminger <[email protected]>
Cc: Bruce Richardson <[email protected]>
Cc: Thomas Monjalon <[email protected]>

---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)
doc/guides/rel_notes/deprecation.rst +7 -0
index bbd9456a7..b6479cd5a 100644
@@ -49,6 +49,13 @@ Deprecation Notices
   rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be
   uint16_t.
 
+* ethdev: add rx/tx callback functions return named opaque type
+  rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and
+  rte_eth_add_tx_callback() functions currently return "void * " but APIs to
+  delete callbacks get "struct rte_eth_rxtx_callback * " as parameter. For
+  consistency functions adding callback will return "struct rte_eth_rxtx_callback * "
+  instead of "void * ".
+
 * i40e: The default flexible payload configuration which extracts the first 16
   bytes of the payload for RSS will be deprecated starting from 18.02. If
   required the previous behavior can be configured using existing flow
Signature · 1 line
2.14.3
#1 lore raw

PATCH v2 1/1 doc: update ethdev APIs to return named opaque type

Ethdev APIs to add callback return the callback object as "void *", update return type to actual object type
"struct rte_eth_rxtx_callback *"

---
Cc: Konstantin Ananyev <[email protected]>
Cc: Stephen Hemminger <[email protected]>
Cc: Bruce Richardson <[email protected]>
Cc: Thomas Monjalon <[email protected]>

---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)
doc/guides/rel_notes/deprecation.rst +7 -0
index bbd9456a7..5cb5a00d2 100644
@@ -49,6 +49,13 @@ Deprecation Notices
   rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be
   uint16_t.
 
+* ethdev: functions add rx/tx callback will return named opaque type
+  rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and
+  rte_eth_add_tx_callback() functions currently return callback object as
+  "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*"
+  as parameter. For consistency functions adding callback will return
+  "struct rte_eth_rxtx_callback \*" instead of "void * ".
+
 * i40e: The default flexible payload configuration which extracts the first 16
   bytes of the payload for RSS will be deprecated starting from 18.02. If
   required the previous behavior can be configured using existing flow
Signature · 1 line
2.14.3
Acked-by on v2 1/1
#2 lore raw
Quoted 34 lines

-----Original Message-----
From: Yigit, Ferruh
Sent: Friday, February 9, 2018 10:18 AM
To: Neil Horman <[email protected]>; Mcnamara, John <[email protected]>; Kovacevic, Marko <[email protected]>
Cc: [email protected]; Yigit, Ferruh <[email protected]>; Ananyev, Konstantin <[email protected]>; Stephen Hemminger <[email protected]>; Richardson, Bruce <[email protected]>; Thomas Monjalon <[email protected]>
Subject: [PATCH v2] doc: update ethdev APIs to return named opaque type

Ethdev APIs to add callback return the callback object as "void *", update return type to actual object type
"struct rte_eth_rxtx_callback *"

---
Cc: Konstantin Ananyev <[email protected]>
Cc: Stephen Hemminger <[email protected]>
Cc: Bruce Richardson <[email protected]>
Cc: Thomas Monjalon <[email protected]>

---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)
doc/guides/rel_notes/deprecation.rst +1 -0
index bbd9456a7..5cb5a00d2 100644
@@ -49,6 +49,13 @@ Deprecation Notices
   rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be
   uint16_t.
 
+* ethdev: functions add rx/tx callback will return named opaque type

doc/guides/rel_notes/deprecation.rst Deprecation Notices

Quoted 10 lines
doc/guides/rel_notes/deprecation.rst +6 -1
+  rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and
+  rte_eth_add_tx_callback() functions currently return callback object as
+  "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*"
+  as parameter. For consistency functions adding callback will return
+  "struct rte_eth_rxtx_callback \*" instead of "void * ".
+
 * i40e: The default flexible payload configuration which extracts the first 16
   bytes of the payload for RSS will be deprecated starting from 18.02. If
   required the previous behavior can be configured using existing flow
--
Quoted 1 line

2.14.3

Acked-by
#3 lore raw

-----Original Message-----

Quoted 44 lines

Date: Fri, 9 Feb 2018 13:22:06 +0000
From: "Ananyev, Konstantin" <[email protected]>
To: "Yigit, Ferruh" <[email protected]>, Neil Horman
<[email protected]>, "Mcnamara, John" <[email protected]>, "Kovacevic, Marko" <[email protected]>
CC: "[email protected]" <[email protected]>, Stephen Hemminger
<[email protected]>, "Richardson, Bruce" <[email protected]>, Thomas Monjalon <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named
opaque type

Quoted 31 lines

-----Original Message-----
From: Yigit, Ferruh
Sent: Friday, February 9, 2018 10:18 AM
To: Neil Horman <[email protected]>; Mcnamara, John <[email protected]>; Kovacevic, Marko <[email protected]>
Cc: [email protected]; Yigit, Ferruh <[email protected]>; Ananyev, Konstantin <[email protected]>; Stephen Hemminger <[email protected]>; Richardson, Bruce <[email protected]>; Thomas Monjalon <[email protected]>
Subject: [PATCH v2] doc: update ethdev APIs to return named opaque type

Ethdev APIs to add callback return the callback object as "void *", update return type to actual object type
"struct rte_eth_rxtx_callback *"

---
Cc: Konstantin Ananyev <[email protected]>
Cc: Stephen Hemminger <[email protected]>
Cc: Bruce Richardson <[email protected]>
Cc: Thomas Monjalon <[email protected]>

---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index bbd9456a7..5cb5a00d2 100644
@@ -49,6 +49,13 @@ Deprecation Notices
   rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be
   uint16_t.
 
Quoted 13 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices

Quoted 11 lines
doc/guides/rel_notes/deprecation.rst +7 -1
+* ethdev: functions add rx/tx callback will return named opaque type
+  rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and
+  rte_eth_add_tx_callback() functions currently return callback object as
+  "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*"
+  as parameter. For consistency functions adding callback will return
+  "struct rte_eth_rxtx_callback \*" instead of "void * ".
+
 * i40e: The default flexible payload configuration which extracts the first 16
   bytes of the payload for RSS will be deprecated starting from 18.02. If
   required the previous behavior can be configured using existing flow
--
Quoted 3 lines
Quoted 2 lines

2.14.3

#4 lore raw
Quoted 45 lines · Jerin Jacob
Quoted 31 lines
Quoted 31 lines

-----Original Message-----
From: Yigit, Ferruh
Sent: Friday, February 9, 2018 10:18 AM
To: Neil Horman <[email protected]>; Mcnamara, John <[email protected]>; Kovacevic, Marko <[email protected]>
Cc: [email protected]; Yigit, Ferruh <[email protected]>; Ananyev, Konstantin <[email protected]>; Stephen Hemminger <[email protected]>; Richardson, Bruce <[email protected]>; Thomas Monjalon <[email protected]>
Subject: [PATCH v2] doc: update ethdev APIs to return named opaque type

Ethdev APIs to add callback return the callback object as "void *", update return type to actual object type
"struct rte_eth_rxtx_callback *"

---
Cc: Konstantin Ananyev <[email protected]>
Cc: Stephen Hemminger <[email protected]>
Cc: Bruce Richardson <[email protected]>
Cc: Thomas Monjalon <[email protected]>

---
  doc/guides/rel_notes/deprecation.rst | 7 +++++++
  1 file changed, 7 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index bbd9456a7..5cb5a00d2 100644
@@ -49,6 +49,13 @@ Deprecation Notices
    rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be
    uint16_t.
 
Quoted 13 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices

Quoted 11 lines
doc/guides/rel_notes/deprecation.rst +7 -1
+* ethdev: functions add rx/tx callback will return named opaque type
+  rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and
+  rte_eth_add_tx_callback() functions currently return callback object as
+  "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*"
+  as parameter. For consistency functions adding callback will return
+  "struct rte_eth_rxtx_callback \*" instead of "void * ".
+
  * i40e: The default flexible payload configuration which extracts the first 16
    bytes of the payload for RSS will be deprecated starting from 18.02. If
    required the previous behavior can be configured using existing flow
--
Quoted 3 lines
Quoted 1 line
#5 lore raw
Quoted 20 lines
Quoted 20 lines
Quoted 19 lines
Quoted 7 lines

Ethdev APIs to add callback return the callback object as "void *", update return type to actual object type
"struct rte_eth_rxtx_callback *"

---

doc/guides/rel_notes/deprecation.rst +1 -0
+* ethdev: functions add rx/tx callback will return named opaque type

doc/guides/rel_notes/deprecation.rst Deprecation Notices

Quoted 10 lines
doc/guides/rel_notes/deprecation.rst +6 -1
+  rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and
+  rte_eth_add_tx_callback() functions currently return callback object as
+  "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*"
+  as parameter. For consistency functions adding callback will return
+  "struct rte_eth_rxtx_callback \*" instead of "void * ".
+
  * i40e: The default flexible payload configuration which extracts the first 16
    bytes of the payload for RSS will be deprecated starting from 18.02. If
    required the previous behavior can be configured using existing flow
--
Quoted 3 lines
Quoted 2 lines

Applied