unit/test-ecc: Fix uninitialised values
Luiz Augusto von Dentz
maintainerPATCH 1/1 unit/test-ecc: Fix uninitialised values
From: Luiz Augusto von Dentz <[email protected]>
Conditional jump or move depends on uninitialised value(s)
at 0x40208C: test_sample (test-ecc.c:106)
by 0x4022AB: test_invalid_pub (test-ecc.c:272)
by 0x406DA2: run_callback (tester.c:415)
by 0x4E83576: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
by 0x4E86B76: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x4E86F1F: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
by 0x4E87231: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x408245: tester_run (tester.c:830)
by 0x401CC3: main (test-ecc.c:291)
Conditional jump or move depends on uninitialised value(s)
at 0x4020D6: test_sample (test-ecc.c:113)
by 0x4022AB: test_invalid_pub (test-ecc.c:272)
by 0x406DA2: run_callback (tester.c:415)
by 0x4E83576: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
by 0x4E86B76: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x4E86F1F: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
by 0x4E87231: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.5400.3) by 0x408245: tester_run (tester.c:830)
by 0x401CC3: main (test-ecc.c:291)
--- unit/test-ecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
unit/test-ecc.c +1 -1
@@ -91,7 +91,7 @@ static int test_sample(uint8_t priv_a[32], uint8_t priv_b[32], uint8_t pub_a[64], uint8_t pub_b[64], uint8_t dhkey[32]) { - uint8_t dhkey_a[32], dhkey_b[32]; + uint8_t dhkey_a[32] = {}, dhkey_b[32] = {};int fails =0 ;ecdh_shared_secret (pub_b, priv_a, dhkey_a);
Signature · 1 line
2.14.3
Marcel Holtmann
maintainerHi Luiz,
Quoted 30 lines
Conditional jump or move depends on uninitialised value(s)
at0x40208C:test_sample(test-ecc.c:106)
by0x4022AB:test_invalid_pub(test-ecc.c:272)
by0x406DA2:run_callback(tester.c:415)
by0x4E83576: ??? (in/usr/lib64/libglib-2.0.so.0.5400.3)
by0x4E86B76:g_main_context_dispatch(in/usr/lib64/libglib-2.0.so.0.5400.3) by0x4E86F1F: ??? (in/usr/lib64/libglib-2.0.so.0.5400.3)
by0x4E87231:g_main_loop_run(in/usr/lib64/libglib-2.0.so.0.5400.3) by0x408245:tester_run(tester.c:830)
by0x401CC3: main (test-ecc.c:291)Conditional jump or move depends on uninitialised value(s)
at0x4020D6:test_sample(test-ecc.c:113)
by0x4022AB:test_invalid_pub(test-ecc.c:272)
by0x406DA2:run_callback(tester.c:415)
by0x4E83576: ??? (in/usr/lib64/libglib-2.0.so.0.5400.3)
by0x4E86B76:g_main_context_dispatch(in/usr/lib64/libglib-2.0.so.0.5400.3) by0x4E86F1F: ??? (in/usr/lib64/libglib-2.0.so.0.5400.3)
by0x4E87231:g_main_loop_run(in/usr/lib64/libglib-2.0.so.0.5400.3) by0x408245:tester_run(tester.c:830)
by0x401CC3: main (test-ecc.c:291)
---unit/test-ecc.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)unit/test-ecc.c +0
-0
unit/test-ecc.c static int test_sample(uint8_t priv_a[32], uint8_t priv_b[32], · line 95
Quoted 6 lines
unit/test-ecc.c +1
-1@@ -91,7 +91,7 @@ static int test_sample(uint8_t priv_a[32], uint8_t priv_b[32], uint8_t pub_a[64], uint8_t pub_b[64], uint8_t dhkey[32]) { - uint8_t dhkey_a[32], dhkey_b[32]; + uint8_t dhkey_a[32] = {}, dhkey_b[32] = {};int fails =0 ;
does an explicit memset also fixes this?
Regards
Marcel
Luiz Augusto von Dentz
maintainerHi,
Quoted 27 lines · Marcel Holtmann
Hi Luiz,
Quoted 25 lines
Conditional jump or move depends on uninitialised value(s)
at0x40208C:test_sample(test-ecc.c:106)
by0x4022AB:test_invalid_pub(test-ecc.c:272)
by0x406DA2:run_callback(tester.c:415)
by0x4E83576: ??? (in/usr/lib64/libglib-2.0.so.0.5400.3)
by0x4E86B76:g_main_context_dispatch(in/usr/lib64/libglib-2.0.so.0.5400.3) by0x4E86F1F: ??? (in/usr/lib64/libglib-2.0.so.0.5400.3)
by0x4E87231:g_main_loop_run(in/usr/lib64/libglib-2.0.so.0.5400.3) by0x408245:tester_run(tester.c:830)
by0x401CC3: main (test-ecc.c:291)Conditional jump or move depends on uninitialised value(s)
at0x4020D6:test_sample(test-ecc.c:113)
by0x4022AB:test_invalid_pub(test-ecc.c:272)
by0x406DA2:run_callback(tester.c:415)
by0x4E83576: ??? (in/usr/lib64/libglib-2.0.so.0.5400.3)
by0x4E86B76:g_main_context_dispatch(in/usr/lib64/libglib-2.0.so.0.5400.3) by0x4E86F1F: ??? (in/usr/lib64/libglib-2.0.so.0.5400.3)
by0x4E87231:g_main_loop_run(in/usr/lib64/libglib-2.0.so.0.5400.3) by0x408245:tester_run(tester.c:830)
by0x401CC3: main (test-ecc.c:291)
---unit/test-ecc.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines
unit/test-ecc.c static int test_sample(uint8_t priv_a[32], uint8_t priv_b[32], · line 95
Quoted 11 lines
unit/test-ecc.c +1
-1@@ -91,7 +91,7 @@ static int test_sample(uint8_t priv_a[32], uint8_t priv_b[32], uint8_t pub_a[64], uint8_t pub_b[64], uint8_t dhkey[32]) { - uint8_t dhkey_a[32], dhkey_b[32]; + uint8_t dhkey_a[32] = {}, dhkey_b[32] = {};int fails =0 ;does an explicit memset also fixes this?
Applied after changing it to use memsets.
Signature · 1 line
Luiz Augusto von Dentz