drm/i915: Fix incorrect comment
Subsystems (2)
PATCH 1/1 drm/i915: Fix incorrect comment
While the comment singles out Port A or B, the code says Port A or *D*. Looking at the history it seems that the comment was added after the code, so it seems likely that the code is correct, not the comment.
--- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dp.c +1 -1
@@ -258,7 +258,7 @@ static int cnl_max_source_rate(struct intel_dp *intel_dp)if (IS_CNL_WITH_PORT_F (dev_priv))return 810000 ; -/* For other SKUs, max rate on ports A and B is 5.4G */ +/* For other SKUs, max rate on ports A and D is 5.4G */ if (port ==PORT_A || port ==PORT_D )return 540000 ;
Signature · 6 lines
2.16.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Fix incorrect comment
== Series Details ==
== Series Details ==
Series: drm/i915: Fix incorrect comment
URL : https://patchwork.freedesktop.org/series/38002/
State : success
== Summary ==
Series 38002v1 drm/i915: Fix incorrect comment
https://patchwork.freedesktop.org/api/1.0/series/38002/revisions/1/mbox/
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
fail -> PASS (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
pass -> FAIL (fi-skl-guc) fdo#103191
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (fi-bdw-5557u) fdo#104162fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104162 https://bugs.freedesktop.org/show_bug.cgi?id=104162
fi-bdw-5557u total:246 pass:228 dwarn:0 dfail:0 fail:0 skip:17 fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:432s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:379s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:488s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:285s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:478s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:486s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:470s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:454s fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:572s fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:581s fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:419s fi-gdg-551 total:288 pass:180 dwarn:0 dfail:0 fail:0 skip:108 time:285s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:513s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:388s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:413s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:461s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:415s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:456s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:493s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:499s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:600s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:428s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:506s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:526s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:484s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:485s fi-skl-guc total:288 pass:259 dwarn:0 dfail:0 fail:1 skip:28 time:414s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:429s fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:401s
Blacklisted hosts:
fi-glk-dsi total:288 pass:238 dwarn:1 dfail:4 fail:0 skip:45 time:464s
6c10ba221576c523e2574d83e75a87cdc7b0bc1e drm-tip: 2018y-02m-08d-19h-13m-44s UTC integration manifest aed622a8213b drm/i915: Fix incorrect comment
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7968/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for drm/i915: Fix incorrect comment
In reply to David Weinehall== Series Details ==
== Series Details ==
Series: drm/i915: Fix incorrect comment
URL : https://patchwork.freedesktop.org/series/38002/
State : warning
== Summary ==
Test gem_exec_suspend:
Subgroup basic-s4:
fail -> SKIP (shard-snb) fdo#103375
Test gem_eio:
Subgroup in-flight:
pass -> FAIL (shard-hsw) fdo#104676
Test kms_cursor_crc:
Subgroup cursor-64x64-offscreen:
pass -> SKIP (shard-apl)
Subgroup cursor-64x64-suspend:
pass -> FAIL (shard-snb) fdo#102365
Test kms_cursor_legacy:
Subgroup cursor-vs-flip-legacy:
fail -> PASS (shard-apl) fdo#103355
Test kms_sysfs_edid_timing:
pass -> WARN (shard-apl) fdo#100047
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-apl) fdo#99912
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
fail -> PASS (shard-apl) fdo#101623
Test kms_flip:
Subgroup flip-vs-expired-vblank-interruptible:
fail -> PASS (shard-hsw) fdo#102887fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#104676 https://bugs.freedesktop.org/show_bug.cgi?id=104676
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
shard-apl total:3354 pass:1736 dwarn:1 dfail:0 fail:20 skip:1595 time:12327s shard-hsw total:3444 pass:1760 dwarn:1 dfail:0 fail:11 skip:1671 time:11754s shard-snb total:3444 pass:1350 dwarn:1 dfail:0 fail:10 skip:2083 time:6549s
Blacklisted hosts:
shard-kbl total:3380 pass:1859 dwarn:19 dfail:0 fail:20 skip:1481 time:9437s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7968/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · David Weinehall
While the comment singles out Port A or B, the code says Port A or *D*. Looking at the history it seems that the comment was added after the code, so it seems likely that the code is correct, not the comment.
CC Jani Nikula <[email protected]>CC Rodrigo Vivi <[email protected]>Signed-off-by David Weinehall <[email protected]>
Matches my read of BSpec.
Quoted 24 lines
--- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dp.c +1
-1@@ -258,7 +258,7 @@ static int cnl_max_source_rate(struct intel_dp *intel_dp)if (IS_CNL_WITH_PORT_F (dev_priv))return 810000 ; -/* For other SKUs, max rate on ports A and B is 5.4G */ +/* For other SKUs, max rate on ports A and D is 5.4G */ if (port ==PORT_A || port ==PORT_D )return 540000 ;Signature · 6 lines
2.16.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · James Ausmus
Quoted 4 lines · David Weinehall
While the comment singles out Port A or B, the code says Port A or *D*. Looking at the history it seems that the comment was added after the code, so it seems likely that the code is correct, not the comment.
Quoted 7 lines
Quoted 3 lines
CC Jani Nikula <[email protected]>CC Rodrigo Vivi <[email protected]>Signed-off-by David Weinehall <[email protected]>Matches my read of BSpec.
Reviewed-by James Ausmus <[email protected]>
Thanks for patch and review.
merged to dinq.
Quoted 18 lines
Quoted 18 lines
--- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dp.c +1
-1@@ -258,7 +258,7 @@ static int cnl_max_source_rate(struct intel_dp *intel_dp)if (IS_CNL_WITH_PORT_F (dev_priv))return 810000 ; -/* For other SKUs, max rate on ports A and B is 5.4G */ +/* For other SKUs, max rate on ports A and D is 5.4G */ if (port ==PORT_A || port ==PORT_D )return 540000 ;
Quoted 7 lines
Quoted 7 lines
Signature · 6 lines
2.16.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx