Skip to contentSkip to conversation

ARM: dts: am437x-idk: Configure uart0 padconf wakeirq

PATCH In review Tony Lindgren 2 participants 3 messages Feb 9, 2018 – Feb 12, 2018 2 messages not in the archive Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: am437x-idk: Configure uart0 padconf wakeirq

We can use CTRL_CONF_UART0_RXD pad as the wakeirq and then the serial console will work with wake up events.

Note that the uart still needs to be configured for idle timeouts for PM runtime for the wakeirq to get activated. That can be done via sysfs to set autosuspend_delay_ms to 3000, wakeup enabled and and control auto.

---
 arch/arm/boot/dts/am437x-idk-evm.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/am437x-idk-evm.dts +6 -0
@@ -533,3 +533,9 @@
 		opp-suspend;
 	};
 };
+
+&uart0 {
+	/* UART0 interrupt and CTRL_CONF_UART0_RXD pad as wakeirq */
+	interrupts-extended = <&gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+			      <&am43xx_pinmux 0x170>;
+};
Signature · 5 lines
2.16.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20180209161913.19542-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org

#2 lore raw

Hi,

Quoted 19 lines · Tony Lindgren

We can use CTRL_CONF_UART0_RXD pad as the wakeirq and then the serial console will work with wake up events.

Note that the uart still needs to be configured for idle timeouts for PM runtime for the wakeirq to get activated. That can be done via sysfs to set autosuspend_delay_ms to 3000, wakeup enabled and and control auto.

---
 arch/arm/boot/dts/am437x-idk-evm.dts | 6 ++++++

 1 file changed, 6 insertions(+)

arch/arm/boot/dts/am437x-idk-evm.dts line 541

Quoted 9 lines
arch/arm/boot/dts/am437x-idk-evm.dts +6 -0
@@ -533,3 +533,9 @@
                  opp-suspend;
          };
  };
+
+&uart0 {
+       /* UART0 interrupt and CTRL_CONF_UART0_RXD pad as wakeirq */
+       interrupts-extended = <&gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+                             <&am43xx_pinmux 0x170>;
+};

As per Section 6.4.5 Wakeup Sources/Events AM437x TRM, UART0 is in Wakeup Power domain and can wakeup the system directly. AFAIK, there is no need to use CTRL_CONF_UART0_RXD pad as the wakeirq.

Signature · 6 lines
Regards
Vignesh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): b5fba201-a1ad-9192-27a6-f7d8d5bc6a40-l0cyMroinI0@public.gmane.org

#4 lore raw
Quoted 27 lines · Vignesh R

Hi,

Quoted 24 lines · Tony Lindgren

We can use CTRL_CONF_UART0_RXD pad as the wakeirq and then the serial console will work with wake up events.

Note that the uart still needs to be configured for idle timeouts for PM runtime for the wakeirq to get activated. That can be done via sysfs to set autosuspend_delay_ms to 3000, wakeup enabled and and control auto.

---
 arch/arm/boot/dts/am437x-idk-evm.dts | 6 ++++++

 1 file changed, 6 insertions(+)
arch/arm/boot/dts/am437x-idk-evm.dts +2 -0
@@ -533,3 +533,9 @@
                  opp-suspend;
          };
  };
+
+&uart0 {
Quoted 8 lines

arch/arm/boot/dts/am437x-idk-evm.dts line 541

Quoted 4 lines
arch/arm/boot/dts/am437x-idk-evm.dts +4 -0
+       /* UART0 interrupt and CTRL_CONF_UART0_RXD pad as wakeirq */
+       interrupts-extended = <&gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+                             <&am43xx_pinmux 0x170>;
+};

As per Section 6.4.5 Wakeup Sources/Events AM437x TRM, UART0 is in Wakeup Power domain and can wakeup the system directly. AFAIK, there is no need to use CTRL_CONF_UART0_RXD pad as the wakeirq.

OK, let's wait a bit on this until we can test suspend resume with Dave's patches. I think this is still needed for runtime PM as the UART is not able to wake up if it's configured for autosuspend_delay_ms, or to wake up the system from suspend if the UART is suspended.. But maybe you're right and the 8250 internal wake-up can be used in this case :)

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html