Skip to contentSkip to conversation

staging: vt6656: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning

PATCH In review Dileep Sankhla 2 participants 3 messages Feb 10, 2018 – Feb 12, 2018 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vt6656: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning

---
 drivers/staging/vt6656/usbpipe.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/vt6656/usbpipe.c +0 -3
index 273176386a51..5bbc56f8779e 100644
@@ -194,9 +194,6 @@ static void vnt_submit_rx_urb_complete(struct urb *urb)
 		if (vnt_rx_data(priv, rcb, urb->actual_length)) {
 			rcb->skb = dev_alloc_skb(priv->rx_buf_sz);
 			if (!rcb->skb) {
-				dev_dbg(&priv->usb->dev,
-					"Failed to re-alloc rx skb\n");
-
 				rcb->in_use = false;
 				return;
 			}
Signature · 1 line
2.15.1
#2 lore raw

PATCH v2 1/1 staging: vt6656: Remove unnecessary 'out of memory' message

This patch removes the unnecessary out of memory message fixing the following checkpatch.pl warning in usbpipe.c:
WARNING: Possible unnecessary 'out of memory' message

---
Change in v2:
- changed commit message

---
 drivers/staging/vt6656/usbpipe.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/vt6656/usbpipe.c +0 -3
index 273176386a51..5bbc56f8779e 100644
@@ -194,9 +194,6 @@ static void vnt_submit_rx_urb_complete(struct urb *urb)
 		if (vnt_rx_data(priv, rcb, urb->actual_length)) {
 			rcb->skb = dev_alloc_skb(priv->rx_buf_sz);
 			if (!rcb->skb) {
-				dev_dbg(&priv->usb->dev,
-					"Failed to re-alloc rx skb\n");
-
 				rcb->in_use = false;
 				return;
 			}
Signature · 6 lines
2.15.1

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel