net: phy: fix wrong mask to phy_modify()
Subsystems (3)
PATCH 1/1 net: phy: fix wrong mask to phy_modify()
When forcing a specific link mode, the PHY driver must clear the existing speed and duplex bits in BMCR while preserving some other control bits. This logic was accidentally inverted with the introduction of phy_modify().
--- drivers/net/phy/phy_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/phy_device.c +1 -1
@@ -1382,7 +1382,7 @@ int genphy_setup_forced(struct phy_device *phydev) ctl |=BMCR_FULLDPLX ;return phy_modify (phydev,MII_BMCR , -BMCR_LOOPBACK |BMCR_ISOLATE |BMCR_PDOWN , ctl); + ~(BMCR_LOOPBACK |BMCR_ISOLATE |BMCR_PDOWN ), ctl); }EXPORT_SYMBOL (genphy_setup_forced);
Signature · 1 line
2.14.3
Quoted 6 lines · Ingo van Lil
When forcing a specific link mode, the PHY driver must clear the existing speed and duplex bits in BMCR while preserving some other control bits. This logic was accidentally inverted with the introduction of
phy_modify().Signed-off-by Ingo van Lil <[email protected]>
Andrew
David Miller
maintainerFrom: Ingo van Lil <[email protected]>
Date: Mon, 12 Feb 2018 12:02:52 +0100
Quoted 6 lines
When forcing a specific link mode, the PHY driver must clear the existing speed and duplex bits in BMCR while preserving some other control bits. This logic was accidentally inverted with the introduction of
phy_modify().Signed-off-by Ingo van Lil <[email protected]>
Applied and queued up for -stable.