media: rc: replace IR_dprintk() with dev_dbg in IR decoders
Subsystems (2)
Sean Young
maintainerPATCH 1/5 media: rc: replace IR_dprintk() with dev_dbg in IR decoders
Use dev_dbg() rather than custom debug function.
Signed-off-by Sean Young <[email protected]>
--- drivers/media/rc/ir-jvc-decoder.c | 14 ++++---- drivers/media/rc/ir-mce_kbd-decoder.c | 60 ++++++++++++++++++----------------- drivers/media/rc/ir-nec-decoder.c | 20 ++++++------ drivers/media/rc/ir-rc5-decoder.c | 12 +++---- drivers/media/rc/ir-rc6-decoder.c | 26 +++++++-------- drivers/media/rc/ir-sanyo-decoder.c | 18 +++++------ drivers/media/rc/ir-sharp-decoder.c | 17 +++++----- drivers/media/rc/ir-sony-decoder.c | 14 ++++---- drivers/media/rc/ir-xmp-decoder.c | 29 +++++++++-------- 9 files changed, 106 insertions(+), 104 deletions(-)
drivers/media/rc/ir-jvc-decoder.c +7 -7
@@ -56,8 +56,8 @@ static int ir_jvc_decode(struct rc_dev *dev, struct ir_raw_event ev)if (!geq_margin (ev.duration,JVC_UNIT ,JVC_UNIT /2 )) goto out; -IR_dprintk (2 ,"JVC decode started at state %d (%uus %s)\n" , - data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"JVC decode started at state %d (%uus %s)\n" , + data->state,TO_US (ev.duration),TO_STR (ev.pulse)); again:switch (data->state) {
@@ -136,15 +136,15 @@ static int ir_jvc_decode(struct rc_dev *dev, struct ir_raw_event ev)u32 scancode; scancode = (bitrev8 ((data->bits >>8 ) &0xff ) <<8 ) | (bitrev8 ((data->bits >>0 ) &0xff ) <<0 ); -IR_dprintk (1 ,"JVC scancode 0x%04x\n" , scancode); +dev_dbg (&dev->dev,"JVC scancode 0x%04x\n" , scancode);rc_keydown (dev,RC_PROTO_JVC , scancode, data->toggle); data->first = false; data->old_bits = data->bits; }else if (data->bits == data->old_bits) { -IR_dprintk (1 ,"JVC repeat\n" ); +dev_dbg (&dev->dev,"JVC repeat\n" );rc_repeat (dev); }else { -IR_dprintk (1 ,"JVC invalid repeat msg\n" ); +dev_dbg (&dev->dev,"JVC invalid repeat msg\n" );break ; }
@@ -164,8 +164,8 @@ static int ir_jvc_decode(struct rc_dev *dev, struct ir_raw_event ev) } out: -IR_dprintk (1 ,"JVC decode failed at state %d (%uus %s)\n" , - data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"JVC decode failed at state %d (%uus %s)\n" , + data->state,TO_US (ev.duration),TO_STR (ev.pulse)); data->state =STATE_INACTIVE ;return -EINVAL ; }
drivers/media/rc/ir-mce_kbd-decoder.c +31 -29
148 lines not on this page · raw message
drivers/media/rc/ir-nec-decoder.c +9 -11
@@ -49,8 +49,8 @@ static int ir_nec_decode(struct rc_dev *dev, struct ir_raw_event ev)return 0 ; } -IR_dprintk (2 ,"NEC decode started at state %d (%uus %s)\n" , - data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"NEC decode started at state %d (%uus %s)\n" , + data->state,TO_US (ev.duration),TO_STR (ev.pulse));switch (data->state) {
@@ -99,13 +99,11 @@ static int ir_nec_decode(struct rc_dev *dev, struct ir_raw_event ev)break ;if (data->necx_repeat && data->count ==NECX_REPEAT_BITS && -geq_margin (ev.duration, -NEC_TRAILER_SPACE ,NEC_UNIT /2 )) { -IR_dprintk (1 ,"Repeat last key\n" ); -rc_repeat (dev); - data->state =STATE_INACTIVE ; -return 0 ; - +geq_margin (ev.duration,NEC_TRAILER_SPACE ,NEC_UNIT /2 )) { +dev_dbg (&dev->dev,"Repeat last key\n" ); +rc_repeat (dev); + data->state =STATE_INACTIVE ; +return 0 ; }else if (data->count >NECX_REPEAT_BITS ) data->necx_repeat = false;
@@ -164,8 +162,8 @@ static int ir_nec_decode(struct rc_dev *dev, struct ir_raw_event ev)return 0 ; } -IR_dprintk (1 ,"NEC decode failed at count %d state %d (%uus %s)\n" , - data->count, data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"NEC decode failed at count %d state %d (%uus %s)\n" , + data->count, data->state,TO_US (ev.duration),TO_STR (ev.pulse)); data->state =STATE_INACTIVE ;return -EINVAL ; }
drivers/media/rc/ir-rc5-decoder.c +6 -6
@@ -54,8 +54,8 @@ static int ir_rc5_decode(struct rc_dev *dev, struct ir_raw_event ev) goto out; again: -IR_dprintk (2 ,"RC5(x/sz) decode started at state %i (%uus %s)\n" , - data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"RC5(x/sz) decode started at state %i (%uus %s)\n" , + data->state,TO_US (ev.duration),TO_STR (ev.pulse));if (!geq_margin (ev.duration,RC5_UNIT ,RC5_UNIT /2 ))return 0 ;
@@ -154,8 +154,8 @@ static int ir_rc5_decode(struct rc_dev *dev, struct ir_raw_event ev) }else break ; -IR_dprintk (1 ,"RC5(x/sz) scancode 0x%06x (p: %u, t: %u)\n" , - scancode, protocol, toggle); +dev_dbg (&dev->dev,"RC5(x/sz) scancode 0x%06x (p: %u, t: %u)\n" , + scancode, protocol, toggle);rc_keydown (dev, protocol, scancode, toggle); data->state =STATE_INACTIVE ;
@@ -163,8 +163,8 @@ static int ir_rc5_decode(struct rc_dev *dev, struct ir_raw_event ev) } out: -IR_dprintk (1 ,"RC5(x/sz) decode failed at state %i count %d (%uus %s)\n" , - data->state, data->count,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"RC5(x/sz) decode failed at state %i count %d (%uus %s)\n" , + data->state, data->count,TO_US (ev.duration),TO_STR (ev.pulse)); data->state =STATE_INACTIVE ;return -EINVAL ; }
drivers/media/rc/ir-rc6-decoder.c +13 -13
@@ -100,8 +100,8 @@ static int ir_rc6_decode(struct rc_dev *dev, struct ir_raw_event ev) goto out; again: -IR_dprintk (2 ,"RC6 decode started at state %i (%uus %s)\n" , - data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"RC6 decode started at state %i (%uus %s)\n" , + data->state,TO_US (ev.duration),TO_STR (ev.pulse));if (!geq_margin (ev.duration,RC6_UNIT ,RC6_UNIT /2 ))return 0 ;
@@ -166,7 +166,7 @@ static int ir_rc6_decode(struct rc_dev *dev, struct ir_raw_event ev)break ;if (!(data->header &RC6_STARTBIT_MASK )) { -IR_dprintk (1 ,"RC6 invalid start bit\n" ); +dev_dbg (&dev->dev,"RC6 invalid start bit\n" );break ; }
@@ -183,7 +183,7 @@ static int ir_rc6_decode(struct rc_dev *dev, struct ir_raw_event ev) data->wanted_bits =RC6_6A_NBITS ;break ;default : -IR_dprintk (1 ,"RC6 unknown mode\n" ); +dev_dbg (&dev->dev,"RC6 unknown mode\n" ); goto out; } goto again;
@@ -223,13 +223,13 @@ static int ir_rc6_decode(struct rc_dev *dev, struct ir_raw_event ev) scancode = data->body; toggle = data->toggle; protocol =RC_PROTO_RC6_0 ; -IR_dprintk (1 ,"RC6(0) scancode 0x%04x (toggle: %u)\n" , - scancode, toggle); +dev_dbg (&dev->dev,"RC6(0) scancode 0x%04x (toggle: %u)\n" , + scancode, toggle);break ;case RC6_MODE_6A :if (data->count >CHAR_BIT *sizeof data->body) { -IR_dprintk (1 ,"RC6 too many (%u) data bits\n" , +dev_dbg (&dev->dev,"RC6 too many (%u) data bits\n" , data->count); goto out; }
@@ -255,15 +255,15 @@ static int ir_rc6_decode(struct rc_dev *dev, struct ir_raw_event ev) }break ;default : -IR_dprintk (1 ,"RC6(6A) unsupported length\n" ); +dev_dbg (&dev->dev,"RC6(6A) unsupported length\n" ); goto out; } -IR_dprintk (1 ,"RC6(6A) proto 0x%04x, scancode 0x%08x (toggle: %u)\n" , - protocol, scancode, toggle); +dev_dbg (&dev->dev,"RC6(6A) proto 0x%04x, scancode 0x%08x (toggle: %u)\n" , + protocol, scancode, toggle);break ;default : -IR_dprintk (1 ,"RC6 unknown mode\n" ); +dev_dbg (&dev->dev,"RC6 unknown mode\n" ); goto out; }
@@ -273,8 +273,8 @@ static int ir_rc6_decode(struct rc_dev *dev, struct ir_raw_event ev) } out: -IR_dprintk (1 ,"RC6 decode failed at state %i (%uus %s)\n" , - data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"RC6 decode failed at state %i (%uus %s)\n" , + data->state,TO_US (ev.duration),TO_STR (ev.pulse)); data->state =STATE_INACTIVE ;return -EINVAL ; }
drivers/media/rc/ir-sanyo-decoder.c +9 -9
@@ -52,14 +52,14 @@ static int ir_sanyo_decode(struct rc_dev *dev, struct ir_raw_event ev)if (!is_timing_event (ev)) {if (ev.reset) { -IR_dprintk (1 ,"SANYO event reset received. reset to state 0\n" ); +dev_dbg (&dev->dev,"SANYO event reset received. reset to state 0\n" ); data->state =STATE_INACTIVE ; }return 0 ; } -IR_dprintk (2 ,"SANYO decode started at state %d (%uus %s)\n" , - data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"SANYO decode started at state %d (%uus %s)\n" , + data->state,TO_US (ev.duration),TO_STR (ev.pulse));switch (data->state) {
@@ -102,7 +102,7 @@ static int ir_sanyo_decode(struct rc_dev *dev, struct ir_raw_event ev)if (!data->count &&geq_margin (ev.duration,SANYO_REPEAT_SPACE ,SANYO_UNIT /2 )) {rc_repeat (dev); -IR_dprintk (1 ,"SANYO repeat last key\n" ); +dev_dbg (&dev->dev,"SANYO repeat last key\n" ); data->state =STATE_INACTIVE ;return 0 ; }
@@ -144,21 +144,21 @@ static int ir_sanyo_decode(struct rc_dev *dev, struct ir_raw_event ev) not_command =bitrev8 ((data->bits >>0 ) &0xff );if ((command ^ not_command) !=0xff ) { -IR_dprintk (1 ,"SANYO checksum error: received 0x%08Lx\n" , - data->bits); +dev_dbg (&dev->dev,"SANYO checksum error: received 0x%08llx\n" , + data->bits); data->state =STATE_INACTIVE ;return 0 ; } scancode = address <<8 | command; -IR_dprintk (1 ,"SANYO scancode: 0x%06x\n" , scancode); +dev_dbg (&dev->dev,"SANYO scancode: 0x%06x\n" , scancode);rc_keydown (dev,RC_PROTO_SANYO , scancode,0 ); data->state =STATE_INACTIVE ;return 0 ; } -IR_dprintk (1 ,"SANYO decode failed at count %d state %d (%uus %s)\n" , - data->count, data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"SANYO decode failed at count %d state %d (%uus %s)\n" , + data->count, data->state,TO_US (ev.duration),TO_STR (ev.pulse)); data->state =STATE_INACTIVE ;return -EINVAL ; }
drivers/media/rc/ir-sharp-decoder.c +8 -9
@@ -54,8 +54,8 @@ static int ir_sharp_decode(struct rc_dev *dev, struct ir_raw_event ev)return 0 ; } -IR_dprintk (2 ,"Sharp decode started at state %d (%uus %s)\n" , - data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"Sharp decode started at state %d (%uus %s)\n" , + data->state,TO_US (ev.duration),TO_STR (ev.pulse));switch (data->state) {
@@ -149,9 +149,9 @@ static int ir_sharp_decode(struct rc_dev *dev, struct ir_raw_event ev) msg = (data->bits >>15 ) &0x7fff ; echo = data->bits &0x7fff ;if ((msg ^ echo) !=0x3ff ) { -IR_dprintk (1 , -"Sharp checksum error: received 0x%04x, 0x%04x\n" , - msg, echo); +dev_dbg (&dev->dev, +"Sharp checksum error: received 0x%04x, 0x%04x\n" , + msg, echo);break ; }
@@ -159,16 +159,15 @@ static int ir_sharp_decode(struct rc_dev *dev, struct ir_raw_event ev) command =bitrev8 ((msg >>2 ) &0xff ); scancode = address <<8 | command; -IR_dprintk (1 ,"Sharp scancode 0x%04x\n" , scancode); +dev_dbg (&dev->dev,"Sharp scancode 0x%04x\n" , scancode);rc_keydown (dev,RC_PROTO_SHARP , scancode,0 ); data->state =STATE_INACTIVE ;return 0 ; } -IR_dprintk (1 ,"Sharp decode failed at count %d state %d (%uus %s)\n" , - data->count, data->state,TO_US (ev.duration), -TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"Sharp decode failed at count %d state %d (%uus %s)\n" , + data->count, data->state,TO_US (ev.duration),TO_STR (ev.pulse)); data->state =STATE_INACTIVE ;return -EINVAL ; }
drivers/media/rc/ir-sony-decoder.c +8 -6
@@ -55,8 +55,8 @@ static int ir_sony_decode(struct rc_dev *dev, struct ir_raw_event ev)if (!geq_margin (ev.duration,SONY_UNIT ,SONY_UNIT /2 )) goto out; -IR_dprintk (2 ,"Sony decode started at state %d (%uus %s)\n" , - data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"Sony decode started at state %d (%uus %s)\n" , + data->state,TO_US (ev.duration),TO_STR (ev.pulse));switch (data->state) {
@@ -148,19 +148,21 @@ static int ir_sony_decode(struct rc_dev *dev, struct ir_raw_event ev) protocol =RC_PROTO_SONY20 ;break ;default : -IR_dprintk (1 ,"Sony invalid bitcount %u\n" , data->count); +dev_dbg (&dev->dev,"Sony invalid bitcount %u\n" , + data->count); goto out; } scancode = device <<16 | subdevice <<8 | function; -IR_dprintk (1 ,"Sony(%u) scancode 0x%05x\n" , data->count, scancode); +dev_dbg (&dev->dev,"Sony(%u) scancode 0x%05x\n" , data->count, + scancode);rc_keydown (dev, protocol, scancode,0 ); goto finish_state_machine; } out: -IR_dprintk (1 ,"Sony decode failed at state %d (%uus %s)\n" , - data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"Sony decode failed at state %d (%uus %s)\n" , + data->state,TO_US (ev.duration),TO_STR (ev.pulse)); data->state =STATE_INACTIVE ;return -EINVAL ;
drivers/media/rc/ir-xmp-decoder.c +15 -14
@@ -49,8 +49,8 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)return 0 ; } -IR_dprintk (2 ,"XMP decode started at state %d %d (%uus %s)\n" , - data->state, data->count,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"XMP decode started at state %d %d (%uus %s)\n" , + data->state, data->count,TO_US (ev.duration),TO_STR (ev.pulse));switch (data->state) {
@@ -85,7 +85,7 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)u32 scancode;if (data->count !=16 ) { -IR_dprintk (2 ,"received TRAILER period at index %d: %u\n" , +dev_dbg (&dev->dev,"received TRAILER period at index %d: %u\n" , data->count, ev.duration); data->state =STATE_INACTIVE ;return -EINVAL ;
@@ -99,7 +99,8 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)*/ divider = (n[3 ] -XMP_NIBBLE_PREFIX ) /15 -2000 ;if (divider <50 ) { -IR_dprintk (2 ,"divider to small %d.\n" , divider); +dev_dbg (&dev->dev,"divider to small %d.\n" , + divider); data->state =STATE_INACTIVE ;return -EINVAL ; }
@@ -113,7 +114,7 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev) n[12] + n[13] + n[14] + n[15]) % 16;if (sum1 !=15 || sum2 !=15 ) { -IR_dprintk (2 ,"checksum errors sum1=0x%X sum2=0x%X\n" , +dev_dbg (&dev->dev,"checksum errors sum1=0x%X sum2=0x%X\n" , sum1, sum2); data->state =STATE_INACTIVE ;return -EINVAL ;
@@ -127,24 +128,24 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev) obc1 = n[12 ] <<4 | n[13 ]; obc2 = n[14 ] <<4 | n[15 ];if (subaddr != subaddr2) { -IR_dprintk (2 ,"subaddress nibbles mismatch 0x%02X != 0x%02X\n" , +dev_dbg (&dev->dev,"subaddress nibbles mismatch 0x%02X != 0x%02X\n" , subaddr, subaddr2); data->state =STATE_INACTIVE ;return -EINVAL ; }if (oem !=0x44 ) -IR_dprintk (1 ,"Warning: OEM nibbles 0x%02X. Expected 0x44\n" , +dev_dbg (&dev->dev,"Warning: OEM nibbles 0x%02X. Expected 0x44\n" , oem); scancode = addr <<24 | subaddr <<16 | obc1 <<8 | obc2; -IR_dprintk (1 ,"XMP scancode 0x%06x\n" , scancode); +dev_dbg (&dev->dev,"XMP scancode 0x%06x\n" , scancode);if (toggle ==0 ) {rc_keydown (dev,RC_PROTO_XMP , scancode,0 ); }else {rc_repeat (dev); -IR_dprintk (1 ,"Repeat last key\n" ); +dev_dbg (&dev->dev,"Repeat last key\n" ); } data->state =STATE_INACTIVE ;
@@ -153,7 +154,7 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev) }else if (geq_margin (ev.duration,XMP_HALFFRAME_SPACE ,XMP_NIBBLE_PREFIX )) {/* Expect 8 or 16 nibble pulses. 16 in case of 'final' frame */ if (data->count ==16 ) { -IR_dprintk (2 ,"received half frame pulse at index %d. Probably a final frame key-up event: %u\n" , +dev_dbg (&dev->dev,"received half frame pulse at index %d. Probably a final frame key-up event: %u\n" , data->count, ev.duration);/* * TODO: for now go back to half frame position
@@ -164,7 +165,7 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev) }else if (data->count !=8 ) -IR_dprintk (2 ,"received half frame pulse at index %d: %u\n" , +dev_dbg (&dev->dev,"received half frame pulse at index %d: %u\n" , data->count, ev.duration); data->state =STATE_LEADER_PULSE ;
@@ -173,7 +174,7 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev) }else if (geq_margin (ev.duration,XMP_NIBBLE_PREFIX ,XMP_UNIT )) {/* store nibble raw data, decode after trailer */ if (data->count ==16 ) { -IR_dprintk (2 ,"to many pulses (%d) ignoring: %u\n" , +dev_dbg (&dev->dev,"to many pulses (%d) ignoring: %u\n" , data->count, ev.duration); data->state =STATE_INACTIVE ;return -EINVAL ;
@@ -189,8 +190,8 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)break ; } -IR_dprintk (1 ,"XMP decode failed at count %d state %d (%uus %s)\n" , - data->count, data->state,TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"XMP decode failed at count %d state %d (%uus %s)\n" , + data->count, data->state,TO_US (ev.duration),TO_STR (ev.pulse)); data->state =STATE_INACTIVE ;return -EINVAL ; }
Signature · 1 line
2.14.3
Sean Young
maintainerPATCH 2/5 media: rc: remove IR_dprintk() from rc-core
Use dev_dbg() rather than custom debug function.
Signed-off-by Sean Young <[email protected]>
--- drivers/media/rc/lirc_dev.c | 10 ++--- drivers/media/rc/rc-ir-raw.c | 6 +-- drivers/media/rc/rc-main.c | 91 ++++++++++++++++++++++---------------------- include/media/rc-core.h | 7 ---- 4 files changed, 53 insertions(+), 61 deletions(-)
drivers/media/rc/lirc_dev.c +5 -5
@@ -60,12 +60,12 @@ void ir_lirc_raw_event(struct rc_dev *dev, struct ir_raw_event ev)* space with the maximum time value. */ sample =LIRC_SPACE (LIRC_VALUE_MASK ); -IR_dprintk (2 ,"delivering reset sync space to lirc_dev\n" ); +dev_dbg (&dev->dev,"delivering reset sync space to lirc_dev\n" );/* Carrier reports */ }else if (ev.carrier_report) { sample =LIRC_FREQUENCY (ev.carrier); -IR_dprintk (2 ,"carrier report (freq: %d)\n" , sample); +dev_dbg (&dev->dev,"carrier report (freq: %d)\n" , sample);/* Packet end */ }else if (ev.timeout) {
@@ -77,7 +77,7 @@ void ir_lirc_raw_event(struct rc_dev *dev, struct ir_raw_event ev) dev->gap_duration = ev.duration; sample =LIRC_TIMEOUT (ev.duration /1000 ); -IR_dprintk (2 ,"timeout report (duration: %d)\n" , sample); +dev_dbg (&dev->dev,"timeout report (duration: %d)\n" , sample);/* Normal sample */ }else {
@@ -98,8 +98,8 @@ void ir_lirc_raw_event(struct rc_dev *dev, struct ir_raw_event ev) sample = ev.pulse ?LIRC_PULSE (ev.duration /1000 ) :LIRC_SPACE (ev.duration /1000 ); -IR_dprintk (2 ,"delivering %uus %s to lirc_dev\n" , -TO_US (ev.duration),TO_STR (ev.pulse)); +dev_dbg (&dev->dev,"delivering %uus %s to lirc_dev\n" , +TO_US (ev.duration),TO_STR (ev.pulse)); }spin_lock_irqsave (&dev->lirc_fh_lock, flags);
drivers/media/rc/rc-ir-raw.c +3 -3
@@ -64,8 +64,8 @@ int ir_raw_event_store(struct rc_dev *dev, struct ir_raw_event *ev)if (!dev->raw)return -EINVAL ; -IR_dprintk (2 ,"sample: (%05dus %s)\n" , -TO_US (ev->duration),TO_STR (ev->pulse)); +dev_dbg (&dev->dev,"sample: (%05dus %s)\n" , +TO_US (ev->duration),TO_STR (ev->pulse));if (!kfifo_put (&dev->raw->kfifo, *ev)) {dev_err (&dev->dev,"IR event FIFO is full!\n" );
@@ -167,7 +167,7 @@ void ir_raw_event_set_idle(struct rc_dev *dev, bool idle)if (!dev->raw)return ; -IR_dprintk (2 ,"%s idle mode\n" , idle ?"enter" :"leave" ); +dev_dbg (&dev->dev,"%s idle mode\n" , idle ?"enter" :"leave" );if (idle) { dev->raw->this_ev.timeout = true;
drivers/media/rc/rc-main.c +45 -46
265 lines not on this page · raw message
include/media/rc-core.h +0 -7
@@ -23,13 +23,6 @@#include <linux/timer.h> #include <media/rc-map.h> -extern int rc_core_debug; -#define IR_dprintk (level, fmt, ...) \ -do { \ - if (rc_core_debug >= level) \ - printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__); \ -} while (0) -/** * enum rc_driver_type - type of the RC driver. *
Signature · 1 line
2.14.3
Sean Young
maintainerPATCH 3/5 media: rc: remove obsolete comment
In reply to Sean YoungThis comment is no longer relevant.
Signed-off-by Sean Young <[email protected]>
--- drivers/media/rc/rc-core-priv.h | 7 ------- 1 file changed, 7 deletions(-)
drivers/media/rc/rc-core-priv.h +0 -7
@@ -286,11 +286,4 @@ static inline int ir_lirc_register(struct rc_dev *dev) { return 0; }static inline void ir_lirc_unregister (struct rc_dev *dev) { }#endif -/* -* Decoder initialization code -* -* Those load logic are called during ir-core init, and automatically -* loads the compiled decoders for their usage with IR raw events -*/ -#endif /* _RC_CORE_PRIV */
Signature · 1 line
2.14.3
Sean Young
maintainerPATCH 4/5 media: rc: remove useless if statement
In reply to Sean Youngret is always 0, so remove if statement.
Signed-off-by Sean Young <[email protected]>
--- drivers/media/rc/lirc_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/lirc_dev.c +1 -1
@@ -568,7 +568,7 @@ static long ir_lirc_ioctl(struct file *file, unsigned int cmd, ret = -EINVAL ; else if (dev->s_timeout) ret = dev->s_timeout (dev, tmp); - else if (!ret) + else dev->timeout = tmp; }break ;
Signature · 1 line
2.14.3
Sean Young
maintainerPATCH 5/5 media: rc: get start time just before calling driver tx
In reply to Sean YoungThe current code gets the start time before copying the IR from userspace (could cause page faults) and encoding IR. This means that the gap calculation could be off.
Signed-off-by Sean Young <[email protected]>
--- drivers/media/rc/lirc_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/rc/lirc_dev.c +2 -2
@@ -247,8 +247,6 @@ static ssize_t ir_lirc_transmit_ir(struct file *file, const char __user *buf, goto out_unlock; } - start =ktime_get (); -if (!dev->tx_ir) { ret = -EINVAL ; goto out_unlock;
@@ -341,6 +339,8 @@ static ssize_t ir_lirc_transmit_ir(struct file *file, const char __user *buf, duration += txbuf[i]; } + start =ktime_get (); + ret = dev->tx_ir (dev, txbuf, count);if (ret <0 ) goto out_kfree;
Signature · 1 line
2.14.3