Skip to contentSkip to conversation

arm: socfpga: use imply instead of select for spi/mmc

PATCH New Simon Goldschmidt 4 participants 15 messages Feb 12, 2018 – Feb 13, 2018 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

---

 arch/arm/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/Kconfig +3 -3
index 225f57e847..37bf3dd69f 100644
@@ -699,13 +699,13 @@ config ARCH_SOCFPGA
 	select OF_CONTROL
 	select SPL_OF_CONTROL
 	select DM
-	select DM_SPI_FLASH
-	select DM_SPI
 	select ENABLE_ARM_SOC_BOOT0_HOOK
 	select ARCH_EARLY_INIT_R
 	select ARCH_MISC_INIT
-	select SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
 	select SYS_THUMB_BUILD
+	imply DM_SPI_FLASH
+	imply DM_SPI
+	imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
 	imply CMD_MTDPARTS
 	imply CRC32_VERIFY
 	imply FAT_WRITE
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

You can just turn them off in the defconfigs, but I get what you're trying to say.

Just reword the commit message and do make savedefconfig for all the socfpga platforms (in a separate patch) to sync the defconfigs up.

Quoted 29 lines

---

 arch/arm/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/Kconfig +3 -3
index 225f57e847..37bf3dd69f 100644
@@ -699,13 +699,13 @@ config ARCH_SOCFPGA
 	select OF_CONTROL
 	select SPL_OF_CONTROL
 	select DM
-	select DM_SPI_FLASH
-	select DM_SPI
 	select ENABLE_ARM_SOC_BOOT0_HOOK
 	select ARCH_EARLY_INIT_R
 	select ARCH_MISC_INIT
-	select SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
 	select SYS_THUMB_BUILD
+	imply DM_SPI_FLASH
+	imply DM_SPI
+	imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
 	imply CMD_MTDPARTS
 	imply CRC32_VERIFY
 	imply FAT_WRITE
Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Quoted 10 lines · Marek Vasut
Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 3 lines

Give users more freedom of choice and use imply here instead of select.

Quoted 7 lines
Quoted 2 lines

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

You can just turn them off in the defconfigs, but I get what you're trying to say.

Just reword the commit message and do make savedefconfig for all the socfpga platforms (in a separate patch) to sync the defconfigs up.

OK, thanks. Given that the same files are touched, should I wait for the CONFIG_HW_WATCHDOG patches from Lukasz to be applied first?

Simon

Quoted 30 lines
Quoted 29 lines

---

  arch/arm/Kconfig | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/Kconfig +3 -3
index 225f57e847..37bf3dd69f 100644
@@ -699,13 +699,13 @@ config ARCH_SOCFPGA
  	select OF_CONTROL
  	select SPL_OF_CONTROL
  	select DM
-	select DM_SPI_FLASH
-	select DM_SPI
  	select ENABLE_ARM_SOC_BOOT0_HOOK
  	select ARCH_EARLY_INIT_R
  	select ARCH_MISC_INIT
-	select SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
  	select SYS_THUMB_BUILD
+	imply DM_SPI_FLASH
+	imply DM_SPI
+	imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
  	imply CMD_MTDPARTS
  	imply CRC32_VERIFY
  	imply FAT_WRITE
#3 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Quoted 13 lines · Simon Goldschmidt
Quoted 12 lines · Marek Vasut
Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

Quoted 8 lines
Quoted 5 lines

You can just turn them off in the defconfigs, but I get what you're trying to say.

Just reword the commit message and do make savedefconfig for all the socfpga platforms (in a separate patch) to sync the defconfigs up.

OK, thanks. Given that the same files are touched, should I wait for the CONFIG_HW_WATCHDOG patches from Lukasz to be applied first?

You two figure it out :)

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Hi Simon, Marek,

Quoted 21 lines · Simon Goldschmidt
Quoted 20 lines · Marek Vasut
Quoted 18 lines · Simon Goldschmidt
Quoted 2 lines

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

You can just turn them off in the defconfigs, but I get what you're trying to say.

Just reword the commit message and do make savedefconfig for all the socfpga platforms (in a separate patch) to sync the defconfigs up.

Quoted 5 lines
Quoted 3 lines

OK, thanks. Given that the same files are touched, should I wait for the CONFIG_HW_WATCHDOG patches from Lukasz to be applied first?

You two figure it out :)

It is always better to ask socfpga veteran for his opinion :-)

Quoted 1 line

Simon, feel free to perform the clean up. I will have to look more closely to the WDT move to Kconfig.

Even better, you are more than welcome to use/squash this patch to your work:
http://patchwork.ozlabs.org/patch/871578/

It will simplify my WDT conversion work.

Thanks for help.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180212/85ca4e8b/attachment.sig>

#5 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Quoted 23 lines · Lukasz Majewski

Hi Simon, Marek,

Quoted 21 lines · Simon Goldschmidt
Quoted 20 lines · Marek Vasut
Quoted 18 lines · Simon Goldschmidt
Quoted 2 lines

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

You can just turn them off in the defconfigs, but I get what you're trying to say.

Just reword the commit message and do make savedefconfig for all the socfpga platforms (in a separate patch) to sync the defconfigs up.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

OK, thanks. Given that the same files are touched, should I wait for the CONFIG_HW_WATCHDOG patches from Lukasz to be applied first?

You two figure it out :)

It is always better to ask socfpga veteran for his opinion :-)

SoCFPGA veteran is old and is delegating tasks ;-)

Quoted 8 lines

Simon, feel free to perform the clean up. I will have to look more closely to the WDT move to Kconfig.

Even better, you are more than welcome to use/squash this patch to your work:
http://patchwork.ozlabs.org/patch/871578/

It will simplify my WDT conversion work.

Good!

Signature · 2 lines
Best regards,
Marek Vasut
#6 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

In reply to Marek Vasut
Quoted 8 lines · Marek Vasut
Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 8 lines
Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

You can just turn them off in the defconfigs, but I get what you're trying to say.

Well, hold on. If you have select FOO under ARCH_xxx then you can't disable it. You have to use imply FOO under ARCH_xxx so that it's turned on by default but a board can disable it in their defconfig. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180212/5c5f026a/attachment.sig>
#7 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Quoted 15 lines · Tom Rini
Quoted 14 lines · Marek Vasut
Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

Quoted 7 lines
Quoted 2 lines

You can just turn them off in the defconfigs, but I get what you're trying to say.

Well, hold on. If you have select FOO under ARCH_xxx then you can't disable it. You have to use imply FOO under ARCH_xxx so that it's turned on by default but a board can disable it in their defconfig. Thanks!

The patch is using imply already ...

Signature · 2 lines
Best regards,
Marek Vasut
#8 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Quoted 19 lines · Marek Vasut
Quoted 18 lines · Tom Rini
Quoted 16 lines · Marek Vasut
Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

You can just turn them off in the defconfigs, but I get what you're trying to say.

Quoted 6 lines
Quoted 4 lines

Well, hold on. If you have select FOO under ARCH_xxx then you can't disable it. You have to use imply FOO under ARCH_xxx so that it's turned on by default but a board can disable it in their defconfig. Thanks!

The patch is using imply already ...

Right. I wasn't clear if you were saying it wasn't needed, or just to re-word things a lot :)

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180212/16e74525/attachment.sig>
#9 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

In reply to Marek Vasut
Quoted 10 lines · Marek Vasut
Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 3 lines

Give users more freedom of choice and use imply here instead of select.

Quoted 7 lines
Quoted 2 lines

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

You can just turn them off in the defconfigs, but I get what you're trying to say.

Just reword the commit message and do make savedefconfig for all the socfpga platforms (in a separate patch) to sync the defconfigs up.

I've posted v2 today with reworded commit message. I also did make savedefconfig, but nothing changed.

Simon

Quoted 30 lines
Quoted 29 lines

---

  arch/arm/Kconfig | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/Kconfig +3 -3
index 225f57e847..37bf3dd69f 100644
@@ -699,13 +699,13 @@ config ARCH_SOCFPGA
  	select OF_CONTROL
  	select SPL_OF_CONTROL
  	select DM
-	select DM_SPI_FLASH
-	select DM_SPI
  	select ENABLE_ARM_SOC_BOOT0_HOOK
  	select ARCH_EARLY_INIT_R
  	select ARCH_MISC_INIT
-	select SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
  	select SYS_THUMB_BUILD
+	imply DM_SPI_FLASH
+	imply DM_SPI
+	imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
  	imply CMD_MTDPARTS
  	imply CRC32_VERIFY
  	imply FAT_WRITE
#10 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Quoted 13 lines · Simon Goldschmidt
Quoted 12 lines · Marek Vasut
Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

Quoted 8 lines
Quoted 5 lines

You can just turn them off in the defconfigs, but I get what you're trying to say.

Just reword the commit message and do make savedefconfig for all the socfpga platforms (in a separate patch) to sync the defconfigs up.

I've posted v2 today with reworded commit message. I also did make savedefconfig, but nothing changed.

make savedefconfig generates a defconfig file in the root of the source tree, you need to move it to configs/socfpga_foo_defconfig . Maybe that's why ?

Signature · 2 lines
Best regards,
Marek Vasut
#11 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Quoted 17 lines · Marek Vasut
Quoted 16 lines · Simon Goldschmidt
Quoted 15 lines · Marek Vasut
Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

You can just turn them off in the defconfigs, but I get what you're trying to say.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Just reword the commit message and do make savedefconfig for all the socfpga platforms (in a separate patch) to sync the defconfigs up.

I've posted v2 today with reworded commit message. I also did make savedefconfig, but nothing changed.

make savedefconfig generates a defconfig file in the root of the source tree, you need to move it to configs/socfpga_foo_defconfig . Maybe that's why ?

I know how savedefconfig works ;-)

What I wanted to say is nothing has changed. The defconfigs stay the same for me. I made mrproper, socfpga_xyz_defconfig, savedefconfig and copy defconfig configs/socfpga_xyz_defconfig, but all files staid the same.

After all, the default config remains the same, we only use imply instead of select...

Simon

#12 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Quoted 21 lines · Simon Goldschmidt
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Simon Goldschmidt
Quoted 17 lines · Marek Vasut
Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

You can just turn them off in the defconfigs, but I get what you're trying to say.

Just reword the commit message and do make savedefconfig for all the socfpga platforms (in a separate patch) to sync the defconfigs up.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

I've posted v2 today with reworded commit message. I also did make savedefconfig, but nothing changed.

make savedefconfig generates a defconfig file in the root of the source tree, you need to move it to configs/socfpga_foo_defconfig . Maybe that's why ?

I know how savedefconfig works ;-)

OK! :)

Quoted 6 lines

What I wanted to say is nothing has changed. The defconfigs stay the same for me. I made mrproper, socfpga_xyz_defconfig, savedefconfig and copy defconfig configs/socfpga_xyz_defconfig, but all files staid the same.

After all, the default config remains the same, we only use imply instead of select...

Perfect, then let's do V2 and be done with it. I don't see it in my mailbox yet ...

Quoted 2 lines

Simon

Signature · 2 lines
Best regards,
Marek Vasut
#13 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Quoted 29 lines · Marek Vasut
Quoted 18 lines · Simon Goldschmidt
Quoted 17 lines · Marek Vasut
Quoted 16 lines · Simon Goldschmidt
Quoted 15 lines · Marek Vasut
Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

You can just turn them off in the defconfigs, but I get what you're trying to say.

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Just reword the commit message and do make savedefconfig for all the socfpga platforms (in a separate patch) to sync the defconfigs up.

I've posted v2 today with reworded commit message. I also did make savedefconfig, but nothing changed.

make savedefconfig generates a defconfig file in the root of the source tree, you need to move it to configs/socfpga_foo_defconfig . Maybe that's why ?

I know how savedefconfig works ;-)

OK! :)

Quoted 8 lines
Quoted 6 lines

What I wanted to say is nothing has changed. The defconfigs stay the same for me. I made mrproper, socfpga_xyz_defconfig, savedefconfig and copy defconfig configs/socfpga_xyz_defconfig, but all files staid the same.

After all, the default config remains the same, we only use imply instead of select...

Perfect, then let's do V2 and be done with it. I don't see it in my mailbox yet ...

Uhm, sorry, I renamed it "arm: socfpga: Kconfig cleanups" as Lukasz asked me to add his patch moving CONFIG_HW_WATCHDOG to Kconfig. Sent at 6:35 AM this morning :-)

Simon

#14 lore raw

PATCH 1/1 arm: socfpga: use imply instead of select for spi/mmc

Quoted 35 lines · Simon Goldschmidt
Quoted 34 lines · Marek Vasut
Quoted 18 lines · Simon Goldschmidt
Quoted 17 lines · Marek Vasut
Quoted 16 lines · Simon Goldschmidt
Quoted 15 lines · Marek Vasut
Quoted 2 lines · Simon Goldschmidt

In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw.

things ?

what hw, all supported boards you mean ?

Quoted 5 lines

Give users more freedom of choice and use imply here instead of select.

This should allow disabling spi support completely or using sd/mmc boot in "raw mode" (no partitions).

You can just turn them off in the defconfigs, but I get what you're trying to say.

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Just reword the commit message and do make savedefconfig for all the socfpga platforms (in a separate patch) to sync the defconfigs up.

I've posted v2 today with reworded commit message. I also did make savedefconfig, but nothing changed.

make savedefconfig generates a defconfig file in the root of the source tree, you need to move it to configs/socfpga_foo_defconfig . Maybe that's why ?

I know how savedefconfig works ;-)

OK! :)

Quoted 5 lines

What I wanted to say is nothing has changed. The defconfigs stay the same for me. I made mrproper, socfpga_xyz_defconfig, savedefconfig and copy defconfig configs/socfpga_xyz_defconfig, but all files staid the same.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

After all, the default config remains the same, we only use imply instead of select...

Perfect, then let's do V2 and be done with it. I don't see it in my mailbox yet ...

Uhm, sorry, I renamed it "arm: socfpga: Kconfig cleanups" as Lukasz asked me to add his patch moving CONFIG_HW_WATCHDOG to Kconfig. Sent at 6:35 AM this morning :-)

Ah, ok, applied both, let's see what CI says, then I'll send PR.

Signature · 2 lines
Best regards,
Marek Vasut