Skip to contentSkip to conversation

LIBLO : bump version to 0.29

PATCH New Alex B 2 participants 2 messages Feb 12, 2018

lore
Share & tools
lore

Alex B

author
#0 lore raw

PATCH v3 1/1 LIBLO : bump version to 0.29

From: Alex <[email protected]>

Starting from version 0.28, C++ wrappers are provided as well. The configure script appropriately detects the availability of a C++ compiler so no Buildroot changes are needed for this.

Building fails with --enable-ipv6 so --disable-ipv6 is needed in CONF_OPTS. This is known by liblo developers and building without ipv6 support is recomennded.

werror is kept on, so disable this with --disable-werror.

Patch to fix werror about redirect from sys/poll.h to poll.h

Liblo use's atomics, some architectures need explicit linking with libatomic. Added link to reflect this.

Included hash for license files.

---
CHANGELOG
-V2
No longer including a patch for liblo/configure. This was the wrong way of dealing with --enable-ipv6. SHA256 for COPYING file instead of sha1.
Include # License files comment for clarity.
-V3
disable werror
poll.h redirect patch
link with libatomic when HAS_LIBATOMIC

---
 package/liblo/0000-server.c-fixPollHeaderRedirect.patch | 13 +++++++++++++
 package/liblo/liblo.hash                                |  9 ++++++---
 package/liblo/liblo.mk                                  | 14 +++++++++++++-
 3 files changed, 32 insertions(+), 4 deletions(-)
 create mode 100644 package/liblo/0000-server.c-fixPollHeaderRedirect.patch
package/liblo/0000-server.c-fixPollHeaderRedirect.patch new file +13 -0
new file mode 100644
index 0000000..ae284d2
@@ -0,0 +1,13 @@
+diff --git a/src/server.c b/src/server.c
+index 01fa08f..11c62d2 100644
+--- a/src/server.c
++++ b/src/server.c
+@@ -51,7 +51,7 @@
+ #include <netdb.h>
+ #include <sys/socket.h>
+ #ifdef HAVE_POLL
+-#include <sys/poll.h>
++#include <poll.h>
+ #endif
+ #include <sys/un.h>
+ #include <arpa/inet.h>
package/liblo/liblo.hash +6 -3
index a4e01a6..30a052d 100644
@@ -1,3 +1,6 @@
-# From http://sourceforge.net/projects/liblo/files/liblo/0.26/
-sha1	21942c8f19e9829b5842cb85352f98c49dfbc823  liblo-0.26.tar.gz
-md5	5351de14262560e15e7f23865293b16f  liblo-0.26.tar.gz
+# From http://sourceforge.net/projects/liblo/files/liblo/0.29/
+sha1	6aa69456787d3d6ef915281b4a0f8f2c79548ce3	liblo-0.29.tar.gz
+md5	b0e70bc0fb2254addf94adddf85cffd3		        liblo-0.29.tar.gz
+
+# Locally computed
+sha256	  5df07007198989c622f5d41de8d703e7bef3d0e79d62e24332ee739a452af62a	COPYING
package/liblo/liblo.mk +13 -1
index 3c852be..7d1bdd7 100644
@@ -4,11 +4,23 @@
 #
 ################################################################################
 
-LIBLO_VERSION = 0.26
+LIBLO_VERSION = 0.29
 LIBLO_SITE = http://downloads.sourceforge.net/project/liblo/liblo/$(LIBLO_VERSION)
 
 LIBLO_LICENSE = LGPL-2.1+
 LIBLO_LICENSE_FILES = COPYING
 LIBLO_INSTALL_STAGING = YES
 
+# IPv6 support broken, issue known upstream.
+# wError - not needed for release.
+LIBLO_CONF_OPTS += \
+	--disable-ipv6 \
+	--disable-werror
+	
+# Liblo uses atomics, so we need to link with
+# libatomic for the architectures who explicitly need libatomic.
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+LIBLO_CONF_ENV += LIBS="-latomic"
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
2.7.4
#1 lore raw

PATCH v3 1/1 LIBLO : bump version to 0.29

Hello,

Quoted 11 lines · Alex B

From: Alex <[email protected]>

Starting from version 0.28, C++ wrappers are provided as well. The configure script appropriately detects the availability of a C++ compiler so no Buildroot changes are needed for this.

Building fails with --enable-ipv6 so --disable-ipv6 is needed in CONF_OPTS. This is known by liblo developers and building without ipv6 support is recomennded.

werror is kept on, so disable this with --disable-werror.

Quoted 8 lines

Patch to fix werror about redirect from sys/poll.h to poll.h

Liblo use's atomics, some architectures need explicit linking with libatomic. Added link to reflect this.

Included hash for license files.

The liblo package has already been merged in the 'next' branch. So if you want to send fixes, please send a patch on top of the current 'next' branch, i.e an incremental patch on top of what has already been merged.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com