Skip to contentSkip to conversation

platform/x86: intel_turbo_max_3: Remove restriction for HWP platforms

PATCH In review Srinivas Pandruvada 3 participants 4 messages Feb 12, 2018 – Feb 14, 2018 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: intel_turbo_max_3: Remove restriction for HWP platforms

On systems supporting HWP (Hardware P-States) mode, we expected to enumerate core priority via ACPI-CPPC tables. Unfortunately deployment of TURBO 3.0 didn't use this method to show core priority. So users are not able to utilize this feature in HWP mode.

So remove the loading restriction of this driver for HWP enabled systems. Even if there are some systems, which are providing the core priority via ACPI CPPC, this shouldn't cause any conflict as the source of priority definition is same.

---
 drivers/platform/x86/intel_turbo_max_3.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/platform/x86/intel_turbo_max_3.c +0 -3
index d4ea01805879..a6d5aa0c3c47 100644
@@ -138,9 +138,6 @@ static int __init itmt_legacy_init(void)
 	if (!id)
 		return -ENODEV;
 
-	if (boot_cpu_has(X86_FEATURE_HWP))
-		return -ENODEV;
-
 	ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
 				"platform/x86/turbo_max_3:online",
 				itmt_legacy_cpu_online,	NULL);
Signature · 1 line
2.13.6
#1 lore raw
Quoted 10 lines · Srinivas Pandruvada

On systems supporting HWP (Hardware P-States) mode, we expected to enumerate core priority via ACPI-CPPC tables. Unfortunately deployment of TURBO 3.0 didn't use this method to show core priority. So users are not able to utilize this feature in HWP mode.

So remove the loading restriction of this driver for HWP enabled systems. Even if there are some systems, which are providing the core priority via ACPI CPPC, this shouldn't cause any conflict as the source of priority definition is same.

Pushed to my review and testing queue, thanks!

P.S. Should it go to stable?

Quoted 23 lines
---
 drivers/platform/x86/intel_turbo_max_3.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/platform/x86/intel_turbo_max_3.c +0 -4
index d4ea01805879..a6d5aa0c3c47 100644
@@ -138,9 +138,6 @@ static int __init itmt_legacy_init(void)
        if (!id)
                return -ENODEV;
 
-       if (boot_cpu_has(X86_FEATURE_HWP))
-               return -ENODEV;
-
        ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
                                "platform/x86/turbo_max_3:online",
                                itmt_legacy_cpu_online, NULL);
--

2.13.6

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 13 lines · Andy Shevchenko
Quoted 10 lines · Srinivas Pandruvada

On systems supporting HWP (Hardware P-States) mode, we expected to enumerate core priority via ACPI-CPPC tables. Unfortunately deployment of TURBO 3.0 didn't use this method to show core priority. So users are not able to utilize this feature in HWP mode.

So remove the loading restriction of this driver for HWP enabled systems. Even if there are some systems, which are providing the core priority via ACPI CPPC, this shouldn't cause any conflict as the source of priority definition is same.

Quoted 3 lines

Pushed to my review and testing queue, thanks!

P.S. Should it go to stable?

older stable at least did not have the problem

#3 lore raw
In reply to Andy Shevchenko
Quoted 18 lines · Andy Shevchenko
Quoted 7 lines · Srinivas Pandruvada

On systems supporting HWP (Hardware P-States) mode, we expected to enumerate core priority via ACPI-CPPC tables. Unfortunately deployment of
TURBO 3.0 didn't use this method to show core priority. So users are not
able to utilize this feature in HWP mode.

Quoted 8 lines

So remove the loading restriction of this driver for HWP enabled systems.
Even if there are some systems, which are providing the core priority via
ACPI CPPC, this shouldn't cause any conflict as the source of priority
definition is same.

Quoted 3 lines

Pushed to my review and testing queue, thanks!

P.S. Should it go to stable?

I want to avoid stable kernel for now.

Thanks,
Srinivas

Quoted 30 lines
Quoted 27 lines

.com>

Reported-and-tested-and-reviewed-by Arjan van de Ven <arjan@linux.

intel.com>
---
 drivers/platform/x86/intel_turbo_max_3.c | 3 ---

 1 file changed, 3 deletions(-)
drivers/platform/x86/intel_turbo_max_3.c +0 -4
index d4ea01805879..a6d5aa0c3c47 100644
@@ -138,9 +138,6 @@ static int __init itmt_legacy_init(void)
         if (!id)
                 return -ENODEV;
 
-       if (boot_cpu_has(X86_FEATURE_HWP))
-               return -ENODEV;
-
         ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
                                 "platform/x86/turbo_max_3:online",
                                 itmt_legacy_cpu_online, NULL);
--

2.13.6