Skip to contentSkip to conversation

mm/gup: Fixed coding style error and warnings.

PATCH In review Mario Leinweber 3 participants 3 messages Feb 13, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/gup: Fixed coding style error and warnings.

---
 mm/gup.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
mm/gup.c +7 -2
index 1b46e6e74881..7e463042df4a 100644
@@ -141,6 +141,7 @@ static struct page *follow_page_pte(struct vm_area_struct *vma,
 
 	if (flags & FOLL_SPLIT && PageTransCompound(page)) {
 		int ret;
+
 		get_page(page);
 		pte_unmap_unlock(ptep, ptl);
 		lock_page(page);
@@ -272,6 +273,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
 	}
 	if (flags & FOLL_SPLIT) {
 		int ret;
+
 		page = pmd_page(*pmd);
 		if (is_huge_zero_page(page)) {
 			spin_unlock(ptl);
@@ -531,7 +533,7 @@ static int faultin_page(struct task_struct *tsk, struct vm_area_struct *vma,
 	 * reCOWed by userspace write).
 	 */
 	if ((ret & VM_FAULT_WRITE) && !(vma->vm_flags & VM_WRITE))
-	        *flags |= FOLL_COW;
+		*flags |= FOLL_COW;
 	return 0;
 }
 
@@ -667,12 +669,14 @@ static long __get_user_pages(struct task_struct *tsk, struct mm_struct *mm,
 			vma = find_extend_vma(mm, start);
 			if (!vma && in_gate_area(mm, start)) {
 				int ret;
+
 				ret = get_gate_page(mm, start & PAGE_MASK,
 						gup_flags, &vma,
 						pages ? &pages[i] : NULL);
 				if (ret)
 					return i ? : ret;
 				page_mask = 0;
+
 				goto next_page;
 			}
 
@@ -696,6 +700,7 @@ static long __get_user_pages(struct task_struct *tsk, struct mm_struct *mm,
 		page = follow_page_mask(vma, start, foll_flags, &page_mask);
 		if (!page) {
 			int ret;
+
 			ret = faultin_page(tsk, vma, start, &foll_flags,
 					nonblocking);
 			switch (ret) {
@@ -1635,7 +1640,7 @@ static int gup_pmd_range(pud_t pud, unsigned long addr, unsigned long end,
 					 PMD_SHIFT, next, write, pages, nr))
 				return 0;
 		} else if (!gup_pte_range(pmd, addr, next, write, pages, nr))
-				return 0;
+			return 0;
 	} while (pmdp++, addr = next, addr != end);
 
 	return 1;
Signature · 7 lines
2.14.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
#1 lore raw

You should have a changelog.

On Tue, 2018-02-13 at 14:17 -0500, Mario Leinweber wrote:
[]

mm/gup.c

Quoted 1 line
mm/gup.c +0 -0

[]

mm/gup.c static int gup_pmd_range(pud_t pud, unsigned long addr, unsigned long end, · line 1643

Quoted 6 lines
mm/gup.c +1 -1
@@ -1635,7 +1640,7 @@ static int gup_pmd_range(pud_t pud, unsigned long addr, unsigned long end,
 					 PMD_SHIFT, next, write, pages, nr))
 				return 0;
 		} else if (!gup_pte_range(pmd, addr, next, write, pages, nr))
-				return 0;
+			return 0;

And of all these changes, this might be the only really useful one as the
indentation is misleading.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#2 lore raw
In reply to Mario Leinweber

mm/gup.c static struct page *follow_page_pte(struct vm_area_struct *vma, · line 145

Quoted 4 lines · Mario Leinweber
mm/gup.c +1 -0
 	if (flags & FOLL_SPLIT && PageTransCompound(page)) {
 		int ret;
+
 		get_page(page);

Hi Mario,

Thanks for your patch, but this kind of change to the Linux core is not generally welcomed. There are a lot of people working on the core and having whitespace changes conflict with real changes isn't a good use of people's time. You can practice whitespace changes in drivers/staging before graduating to patches which change functionality.

Hope to see you back soon!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>