platform/x86: dell-laptop: fix kbd_get_state's request value
PATCH v2 1/1 platform/x86: dell-laptop: fix kbd_get_state's request value
Commit 9862b43624a5 ("platform/x86: dell-laptop: Allocate buffer on heap rather than globally")
broke one request, changed it back to the original value.
Tested on a Dell E6540, backlight came back.
---
Changes in v2:
- split the fix and the function merge part
drivers/platform/x86/dell-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/dell-laptop.c +1 -1
@@ -1279,7 +1279,7 @@ static int kbd_get_state(struct kbd_state *state)struct calling_interface_buffer buffer;int ret; -dell_fill_request (&buffer,0 ,0 ,0 ,0 ); +dell_fill_request (&buffer,0x1 ,0 ,0 ,0 ); ret =dell_send_request (&buffer,CLASS_KBD_BACKLIGHT ,SELECT_KBD_BACKLIGHT );if (ret)
Signature · 1 line
2.7.4
Quoted 37 lines
-----Original Message-----
From: [email protected] [mailto:platform-driver-x86- [email protected]] On Behalf Of Laszlo Toth
Sent: Tuesday, February 13, 2018 1:28 PM
To: Matthew Garrett <[email protected]>; Pali Rohár <[email protected]>; Darren Hart <[email protected]>; Andy Shevchenko <[email protected]>; [email protected]; Limonciello, Mario <[email protected]>
Subject: [PATCH v2] platform/x86: dell-laptop: fix kbd_get_state's request valueCommit
9862b43624a5("platform/x86: dell-laptop: Allocate buffer on heap rather than globally")
broke one request, changed it back to the original value.Tested on a Dell E6540, backlight came back.
Signed-off-by Laszlo Toth <[email protected]>---
Changes in v2:
- split the fix and the function merge partdrivers/platform/x86/dell-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/dell-laptop.c +1
-1@@ -1279,7 +1279,7 @@ static int kbd_get_state(struct kbd_state *state)struct calling_interface_buffer buffer;int ret; -dell_fill_request (&buffer,0 ,0 ,0 ,0 ); +dell_fill_request (&buffer,0x1 ,0 ,0 ,0 ); ret =dell_send_request (&buffer,CLASS_KBD_BACKLIGHT ,SELECT_KBD_BACKLIGHT );
Quoted 3 lines
if (ret)
--
2.7.4
This should also CC stable and
Fixes 9862b43624a5450a097cc4122732857b869dbbca