Skip to contentSkip to conversation

package/mesa-demo: remove duplicate osmesa option

PATCH New Audrey Motheron 3 participants 4 messages Feb 12, 2018 – Feb 13, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mesa-demo: remove duplicate osmesa option

--disable-osmesa option is unconditionally added to CONF_OPTS even if --enable-osmesa is used latter.

---
 package/mesa3d-demos/mesa3d-demos.mk | 1 -
 1 file changed, 1 deletion(-)
package/mesa3d-demos/mesa3d-demos.mk +0 -1
index cbc15c3b69..9182803748 100644
@@ -12,7 +12,6 @@ MESA3D_DEMOS_DEPENDENCIES = host-pkgconf
 MESA3D_DEMOS_LICENSE = MIT
 
 MESA3D_DEMOS_CONF_OPTS += \
-	--disable-osmesa \
 	--disable-gles1
 
 ifeq ($(BR2_PACKAGE_XORG7)$(BR2_PACKAGE_HAS_LIBGL),yy)
Signature · 1 line
2.14.3
#1 lore raw

PATCH 1/1 package/mesa-demo: remove duplicate osmesa option

Hello,

Thanks for the patch, indeed the option was being duplicated! Just one small
comment: usually the commit summary line has only the package name, without the ?package/? prefix, and in this case the package name is ?mesa-demos?, so the first line of the commit message should be.

Quoted 22 lines · Audrey Motheron

--disable-osmesa option is unconditionally added to CONF_OPTS even if --enable-osmesa is used latter.

---
 package/mesa3d-demos/mesa3d-demos.mk | 1 -
 1 file changed, 1 deletion(-)
package/mesa3d-demos/mesa3d-demos.mk +0 -1
index cbc15c3b69..9182803748 100644
@@ -12,7 +12,6 @@ MESA3D_DEMOS_DEPENDENCIES = host-pkgconf
 MESA3D_DEMOS_LICENSE = MIT
 
 MESA3D_DEMOS_CONF_OPTS += \
-	--disable-osmesa \
 	--disable-gles1
 
 ifeq ($(BR2_PACKAGE_XORG7)$(BR2_PACKAGE_HAS_LIBGL),yy)
Signature · 1 line
2.14.3

--
Adri?n ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180212/95c882e4/attachment.asc>

#2 lore raw

PATCH 1/1 package/mesa-demo: remove duplicate osmesa option

Hello,

Quoted 5 lines · Adrian Perez de Castro

Hello,

Thanks for the patch, indeed the option was being duplicated! Just one small
comment: usually the commit summary line has only the package name, without the ?package/? prefix, and in this case the package name is ?mesa-demos?,

Actually the package name is mesa3d-demos :-)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
#3 lore raw

PATCH 1/1 package/mesa-demo: remove duplicate osmesa option

In reply to Audrey Motheron

Hello,

Quoted 7 lines · Audrey Motheron

--disable-osmesa option is unconditionally added to CONF_OPTS even if --enable-osmesa is used latter.

---
 package/mesa3d-demos/mesa3d-demos.mk | 1 -
 1 file changed, 1 deletion(-)

As Adrian said, the commit title should match the package name:
mesa3d-demos. I've fixed that up and applied to master. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com