Skip to contentSkip to conversation

qt5webengine: fix build issue with alsa

PATCH Superseded Gaël PORTAY 2 participants 4 messages Feb 9, 2018 – Feb 13, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qt5webengine: fix build issue with alsa

Qt WebEngine auto-guesses if it compiles support for alsa. When the alsa-lib config is enabled but the features mixer, rawmidi, hwdep and seq are not also enabled, it leads to a build failure.

Lets the developer decide whether or not support for alsa in Qt WebEngine by adding the new config BR2_PACKAGE_QT5WEBENGINE_ALSA that selects the features it needs when it is set.

Fixes [1].

[1]: http://autobuild.buildroot.net/results/d81537a8f67bb0a3625057560b2f16daf4828f98/build-end.log

---
 package/qt5/qt5webengine/Config.in       | 10 ++++++++++
 package/qt5/qt5webengine/qt5webengine.mk |  6 ++++++
 2 files changed, 16 insertions(+)
package/qt5/qt5webengine/Config.in +10 -0
index d0c8d18210..387ce0a76e 100644
@@ -81,4 +81,14 @@ config BR2_PACKAGE_QT5WEBENGINE_PROPRIETARY_CODECS
 	  which includes required proprietary audio and video codecs,
 	  such as H.264 and MPEG layer-3 (MP3).
 
+config BR2_PACKAGE_QT5WEBENGINE_ALSA
+	bool "alsa"
+	depends on BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_ALSA_LIB_MIXER
+	select BR2_PACKAGE_ALSA_LIB_RAWMIDI
+	select BR2_PACKAGE_ALSA_LIB_HWDEP
+	select BR2_PACKAGE_ALSA_LIB_SEQ
+	help
+	  Enable ALSA support.
+
 endif
package/qt5/qt5webengine/qt5webengine.mk +6 -0
index 96dd401c6c..344ecc514b 100644
@@ -28,6 +28,12 @@ ifeq ($(BR2_PACKAGE_QT5WEBENGINE_PROPRIETARY_CODECS),y)
 QT5WEBENGINE_QMAKEFLAGS += WEBENGINE_CONFIG+=use_proprietary_codecs
 endif
 
+ifeq ($(BR2_PACKAGE_QT5WEBENGINE_ALSA),y)
+QT5WEBENGINE_DEPENDENCIES += alsa-lib
+else
+QT5WEBENGINE_QMAKEFLAGS += QT_CONFIG-=alsa
+endif
+
 # QtWebengine's build system uses python, but only supports python2. We work
 # around this by forcing python2 early in the PATH, via a python->python2
 # symlink.
Signature · 1 line
2.15.1
#1 lore raw

PATCH 1/1 qt5webengine: fix build issue with alsa

package/qt5/qt5webengine/Config.in config BR2_PACKAGE_QT5WEBENGINE_PROPRIETARY_CODECS · line 86

Quoted 3 lines · Ga?l PORTAY
package/qt5/qt5webengine/Config.in +3 -0
+config BR2_PACKAGE_QT5WEBENGINE_ALSA
+	bool "alsa"
+	depends on BR2_PACKAGE_ALSA_LIB

Well, I should probably select BR2_PACKAGE_ALSA_LIB instead of depending on it :/

Quoted 7 lines
package/qt5/qt5webengine/Config.in +7 -0
+	select BR2_PACKAGE_ALSA_LIB_MIXER
+	select BR2_PACKAGE_ALSA_LIB_RAWMIDI
+	select BR2_PACKAGE_ALSA_LIB_HWDEP
+	select BR2_PACKAGE_ALSA_LIB_SEQ
+	help
+	  Enable ALSA support.
+
#2 lore raw

PATCH 1/1 qt5webengine: fix build issue with alsa

Hello,

Quoted 7 lines · Ga?l PORTAY

package/qt5/qt5webengine/Config.in config BR2_PACKAGE_QT5WEBENGINE_PROPRIETARY_CODECS · line 86

Quoted 3 lines · Ga?l PORTAY
package/qt5/qt5webengine/Config.in +3 -0
+config BR2_PACKAGE_QT5WEBENGINE_ALSA
+	bool "alsa"
+	depends on BR2_PACKAGE_ALSA_LIB  

Well, I should probably select BR2_PACKAGE_ALSA_LIB instead of depending on it :/

Are you going to submit an updated version ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
#3 lore raw

PATCH 1/1 qt5webengine: fix build issue with alsa

Thomas,

Quoted 4 lines · Thomas Petazzoni

Hello,

Quoted 1 line · Ga?l PORTAY

On Thu, Feb 08, 2018 at 08:22:36PM -0500, Ga?l PORTAY wrote:

Quoted 9 lines
Quoted 6 lines

package/qt5/qt5webengine/Config.in config BR2_PACKAGE_QT5WEBENGINE_PROPRIETARY_CODECS · line 86

Quoted 3 lines
package/qt5/qt5webengine/Config.in +3 -0
+config BR2_PACKAGE_QT5WEBENGINE_ALSA
+	bool "alsa"
+	depends on BR2_PACKAGE_ALSA_LIB  

Well, I should probably select BR2_PACKAGE_ALSA_LIB instead of depending on it :/

Are you going to submit an updated version ?

Let me test again the fix with select and I will send a v2 shortly.

Quoted 11 lines

Thanks,

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Regards,
Gael